commit 88c1a9ecbc52f60b8f79a0111c54b9c9600c1c5a
author Sebastian Jansson <srte@webrtc.org> Thu Aug 30 13:58:38 2018 +0200
committer Commit Bot <commit-bot@chromium.org> Mon Sep 03 09:12:10 2018 +0000
tree 50cc546eeda45fc747dcfdd6923bed09b097553e
parent 16e27a1dc59f6fb46bc318ccfff642383b4802a9

Adds infinite addition and subtraction to time units.

This prepares for allowing use making arithmetic operators constexpr.

This also makes it easier to use for comparisons with offsets.
Now a > b + 10 ms works even if b is infinite.

Bug: webrtc:9574
Change-Id: Ie36092b72c2ec0f0c541641199a39155f5a796f3
Reviewed-on: https://webrtc-review.googlesource.com/96820
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24530}

api/units/timestamp_unittest.cc

diff --git a/api/units/timestamp_unittest.cc b/api/units/timestamp_unittest.cc
index db894cc..ff0c79e 100644
--- a/api/units/timestamp_unittest.cc
+++ b/api/units/timestamp_unittest.cc
@@ -118,10 +118,27 @@
   const Timestamp time_a = Timestamp::ms(kValueA);
   const Timestamp time_b = Timestamp::ms(kValueB);
   const TimeDelta delta_a = TimeDelta::ms(kValueA);
+  const TimeDelta delta_b = TimeDelta::ms(kValueB);
 
   EXPECT_EQ((time_a - time_b), TimeDelta::ms(kValueA - kValueB));
   EXPECT_EQ((time_b - delta_a), Timestamp::ms(kValueB - kValueA));
   EXPECT_EQ((time_b + delta_a), Timestamp::ms(kValueB + kValueA));
+
+  Timestamp mutable_time = time_a;
+  mutable_time += delta_b;
+  EXPECT_EQ(mutable_time, time_a + delta_b);
+  mutable_time -= delta_b;
+  EXPECT_EQ(mutable_time, time_a);
+}
+
+TEST(UnitConversionTest, InfinityOperations) {
+  const int64_t kValue = 267;
+  const Timestamp finite_time = Timestamp::ms(kValue);
+  const TimeDelta finite_delta = TimeDelta::ms(kValue);
+  EXPECT_TRUE((Timestamp::Infinity() + finite_delta).IsInfinite());
+  EXPECT_TRUE((Timestamp::Infinity() - finite_delta).IsInfinite());
+  EXPECT_TRUE((finite_time + TimeDelta::PlusInfinity()).IsInfinite());
+  EXPECT_TRUE((finite_time - TimeDelta::MinusInfinity()).IsInfinite());
 }
 }  // namespace test
 }  // namespace webrtc