commit 881f16891bb8ebca588b0dfda9ee177896ad1eef
author Karl Wiberg <kwiberg@webrtc.org> Thu Mar 08 15:03:23 2018 +0100
committer Commit Bot <commit-bot@chromium.org> Fri Mar 09 11:32:34 2018 +0000
tree f21af6fcbe4f45ed49d71ab8ddbbfed24625a317
parent 4c6a30c1bf745d474b34e403232e13a3a764f33e

Make SimpleStringBuilder into a non-template

So that future CLs can de-inline its methods.

We do this by asking the caller to allocate the buffer instead of
having it as a data member.

Bug: webrtc:8982
Change-Id: I246b0973e54510fdd880c3b6875336c31334d008
Reviewed-on: https://webrtc-review.googlesource.com/60000
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org>
Reviewed-by: Tommi <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22355}

rtc_base/logging.cc

diff --git a/rtc_base/logging.cc b/rtc_base/logging.cc
index 4798f4d..ec8cd7f 100644
--- a/rtc_base/logging.cc
+++ b/rtc_base/logging.cc
@@ -127,7 +127,8 @@
     print_stream_ << "(" << FilenameFromPath(file)  << ":" << line << "): ";
 
   if (err_ctx != ERRCTX_NONE) {
-    SimpleStringBuilder<1024> tmp;
+    char tmp_buf[1024];
+    SimpleStringBuilder tmp(tmp_buf);
     tmp.AppendFormat("[0x%08X]", err);
     switch (err_ctx) {
       case ERRCTX_ERRNO: