commit 84df1c724e91af36569e6cf9aa9e6a4345746c2b
author Jonas Olsson <jonasolsson@webrtc.org> Fri Sep 14 16:59:32 2018 +0200
committer Commit Bot <commit-bot@chromium.org> Mon Sep 24 09:39:19 2018 +0000
tree 228b433c56964d56b6ae4583299bd5922e4bfc67
parent 4e5342f06ae3aed3f7432ed14b31fb678d09db50

Make fewer copies when using StringBuilder.

Replace calls to .str() which copies with .Release which moves in cases where that's safe.

This CL was generated by this command:
git grep -l 'StringBuilder' |
xargs perl -i -0 -pe "s/(rtc::StringBuilder (\S+);.*?return )\\g2.str\(\)/\$1\$2.Release\(\)/sg"

Bug: webrtc:8982
Change-Id: If4dadbeb039df010aaaa9e58da81c1971a84fe8f
Reviewed-on: https://webrtc-review.googlesource.com/100307
Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24790}

rtc_base/strings/string_builder.h

diff --git a/rtc_base/strings/string_builder.h b/rtc_base/strings/string_builder.h
index d95b29d..186c2f7 100644
--- a/rtc_base/strings/string_builder.h
+++ b/rtc_base/strings/string_builder.h
@@ -157,8 +157,8 @@
   size_t size() const { return str_.size(); }
 
   std::string Release() {
-    std::string ret;
-    std::swap(str_, ret);
+    std::string ret = std::move(str_);
+    str_.clear();
     return ret;
   }