commit 81acd03f8965b5a3a0fb1cc3fe436855181775ee
author Florent Castelli <orphis@webrtc.org> Mon Apr 04 15:18:25 2022 +0200
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Apr 04 17:59:58 2022 +0000
tree 3365bde9152f0ce3e80fb544e08715d67156e7f0
parent 429c1bd74d5b821a360be6a215bcbe7c422bedeb

tools: Better dependency fixing

Lines like 'deps = [ "foo" ]' would fail to be fixed.
Just insert the new dependencies in front and let the formatter have fun
with this after.

Bug: None
Change-Id: I747925cd0a1de93715a00b9ff3490b555f237e97
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257906
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Auto-Submit: Florent Castelli <orphis@webrtc.org>
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36429}

tools_webrtc/gn_check_autofix.py

diff --git a/tools_webrtc/gn_check_autofix.py b/tools_webrtc/gn_check_autofix.py
index 1a93898..3895dc9 100644
--- a/tools_webrtc/gn_check_autofix.py
+++ b/tools_webrtc/gn_check_autofix.py
@@ -81,11 +81,10 @@
                                        for dep in missing_deps[target]) +
                 ']\n') + line
         indentation_level = None
-      elif line.strip().startswith('deps'):
-        is_empty_deps = line.strip() == 'deps = []'
-        line = 'deps = [\n' if is_empty_deps else line
-        line += ''.join('  "' + dep + '",\n' for dep in missing_deps[target])
-        line += ']\n' if is_empty_deps else ''
+      elif line.strip().startswith('deps = ['):
+        joined_deps = ''.join('  "' + dep + '",\n'
+                              for dep in missing_deps[target])
+        line = line.replace('deps = [', 'deps = [' + joined_deps)
         indentation_level = None
 
     if line.strip() not in deleted_sources: