commit 80adac053cab279954d552fa6aa9d1c893ab1a47
author VladimirTechMan <vladimirtechman@gmail.com> Thu Nov 23 12:22:11 2017 -0500
committer Commit Bot <commit-bot@chromium.org> Mon Nov 27 09:01:42 2017 +0000
tree 0b0f5c266821ecd14be1ada874acdd2d8d5fa858
parent 09819ec373448c539934273d970ba05e4e402573

Set video codec names in public API using existing cricket constants

For better consistency between the Objective-C API constant definitions
and the existing constants defined in the underlying core, re-use the
available video codec-name constants from cricket to define the peer
constants in the public API.

BUG=None

Change-Id: I8d5ddc2c1bd6670810fca1665aaf9a116620a34e
Reviewed-on: https://webrtc-review.googlesource.com/25360
Commit-Queue: Kári Helgason <kthelgason@webrtc.org>
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20883}

sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodec.mm

diff --git a/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodec.mm b/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodec.mm
index 8886209..4a5d450 100644
--- a/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodec.mm
+++ b/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodec.mm
@@ -14,9 +14,11 @@
 #import "RTCVideoCodec+Private.h"
 #import "WebRTC/RTCVideoCodecFactory.h"
 
-NSString *const kRTCVideoCodecVp8Name = @"VP8";
-NSString *const kRTCVideoCodecVp9Name = @"VP9";
-NSString *const kRTCVideoCodecH264Name = @"H264";
+#include "media/base/mediaconstants.h"
+
+NSString *const kRTCVideoCodecVp8Name = @(cricket::kVp8CodecName);
+NSString *const kRTCVideoCodecVp9Name = @(cricket::kVp9CodecName);
+NSString *const kRTCVideoCodecH264Name = @(cricket::kH264CodecName);
 NSString *const kRTCLevel31ConstrainedHigh = @"640c1f";
 NSString *const kRTCLevel31ConstrainedBaseline = @"42e01f";
 

sdk/objc/Framework/Classes/VideoToolbox/objc_video_encoder_factory.mm

diff --git a/sdk/objc/Framework/Classes/VideoToolbox/objc_video_encoder_factory.mm b/sdk/objc/Framework/Classes/VideoToolbox/objc_video_encoder_factory.mm
index 9e76626..1380486 100644
--- a/sdk/objc/Framework/Classes/VideoToolbox/objc_video_encoder_factory.mm
+++ b/sdk/objc/Framework/Classes/VideoToolbox/objc_video_encoder_factory.mm
@@ -80,7 +80,7 @@
     // CodecSpecificInfo only handles a hard coded list of codecs
     id<RTCCodecSpecificInfo> rtcCodecSpecificInfo = nil;
     if (codec_specific_info) {
-      if (strcmp(codec_specific_info->codec_name, "H264") == 0) {
+      if (strcmp(codec_specific_info->codec_name, cricket::kH264CodecName) == 0) {
         RTCCodecSpecificInfoH264 *h264Info = [[RTCCodecSpecificInfoH264 alloc] init];
         h264Info.packetizationMode =
             (RTCH264PacketizationMode)codec_specific_info->codecSpecific.H264.packetization_mode;