commit 7fa9057a0558e315f822c505b1f4516952c9f6cc
author Ali Tofigh <alito@webrtc.org> Thu Mar 17 15:47:49 2022 +0100
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Mar 17 15:39:26 2022 +0000
tree 5eabbb2add5558f6b206502b9f204fb90ca7cb7a
parent 1a08096998a38a40f76ed7b014805c3d7edfac4d

Adopt absl::string_view in function parameters under rtc_base/

This is part of a large-scale effort to increase adoption of
absl::string_view across the WebRTC code base.

This CL converts the majority of "const std::string&"s in function
parameters under rtc_base/ to absl::string_view.

Bug: webrtc:13579
Change-Id: I2b1e3776aa42326aa405f76bb324a2d233b21dca
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/254081
Reviewed-by: Niels Moller <nisse@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Xavier Lepaul‎ <xalep@webrtc.org>
Reviewed-by: Anders Lilienthal <andersc@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Ali Tofigh <alito@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36239}

rtc_base/strings/json.cc

diff --git a/rtc_base/strings/json.cc b/rtc_base/strings/json.cc
index 9966440..af8ba18 100644
--- a/rtc_base/strings/json.cc
+++ b/rtc_base/strings/json.cc
@@ -14,6 +14,7 @@
 #include <limits.h>
 #include <stdlib.h>
 
+#include "absl/strings/string_view.h"
 #include "rtc_base/string_encode.h"
 
 namespace rtc {
@@ -240,46 +241,47 @@
 }
 
 bool GetValueFromJsonObject(const Json::Value& in,
-                            const std::string& k,
+                            absl::string_view k,
                             Json::Value* out) {
-  if (!in.isObject() || !in.isMember(k)) {
+  std::string k_str = std::string(k);
+  if (!in.isObject() || !in.isMember(k_str)) {
     return false;
   }
 
-  *out = in[k];
+  *out = in[k_str];
   return true;
 }
 
 bool GetIntFromJsonObject(const Json::Value& in,
-                          const std::string& k,
+                          absl::string_view k,
                           int* out) {
   Json::Value x;
   return GetValueFromJsonObject(in, k, &x) && GetIntFromJson(x, out);
 }
 
 bool GetUIntFromJsonObject(const Json::Value& in,
-                           const std::string& k,
+                           absl::string_view k,
                            unsigned int* out) {
   Json::Value x;
   return GetValueFromJsonObject(in, k, &x) && GetUIntFromJson(x, out);
 }
 
 bool GetStringFromJsonObject(const Json::Value& in,
-                             const std::string& k,
+                             absl::string_view k,
                              std::string* out) {
   Json::Value x;
   return GetValueFromJsonObject(in, k, &x) && GetStringFromJson(x, out);
 }
 
 bool GetBoolFromJsonObject(const Json::Value& in,
-                           const std::string& k,
+                           absl::string_view k,
                            bool* out) {
   Json::Value x;
   return GetValueFromJsonObject(in, k, &x) && GetBoolFromJson(x, out);
 }
 
 bool GetDoubleFromJsonObject(const Json::Value& in,
-                             const std::string& k,
+                             absl::string_view k,
                              double* out) {
   Json::Value x;
   return GetValueFromJsonObject(in, k, &x) && GetDoubleFromJson(x, out);