commit 7b04a91f4a91aab902f9ac500c55d26fab6f1f49
author Niels Möller <nisse@webrtc.org> Fri Sep 13 15:41:21 2019 +0200
committer Commit Bot <commit-bot@chromium.org> Wed Sep 18 16:27:44 2019 +0000
tree 6f5fe2b3af61371bc562266791c87073b3407643
parent e607a06338a8901414a26d2fa6871027cc62ae41

Delete almost all default methods on PeerConnectionInterface

Keeping default implementations only for methods involved in
ongoing transitions.

Intended to catch inconsistencies between the interface and the
PeerConnectionProxy class, at compile time.

Bug: webrtc:10716
Change-Id: I4cb126c353855f7288ba09273fa6f87aaa0f32eb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140860
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29224}

api/test/mock_peerconnectioninterface.h

diff --git a/api/test/mock_peerconnectioninterface.h b/api/test/mock_peerconnectioninterface.h
index 80a5baa..aacaaf6 100644
--- a/api/test/mock_peerconnectioninterface.h
+++ b/api/test/mock_peerconnectioninterface.h
@@ -13,6 +13,7 @@
 
 #include <memory>
 #include <string>
+#include <type_traits>
 #include <utility>
 #include <vector>
 
@@ -39,6 +40,8 @@
                    MediaStreamTrackInterface*,
                    std::vector<MediaStreamInterface*>));
   MOCK_METHOD1(RemoveTrack, bool(RtpSenderInterface*));
+  MOCK_METHOD1(RemoveTrackNew,
+               RTCError(rtc::scoped_refptr<RtpSenderInterface>));
   MOCK_METHOD1(AddTransceiver,
                RTCErrorOr<rtc::scoped_refptr<RtpTransceiverInterface>>(
                    rtc::scoped_refptr<MediaStreamTrackInterface>));
@@ -91,6 +94,7 @@
                      const SessionDescriptionInterface*());
   MOCK_CONST_METHOD0(pending_remote_description,
                      const SessionDescriptionInterface*());
+  MOCK_METHOD0(RestartIce, void());
   MOCK_METHOD2(CreateOffer,
                void(CreateSessionDescriptionObserver*,
                     const RTCOfferAnswerOptions&));
@@ -116,15 +120,22 @@
   MOCK_METHOD1(SetBitrate, RTCError(const BitrateParameters&));
   MOCK_METHOD1(SetAudioPlayout, void(bool));
   MOCK_METHOD1(SetAudioRecording, void(bool));
+  MOCK_METHOD1(LookupDtlsTransportByMid,
+               rtc::scoped_refptr<DtlsTransportInterface>(const std::string&));
   MOCK_METHOD0(signaling_state, SignalingState());
   MOCK_METHOD0(ice_connection_state, IceConnectionState());
+  MOCK_METHOD0(standardized_ice_connection_state, IceConnectionState());
+  MOCK_METHOD0(peer_connection_state, PeerConnectionState());
   MOCK_METHOD0(ice_gathering_state, IceGatheringState());
   MOCK_METHOD2(StartRtcEventLog,
                bool(std::unique_ptr<RtcEventLogOutput>, int64_t));
+  MOCK_METHOD1(StartRtcEventLog, bool(std::unique_ptr<RtcEventLogOutput>));
   MOCK_METHOD0(StopRtcEventLog, void());
   MOCK_METHOD0(Close, void());
 };
 
+static_assert(!std::is_abstract<MockPeerConnectionInterface>::value, "");
+
 }  // namespace webrtc
 
 #endif  // API_TEST_MOCK_PEERCONNECTIONINTERFACE_H_