commit 796cfaf7f76aa740cc7f4bb2c94f88637e475324
author perkj <perkj@webrtc.org> Thu Dec 10 09:27:38 2015 -0800
committer Commit bot <commit-bot@chromium.org> Thu Dec 10 17:27:45 2015 +0000
tree 18fdbdd4842c588046097e273cacb05403f67859
parent 4d68208a2089bfb7c9bf87f06722033a9e82a2a3

Add VideoCodec::PreferDecodeLate
The purpose is so that a decoder (Android) that only have a limited number of output buffers can make sure that decoding is done just before the frame is needed.

Removed unused iSupportsRenderTiming and the settings structs since it was not used.
Added VCMReceiver::FrameForDecoding unit test for the case when PreferDecodeLate is set.

Note that this does not change the current behaviour. We actually currently always decode frames late. This cl is to make sure the behaviour is kept for Android, if the default behaviour is changed.

Review URL: https://codereview.webrtc.org/1428293003

Cr-Commit-Position: refs/heads/master@{#10974}

webrtc/modules/video_coding/codec_database.h

diff --git a/webrtc/modules/video_coding/codec_database.h b/webrtc/modules/video_coding/codec_database.h
index c39474f..62ec30a 100644
--- a/webrtc/modules/video_coding/codec_database.h
+++ b/webrtc/modules/video_coding/codec_database.h
@@ -36,12 +36,10 @@
 struct VCMExtDecoderMapItem {
  public:
   VCMExtDecoderMapItem(VideoDecoder* external_decoder_instance,
-                       uint8_t payload_type,
-                       bool internal_render_timing);
+                       uint8_t payload_type);
 
   uint8_t payload_type;
   VideoDecoder* external_decoder_instance;
-  bool internal_render_timing;
 };
 
 class VCMCodecDataBase {
@@ -90,12 +88,8 @@
   bool DeregisterExternalDecoder(uint8_t payload_type);
 
   // Registers an external decoder object to the payload type |payload_type|.
-  // |internal_render_timing| is set to true if the |external_decoder| has
-  // built in rendering which is able to obey the render timestamps of the
-  // encoded frames.
   void RegisterExternalDecoder(VideoDecoder* external_decoder,
-                               uint8_t payload_type,
-                               bool internal_render_timing);
+                               uint8_t payload_type);
 
   bool DecoderRegistered() const;
 
@@ -124,10 +118,9 @@
   // deep copies returned by CreateDecoderCopy().
   void ReleaseDecoder(VCMGenericDecoder* decoder) const;
 
-  // Returns true if the currently active decoder supports render scheduling,
-  // that is, it is able to render frames according to the render timestamp of
-  // the encoded frames.
-  bool SupportsRenderScheduling() const;
+  // Returns true if the currently active decoder prefer to decode frames late.
+  // That means that frames must be decoded near the render times stamp.
+  bool PrefersLateDecoding() const;
 
   bool MatchesCurrentResolution(int width, int height) const;