commit 78161ca59d4b58bf4e51f4519f81ba3ab4821ea1
author Danil Chapovalov <danilchap@webrtc.org> Thu Oct 26 12:09:41 2017 +0200
committer Commit Bot <commit-bot@chromium.org> Thu Oct 26 13:33:16 2017 +0000
tree 79fb9c99b016564f5d05b4315a3ce34147fe2262
parent 4556f3c3f47c5453d3995a8fc62989e810c28389

Add sending sdes to RtcpTransceiver.

Bug: webrtc:8239
Change-Id: Icff1528e177e0bb39dd82bd4f8533e1ed2736c40
Reviewed-on: https://webrtc-review.googlesource.com/15540
Reviewed-by: Niels Moller <nisse@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20447}

modules/rtp_rtcp/source/rtcp_transceiver_impl.cc

diff --git a/modules/rtp_rtcp/source/rtcp_transceiver_impl.cc b/modules/rtp_rtcp/source/rtcp_transceiver_impl.cc
index 6feb55da..c8db3c8 100644
--- a/modules/rtp_rtcp/source/rtcp_transceiver_impl.cc
+++ b/modules/rtp_rtcp/source/rtcp_transceiver_impl.cc
@@ -19,6 +19,7 @@
 #include "modules/rtp_rtcp/source/rtcp_packet.h"
 #include "modules/rtp_rtcp/source/rtcp_packet/receiver_report.h"
 #include "modules/rtp_rtcp/source/rtcp_packet/report_block.h"
+#include "modules/rtp_rtcp/source/rtcp_packet/sdes.h"
 #include "rtc_base/checks.h"
 
 namespace webrtc {
@@ -87,8 +88,13 @@
     rr.SetReportBlocks(std::move(report_blocks));
   }
   sender.AppendPacket(rr);
-  // TODO(danilchap): Append SDES to conform to the requirements on minimal
-  // compound RTCP packet.
+  if (!config_.cname.empty()) {
+    rtcp::Sdes sdes;
+    bool added = sdes.AddCName(config_.feedback_ssrc, config_.cname);
+    RTC_DCHECK(added) << "Failed to add cname " << config_.cname
+                      << " to rtcp sdes packet.";
+    sender.AppendPacket(sdes);
+  }
 
   sender.Send();
 }