commit 727ac1d4c00cb12cd7e8eedfcaa29657eb03cb02
author kjellander <kjellander@webrtc.org> Wed Mar 08 02:12:11 2017 -0800
committer Commit bot <commit-bot@chromium.org> Wed Mar 08 10:12:11 2017 +0000
tree e0aa91c5556eecd89ada4f601b6a380bf14f9306
parent 0d4e235a963aa58bd3ae05aece45331a68d83adf

Enable GN check for webrtc/logging

BUG=webrtc:6828, webrtc:7257
NOTRY=True

Review-Url: https://codereview.webrtc.org/2717903002
Cr-Commit-Position: refs/heads/master@{#17111}

.gn

diff --git a/.gn b/.gn
index 4b2edf0..0976bb8 100644
--- a/.gn
+++ b/.gn
@@ -28,6 +28,7 @@
   "//webrtc/common_video/*",
   "//webrtc/common_audio/*",
   "//webrtc/examples/*",
+  "//webrtc/logging/*",
   "//webrtc/media/*",
   "//webrtc/modules/*",
   "//webrtc/stats/*",

webrtc/logging/BUILD.gn

diff --git a/webrtc/logging/BUILD.gn b/webrtc/logging/BUILD.gn
index 52d421e..0cf5731 100644
--- a/webrtc/logging/BUILD.gn
+++ b/webrtc/logging/BUILD.gn
@@ -23,9 +23,19 @@
 }
 
 rtc_source_set("rtc_event_log_api") {
+  # TODO(kjellander): Remove (bugs.webrtc.org/7257)
+  # Enabling GN check triggers cyclic dependency error:
+  #  //webrtc/logging:rtc_event_log_api ->
+  #  //webrtc/modules/audio_coding:audio_network_adaptor ->
+  #  //webrtc/logging:rtc_event_log_api
+  check_includes = false
   sources = [
     "rtc_event_log/rtc_event_log.h",
   ]
+  deps = [
+    "../base:rtc_base_approved",
+    "../call:call_interfaces",
+  ]
 }
 
 rtc_static_library("rtc_event_log_impl") {
@@ -41,9 +51,11 @@
   deps = [
     ":rtc_event_log_api",
     "..:webrtc_common",
+    "../base:rtc_base_approved",
     "../call:call_interfaces",
     "../modules/audio_coding:audio_network_adaptor",
     "../modules/rtp_rtcp",
+    "../system_wrappers",
   ]
 
   if (rtc_enable_protobuf) {
@@ -71,14 +83,21 @@
     ]
 
     public_deps = [
+      ":rtc_event_log_api",
       ":rtc_event_log_proto",
       "..:webrtc_common",
+      "../call:call_interfaces",
+      "../modules/rtp_rtcp:rtp_rtcp",
+      "../system_wrappers",
     ]
 
     if (!build_with_chromium && is_clang) {
       # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
       suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
     }
+    deps = [
+      "../base:rtc_base_approved",
+    ]
   }
 
   if (rtc_include_tests) {
@@ -92,9 +111,12 @@
       deps = [
         ":rtc_event_log_impl",
         ":rtc_event_log_parser",
+        "../base:rtc_base_approved",
+        "../base:rtc_base_tests_utils",
         "../call",
         "../modules/rtp_rtcp",
         "../system_wrappers:metrics_default",
+        "../test:test_support",
         "//testing/gmock",
         "//testing/gtest",
       ]
@@ -137,6 +159,7 @@
         ":rtc_event_log_impl",
         ":rtc_event_log_parser",
         "../base:rtc_base_approved",
+        "../call:call_interfaces",
 
         # TODO(kwiberg): Remove this dependency.
         "../api/audio_codecs:audio_codecs_api",