| commit | 6f727da62bb0bfcfaf169aef96b96ae2ad84a059 | [log] [tgz] |
|---|---|---|
| author | Markus Handell <handellm@webrtc.org> | Fri Jun 12 15:24:54 2020 +0000 |
| committer | Commit Bot <commit-bot@chromium.org> | Fri Jun 12 16:26:49 2020 +0000 |
| tree | 94b35bcee80cc59cd30e586c6294bbbaa4f05852 | |
| parent | 4d11c02ad3860938998f4256907733f29a13f4cf [diff] [blame] |
Revert "RtpTransceiverInterface: introduce SetOfferedRtpHeaderExtensions." This reverts commit 71db9acc4019b8c9c13b14e6a022cbb3b4255b09. Reason for revert: breaks downstream project. Reason for force push: win bot broken. Original change's description: > RtpTransceiverInterface: introduce SetOfferedRtpHeaderExtensions. > > This change adds exposure of a new transceiver method for > modifying the extensions offered in the next SDP negotiation, > following spec details in https://w3c.github.io/webrtc-extensions/#rtcrtptransceiver-interface. > > Features: > - The interface allows to control the negotiated direction as > per https://tools.ietf.org/html/rfc5285#page-7. > - The interface allows to remove an extension from SDP > negotiation by modifying the direction to > RtpTransceiverDirection::kStopped. > > Note: support for signalling directionality of header extensions > in the SDP isn't implemented yet. > > https://chromestatus.com/feature/5680189201711104. > Intent to prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/65YdUi02yZk > > Bug: chromium:1051821 > Change-Id: Iaabc34446f038c46d93c442e90c2a77f77d542d4 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176408 > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > Commit-Queue: Markus Handell <handellm@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#31487} TBR=hta@webrtc.org,handellm@webrtc.org # Not skipping CQ checks because original CL landed > 1 day ago. No-Try: true Bug: chromium:1051821 Change-Id: I70e1a07225d7eeec7480fa5577d8ff647eba6902 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/177103 Commit-Queue: Markus Handell <handellm@webrtc.org> Reviewed-by: Markus Handell <handellm@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31516}
diff --git a/api/rtp_parameters.h b/api/rtp_parameters.h index 5afb806..f831e51 100644 --- a/api/rtp_parameters.h +++ b/api/rtp_parameters.h
@@ -222,7 +222,7 @@ bool preferred_encrypt = false; // The direction of the extension. The kStopped value is only used with - // RtpTransceiverInterface::HeaderExtensionsToOffer() and + // RtpTransceiverInterface::header_extensions_offered() and // SetOfferedRtpHeaderExtensions(). RtpTransceiverDirection direction = RtpTransceiverDirection::kSendRecv;