Adds Clamping functions for DataRate.
This is quite useful in many places where we need to restrict the range
of a DataRate. It makes it easier to read the intention than with:
value_ = std::max(some_lower_limit, std::min(value_, some_upper_limit));
The naming follows the naming for rtc::SafeClamp.
Bug: webrtc:9709
Change-Id: I08e05197acec325d85babd2a06806a8667f2fcb1
Reviewed-on: https://webrtc-review.googlesource.com/c/104040
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25023}diff --git a/api/units/data_rate_unittest.cc b/api/units/data_rate_unittest.cc
index be02090..8e5b660 100644
--- a/api/units/data_rate_unittest.cc
+++ b/api/units/data_rate_unittest.cc
@@ -92,6 +92,26 @@
EXPECT_TRUE(DataRate::bps(kInfinity).IsInfinite());
EXPECT_TRUE(DataRate::kbps(kInfinity).IsInfinite());
}
+TEST(DataRateTest, Clamping) {
+ const DataRate upper = DataRate::kbps(800);
+ const DataRate lower = DataRate::kbps(100);
+ const DataRate under = DataRate::kbps(100);
+ const DataRate inside = DataRate::kbps(500);
+ const DataRate over = DataRate::kbps(1000);
+ EXPECT_EQ(under.Clamped(lower, upper), lower);
+ EXPECT_EQ(inside.Clamped(lower, upper), inside);
+ EXPECT_EQ(over.Clamped(lower, upper), upper);
+
+ DataRate mutable_rate = lower;
+ mutable_rate.Clamp(lower, upper);
+ EXPECT_EQ(mutable_rate, lower);
+ mutable_rate = inside;
+ mutable_rate.Clamp(lower, upper);
+ EXPECT_EQ(mutable_rate, inside);
+ mutable_rate = over;
+ mutable_rate.Clamp(lower, upper);
+ EXPECT_EQ(mutable_rate, upper);
+}
TEST(DataRateTest, MathOperations) {
const int64_t kValueA = 450;