commit 6932fb2e3405d8be66deac939718f27f32c8817f
author Mirko Bonadei <mbonadei@webrtc.org> Mon Oct 15 14:18:03 2018 +0000
committer Commit Bot <commit-bot@chromium.org> Mon Oct 15 14:48:31 2018 +0000
tree f20021bdf6b6e8f36b9b014fea1dbb7da9e4645b
parent 40a7a35eaa90009d47b20066f62d312b42fbdf48

Revert "Reland: Use unique_ptr and ArrayView in SSLFingerprint"

This reverts commit 47f3240a6621e90a17d92e620ae765c353c87e11.

Reason for revert: Breaks WebRTC roll into Chromium.

Original change's description:
> Reland: Use unique_ptr and ArrayView in SSLFingerprint
> 
> Bug: webrtc:9860
> Change-Id: I550528556aa27050015de29d9d7d99cd9df59ce5
> Reviewed-on: https://webrtc-review.googlesource.com/c/105520
> Reviewed-by: Benjamin Wright <benwright@webrtc.org>
> Reviewed-by: Qingsi Wang <qingsi@webrtc.org>
> Commit-Queue: Steve Anton <steveanton@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#25149}

TBR=steveanton@webrtc.org,qingsi@webrtc.org,benwright@webrtc.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: webrtc:9860
Change-Id: Ib1b5759abf6e79a569ca04b66eabc3021d4c16e4
Reviewed-on: https://webrtc-review.googlesource.com/c/106060
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25173}

rtc_base/sslfingerprint.h

diff --git a/rtc_base/sslfingerprint.h b/rtc_base/sslfingerprint.h
index a2d324c..b204bc7 100644
--- a/rtc_base/sslfingerprint.h
+++ b/rtc_base/sslfingerprint.h
@@ -22,35 +22,20 @@
 class SSLCertificate;
 
 struct SSLFingerprint {
-  // TODO(steveanton): Remove once downstream projects have moved off of this.
   static SSLFingerprint* Create(const std::string& algorithm,
-                                const rtc::SSLIdentity& identity);
-  // TODO(steveanton): Rename to Create once projects have migrated.
-  static std::unique_ptr<SSLFingerprint> CreateUnique(
-      const std::string& algorithm,
-      const rtc::SSLIdentity& identity);
+                                const rtc::SSLIdentity* identity);
 
-  static std::unique_ptr<SSLFingerprint> Create(
-      const std::string& algorithm,
-      const rtc::SSLCertificate& cert);
+  static SSLFingerprint* Create(const std::string& algorithm,
+                                const rtc::SSLCertificate* cert);
 
-  // TODO(steveanton): Remove once downstream projects have moved off of this.
   static SSLFingerprint* CreateFromRfc4572(const std::string& algorithm,
                                            const std::string& fingerprint);
-  // TODO(steveanton): Rename to CreateFromRfc4572 once projects have migrated.
-  static std::unique_ptr<SSLFingerprint> CreateUniqueFromRfc4572(
-      const std::string& algorithm,
-      const std::string& fingerprint);
 
   // Creates a fingerprint from a certificate, using the same digest algorithm
   // as the certificate's signature.
-  static std::unique_ptr<SSLFingerprint> CreateFromCertificate(
-      const RTCCertificate& cert);
+  static SSLFingerprint* CreateFromCertificate(const RTCCertificate* cert);
 
   SSLFingerprint(const std::string& algorithm,
-                 ArrayView<const uint8_t> digest_view);
-  // TODO(steveanton): Remove once downstream projects have moved off of this.
-  SSLFingerprint(const std::string& algorithm,
                  const uint8_t* digest_in,
                  size_t digest_len);