Deprecate EventFactory and delete all usage.
Will be deleted as soon as downstream calls of
VideoCodingModule::Create are updated.
Tbr: sprang@webrtc.org # Trivial change in video/
Bug: webrtc:3380
Change-Id: Iaeb6da2fb68991225fe9086ddddd4a553e1620b4
Reviewed-on: https://webrtc-review.googlesource.com/c/107890
Reviewed-by: Niels Moller <nisse@webrtc.org>
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25554}
diff --git a/modules/video_coding/include/video_coding.h b/modules/video_coding/include/video_coding.h
index 8ef046a..5f21ca3 100644
--- a/modules/video_coding/include/video_coding.h
+++ b/modules/video_coding/include/video_coding.h
@@ -27,6 +27,7 @@
#include "modules/include/module.h"
#include "modules/include/module_common_types.h"
#include "modules/video_coding/include/video_coding_defines.h"
+#include "rtc_base/deprecation.h"
#include "system_wrappers/include/event_wrapper.h"
namespace webrtc {
@@ -37,6 +38,7 @@
class VideoEncoder;
struct CodecSpecificInfo;
+// DEPRECATED
class EventFactory {
public:
virtual ~EventFactory() {}
@@ -44,7 +46,7 @@
virtual EventWrapper* CreateEvent() = 0;
};
-class EventFactoryImpl : public EventFactory {
+class RTC_DEPRECATED EventFactoryImpl : public EventFactory {
public:
~EventFactoryImpl() override {}
@@ -68,8 +70,13 @@
public:
enum SenderNackMode { kNackNone, kNackAll, kNackSelective };
+ RTC_DEPRECATED
+ static VideoCodingModule* Create(Clock* clock,
+ EventFactory* /* event_factory*/) {
+ return Create(clock);
+ }
// DEPRECATED.
- static VideoCodingModule* Create(Clock* clock, EventFactory* event_factory);
+ static VideoCodingModule* Create(Clock* clock);
/*
* Sender