commit 6769c4941817ac3d5b967d0aafa1304c06d0672e
author hbos <hbos@webrtc.org> Mon Jan 02 08:35:13 2017 -0800
committer Commit bot <commit-bot@chromium.org> Mon Jan 02 16:35:13 2017 +0000
tree bd773da91521c33c538676b31eac4bff58fec5f1
parent d17a5a7709fcef98bb6fcd0d2a99e11dfcc38bb7

RTC[In/Out]boundRTPStreamStats: qpSum,framesDecoded,framesEncoded added.

Recently added to the spec:
RTCRTPStreamStats.qpSum - https://w3c.github.io/webrtc-stats/#dom-rtcrtpstreamstats-qpsum
RTCInboundRTPStreamStats.framesDecoded - https://w3c.github.io/webrtc-stats/#dom-rtcinboundrtpstreamstats-framesdecoded
RTCOutboundRTPStreamStats.framesEncoded - https://w3c.github.io/webrtc-stats/#dom-rtcoutboundrtpstreamstats-framesencoded

These are added and collected. However, the qpSum is only collected in
the outbound case. It should be collected in the inbound case before
closing crbug.com/657855

BUG=chromium:657854, chromium:657855, chromium:657856

Review-Url: https://codereview.webrtc.org/2588373005
Cr-Commit-Position: refs/heads/master@{#15872}

webrtc/api/rtcstatscollector_unittest.cc

diff --git a/webrtc/api/rtcstatscollector_unittest.cc b/webrtc/api/rtcstatscollector_unittest.cc
index deda617..adec104 100644
--- a/webrtc/api/rtcstatscollector_unittest.cc
+++ b/webrtc/api/rtcstatscollector_unittest.cc
@@ -1522,6 +1522,7 @@
   video_media_info.receivers[0].firs_sent = 5;
   video_media_info.receivers[0].plis_sent = 6;
   video_media_info.receivers[0].nacks_sent = 7;
+  video_media_info.receivers[0].frames_decoded = 8;
 
   RtpCodecParameters codec_parameters;
   codec_parameters.payload_type = 42;
@@ -1568,6 +1569,7 @@
   expected_video.bytes_received = 3;
   expected_video.packets_lost = 42;
   expected_video.fraction_lost = 4.5;
+  expected_video.frames_decoded = 8;
 
   ASSERT(report->Get(expected_video.id()));
   const RTCInboundRTPStreamStats& video = report->Get(
@@ -1664,6 +1666,8 @@
   video_media_info.senders[0].bytes_sent = 6;
   video_media_info.senders[0].rtt_ms = 7500;
   video_media_info.senders[0].codec_payload_type = rtc::Optional<int>(42);
+  video_media_info.senders[0].frames_encoded = 8;
+  video_media_info.senders[0].qp_sum = rtc::Optional<uint64_t>(16);
 
   RtpCodecParameters codec_parameters;
   codec_parameters.payload_type = 42;
@@ -1709,6 +1713,8 @@
   expected_video.packets_sent = 5;
   expected_video.bytes_sent = 6;
   expected_video.round_trip_time = 7.5;
+  expected_video.frames_encoded = 8;
+  expected_video.qp_sum = 16;
 
   ASSERT(report->Get(expected_video.id()));
   const RTCOutboundRTPStreamStats& video = report->Get(
@@ -1750,6 +1756,7 @@
   video_media_info.senders[0].bytes_sent = 6;
   video_media_info.senders[0].rtt_ms = -1;
   video_media_info.senders[0].codec_payload_type = rtc::Optional<int>(42);
+  video_media_info.senders[0].frames_encoded = 7;
 
   EXPECT_CALL(*voice_media_channel, GetStats(_))
       .WillOnce(DoAll(SetArgPointee<0>(voice_media_info), Return(true)));
@@ -1809,7 +1816,9 @@
   expected_video.nack_count = 4;
   expected_video.packets_sent = 5;
   expected_video.bytes_sent = 6;
+  expected_video.frames_encoded = 7;
   // |expected_video.round_trip_time| should be undefined.
+  // |expected_video.qp_sum| should be undefined.
 
   ASSERT(report->Get(expected_video.id()));
   const RTCOutboundRTPStreamStats& video = report->Get(