commit 654320666d2068edb188c84b25ca5becc0e723fd
author Mirko Bonadei <mbonadei@webrtc.org> Mon Dec 11 09:32:13 2017 +0100
committer Commit Bot <commit-bot@chromium.org> Mon Dec 11 15:51:26 2017 +0000
tree 2fdb0d96d0a8bb51216c772b45d9b8994f0d82c0
parent d4d399081b3471579dca194c3feed74b5ca07495

Including libyuv headers using fully qualified paths.

Using fully qualified paths to include libyuv headers allows WebRTC to
avoid to rely on the //third_party/libyuv:libyuv_config target to
set the -I compiler flag.

Today some WebRTC targets depend on //third_party/libyuv only to
include //third_party/libyuv:libyuv_config but with fully qualified
paths this should not be needed anymore.

A follow-up CL will remove //third_party/libyuv from some targets that
don't need it because they are not including libyuv headers.

Bug: webrtc:8605
Change-Id: Icec707ca761aaf2ea8088e7f7a05ddde0de2619a
No-Try: True
Reviewed-on: https://webrtc-review.googlesource.com/28220
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Magnus Flodman <mflodman@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21209}

modules/video_coding/DEPS

diff --git a/modules/video_coding/DEPS b/modules/video_coding/DEPS
index b4612db..ca61e1d 100644
--- a/modules/video_coding/DEPS
+++ b/modules/video_coding/DEPS
@@ -4,6 +4,7 @@
   "+common_video",
   "+system_wrappers",
   "+rtc_tools",
+  "+third_party/libyuv",
 ]
 
 specific_include_rules = {

modules/video_coding/codecs/i420/i420.cc

diff --git a/modules/video_coding/codecs/i420/i420.cc b/modules/video_coding/codecs/i420/i420.cc
index 8c8c3f0..58ef32e 100644
--- a/modules/video_coding/codecs/i420/i420.cc
+++ b/modules/video_coding/codecs/i420/i420.cc
@@ -15,7 +15,7 @@
 
 #include "api/video/i420_buffer.h"
 #include "common_video/libyuv/include/webrtc_libyuv.h"
-#include "libyuv.h"  // NOLINT
+#include "third_party/libyuv/include/libyuv.h"
 
 namespace {
 const size_t kI420HeaderSize = 4;

modules/video_coding/codecs/vp8/vp8_impl.cc

diff --git a/modules/video_coding/codecs/vp8/vp8_impl.cc b/modules/video_coding/codecs/vp8/vp8_impl.cc
index 9e89696..ffb8051 100644
--- a/modules/video_coding/codecs/vp8/vp8_impl.cc
+++ b/modules/video_coding/codecs/vp8/vp8_impl.cc
@@ -16,10 +16,6 @@
 #include <algorithm>
 #include <string>
 
-// NOTE(ajm): Path provided by gyp.
-#include "libyuv/convert.h"  // NOLINT
-#include "libyuv/scale.h"    // NOLINT
-
 #include "common_types.h"  // NOLINT(build/include)
 #include "common_video/libyuv/include/webrtc_libyuv.h"
 #include "modules/include/module_common_types.h"
@@ -37,6 +33,8 @@
 #include "system_wrappers/include/clock.h"
 #include "system_wrappers/include/field_trial.h"
 #include "system_wrappers/include/metrics.h"
+#include "third_party/libyuv/include/libyuv/convert.h"
+#include "third_party/libyuv/include/libyuv/scale.h"
 
 namespace webrtc {
 namespace {