commit 6364d0899e495eb6d6c1dc70a7bf65f7cd3d1fb2
author Ali Tofigh <alito@webrtc.org> Mon Mar 14 13:32:04 2022 +0100
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Mar 14 12:47:55 2022 +0000
tree 6a5c86796c18d5033999aca97b584056195767b3
parent 9848890590b0d619a421b6c03fa7cd70edc9be18

Adopt absl::string_view in rtc_base/log_sinks

This is part of a large scale effort to increase adoption of
absl::string_view across the WebRTC code base.

This CL adds absl::string_view versions of the OnLogMessage functions in
rtc::LogSink. The const std::string& versions are kept for now since
downstream clients use subclasses of LogSink and need to be migrated
before these are removed.

Bug: webrtc:13579
Change-Id: I57bb72ad503805ff0ca16f1d7aece2d44c65cb73
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/253980
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Xavier Lepaul‎ <xalep@webrtc.org>
Owners-Override: Xavier Lepaul‎ <xalep@webrtc.org>
Commit-Queue: Ali Tofigh <alito@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36189}

rtc_base/logging.h

diff --git a/rtc_base/logging.h b/rtc_base/logging.h
index 8991f6f..ee4d410 100644
--- a/rtc_base/logging.h
+++ b/rtc_base/logging.h
@@ -112,6 +112,13 @@
                             LoggingSeverity severity);
   virtual void OnLogMessage(const std::string& message) = 0;
 
+  virtual void OnLogMessage(absl::string_view msg,
+                            LoggingSeverity severity,
+                            const char* tag);
+  virtual void OnLogMessage(absl::string_view message,
+                            LoggingSeverity severity);
+  virtual void OnLogMessage(absl::string_view message);
+
  private:
   friend class ::rtc::LogMessage;
 #if RTC_LOG_ENABLED()