commit 62238097c97cac9abb628fd710980e7316733090
author Ali Tofigh <alito@webrtc.org> Tue Jan 25 13:27:19 2022 +0100
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Jan 26 11:05:25 2022 +0000
tree 3ee5620a267d4503634cf3a3d0c82fba57432780
parent c98687a2efe1746c8ee717e347a9c95bfeae2cef

Remove top-level const from parameters in function declarations.

This is a safe cleanup change since top-level const applied to
parameters in function declarations (that are not also
definitions) are ignored by the compiler. Hence, such changes do
not change the type of the declared functions and are simply
no-ops.

Bug: webrtc:13610
Change-Id: Ibafb92c45119a6d8bdb6f9109aa8dad6385163a9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249086
Reviewed-by: Niels Moller <nisse@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Ali Tofigh <alito@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35802}

modules/audio_coding/test/EncodeDecodeTest.h

diff --git a/modules/audio_coding/test/EncodeDecodeTest.h b/modules/audio_coding/test/EncodeDecodeTest.h
index c96a4d6..fbc42fb 100644
--- a/modules/audio_coding/test/EncodeDecodeTest.h
+++ b/modules/audio_coding/test/EncodeDecodeTest.h
@@ -28,11 +28,11 @@
  public:
   TestPacketization(RTPStream* rtpStream, uint16_t frequency);
   ~TestPacketization();
-  int32_t SendData(const AudioFrameType frameType,
-                   const uint8_t payloadType,
-                   const uint32_t timeStamp,
+  int32_t SendData(AudioFrameType frameType,
+                   uint8_t payloadType,
+                   uint32_t timeStamp,
                    const uint8_t* payloadData,
-                   const size_t payloadSize,
+                   size_t payloadSize,
                    int64_t absolute_capture_timestamp_ms) override;
 
  private:

modules/audio_coding/test/RTPFile.h

diff --git a/modules/audio_coding/test/RTPFile.h b/modules/audio_coding/test/RTPFile.h
index a3d1520..a9f574b 100644
--- a/modules/audio_coding/test/RTPFile.h
+++ b/modules/audio_coding/test/RTPFile.h
@@ -25,11 +25,11 @@
  public:
   virtual ~RTPStream() {}
 
-  virtual void Write(const uint8_t payloadType,
-                     const uint32_t timeStamp,
-                     const int16_t seqNo,
+  virtual void Write(uint8_t payloadType,
+                     uint32_t timeStamp,
+                     int16_t seqNo,
                      const uint8_t* payloadData,
-                     const size_t payloadSize,
+                     size_t payloadSize,
                      uint32_t frequency) = 0;
 
   // Returns the packet's payload size. Zero should be treated as an
@@ -75,11 +75,11 @@
 
   ~RTPBuffer() = default;
 
-  void Write(const uint8_t payloadType,
-             const uint32_t timeStamp,
-             const int16_t seqNo,
+  void Write(uint8_t payloadType,
+             uint32_t timeStamp,
+             int16_t seqNo,
              const uint8_t* payloadData,
-             const size_t payloadSize,
+             size_t payloadSize,
              uint32_t frequency) override;
 
   size_t Read(RTPHeader* rtp_header,
@@ -108,11 +108,11 @@
 
   void ReadHeader();
 
-  void Write(const uint8_t payloadType,
-             const uint32_t timeStamp,
-             const int16_t seqNo,
+  void Write(uint8_t payloadType,
+             uint32_t timeStamp,
+             int16_t seqNo,
              const uint8_t* payloadData,
-             const size_t payloadSize,
+             size_t payloadSize,
              uint32_t frequency) override;
 
   size_t Read(RTPHeader* rtp_header,

modules/audio_coding/test/TestStereo.h

diff --git a/modules/audio_coding/test/TestStereo.h b/modules/audio_coding/test/TestStereo.h
index 3ee4dbf..4c50a4b 100644
--- a/modules/audio_coding/test/TestStereo.h
+++ b/modules/audio_coding/test/TestStereo.h
@@ -31,11 +31,11 @@
 
   void RegisterReceiverACM(AudioCodingModule* acm);
 
-  int32_t SendData(const AudioFrameType frame_type,
-                   const uint8_t payload_type,
-                   const uint32_t timestamp,
+  int32_t SendData(AudioFrameType frame_type,
+                   uint8_t payload_type,
+                   uint32_t timestamp,
                    const uint8_t* payload_data,
-                   const size_t payload_size,
+                   size_t payload_size,
                    int64_t absolute_capture_timestamp_ms) override;
 
   uint16_t payload_size();

modules/audio_coding/test/TwoWayCommunication.h

diff --git a/modules/audio_coding/test/TwoWayCommunication.h b/modules/audio_coding/test/TwoWayCommunication.h
index 7d0cdb9..b7eb9e5 100644
--- a/modules/audio_coding/test/TwoWayCommunication.h
+++ b/modules/audio_coding/test/TwoWayCommunication.h
@@ -31,9 +31,9 @@
  private:
   void SetUpAutotest(AudioEncoderFactory* const encoder_factory,
                      const SdpAudioFormat& format1,
-                     const int payload_type1,
+                     int payload_type1,
                      const SdpAudioFormat& format2,
-                     const int payload_type2);
+                     int payload_type2);
 
   std::unique_ptr<AudioCodingModule> _acmA;
   std::unique_ptr<AudioCodingModule> _acmB;