Fixed a ton of Python lint errors, enabled python lint checking.
BUG=
Review URL: https://webrtc-codereview.appspot.com/1166004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3627 4adac7df-926f-26a2-2b94-8c16560cd09d
diff --git a/tools/python_charts/webrtc/data_helper_test.py b/tools/python_charts/webrtc/data_helper_test.py
index 6282f7b..53b31bd 100644
--- a/tools/python_charts/webrtc/data_helper_test.py
+++ b/tools/python_charts/webrtc/data_helper_test.py
@@ -7,8 +7,6 @@
# in the file PATENTS. All contributing project authors may
# be found in the AUTHORS file in the root of the source tree.
-__author__ = 'kjellander@webrtc.org (Henrik Kjellander)'
-
import unittest
import webrtc.data_helper
@@ -16,13 +14,13 @@
def setUp(self):
# Simulate frame data from two different test runs, with 2 frames each.
- self.frame_data_0 = [{'frame_number': 0, 'ssim': 0.5, 'psnr': 30.5},
+ self.frame_data_0 = [{'frame_number': 0, 'ssim': 0.5, 'psnr': 30.5},
{'frame_number': 1, 'ssim': 0.55, 'psnr': 30.55}]
self.frame_data_1 = [{'frame_number': 0, 'ssim': 0.6, 'psnr': 30.6},
{'frame_number': 0, 'ssim': 0.66, 'psnr': 30.66}]
self.all_data = [ self.frame_data_0, self.frame_data_1 ]
-
- # Test with frame_number column in a non-first position sice we need to
+
+ # Test with frame_number column in a non-first position sice we need to
# support reordering that to be able to use the gviz_api as we want.
self.type_description = {
'ssim': ('number', 'SSIM'),
@@ -66,13 +64,13 @@
self.assertEquals(1, row['frame_number'])
self.assertEquals(0.55, row['ssim_0'])
self.assertEquals(0.66, row['ssim_1'])
-
- description, data_table = helper.CreateData('psnr')
+
+ description, data_table = helper.CreateData('psnr')
self.assertEqual(3, len(description))
self.assertTrue('frame_number' in description)
self.assertTrue('psnr_0' in description)
- self.assertTrue('psnr_1' in description)
- self.assertEqual(0, len(messages))
+ self.assertTrue('psnr_1' in description)
+ self.assertEqual(0, len(messages))
self.assertEquals(2, len(data_table))
row = data_table[0]
@@ -83,21 +81,21 @@
self.assertEquals(1, row['frame_number'])
self.assertEquals(30.55, row['psnr_0'])
self.assertEquals(30.66, row['psnr_1'])
-
+
def testGetOrdering(self):
- """ Tests that the ordering help method returns a list with frame_number
+ """ Tests that the ordering help method returns a list with frame_number
first and the rest sorted alphabetically """
messages = []
helper = webrtc.data_helper.DataHelper(self.all_data, self.type_description,
self.names, messages)
- description, data_table = helper.CreateData('ssim')
+ description, _ = helper.CreateData('ssim')
columns = helper.GetOrdering(description)
self.assertEqual(3, len(columns))
self.assertEqual(0, len(messages))
self.assertEqual('frame_number', columns[0])
self.assertEqual('ssim_0', columns[1])
self.assertEqual('ssim_1', columns[2])
-
+
def testCreateConfigurationTable(self):
messages = []
helper = webrtc.data_helper.DataHelper(self.all_data, self.type_description,
@@ -110,6 +108,6 @@
self.assertTrue(description.has_key('input_filename'))
self.assertEquals('Test 0', data[0]['name'])
self.assertEquals('Test 1', data[1]['name'])
-
+
if __name__ == "__main__":
unittest.main()