commit 5c4d2ee615eea6651d2d35fc1ec4ea03bc63ef02
author Harald Alvestrand <hta@webrtc.org> Mon Apr 01 12:58:15 2019 +0200
committer Commit Bot <commit-bot@chromium.org> Mon Apr 01 14:06:29 2019 +0000
tree a29e2e427672e6253af9c6221fe62a5efbd1fe05
parent 4124dab7f3bbdd0529595c94b73247dbace51d84

RTCDataChannel: Ignore "id" when "negotiated" is false

This updates behavior to be aligned with the WebRTC spec.

Bug: chromium:948055
Change-Id: Id3bbf05b3df084c9b7f7d12598c09187679d60fc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/130493
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27394}

pc/peer_connection_interface_unittest.cc

diff --git a/pc/peer_connection_interface_unittest.cc b/pc/peer_connection_interface_unittest.cc
index 90c5208..371cdc1 100644
--- a/pc/peer_connection_interface_unittest.cc
+++ b/pc/peer_connection_interface_unittest.cc
@@ -2141,6 +2141,7 @@
   rtc::scoped_refptr<DataChannelInterface> channel;
 
   config.id = 1;
+  config.negotiated = true;
   channel = pc_->CreateDataChannel("1", &config);
   EXPECT_TRUE(channel != NULL);
   EXPECT_EQ(1, channel->id());
@@ -2149,11 +2150,13 @@
   EXPECT_TRUE(channel == NULL);
 
   config.id = cricket::kMaxSctpSid;
+  config.negotiated = true;
   channel = pc_->CreateDataChannel("max", &config);
   EXPECT_TRUE(channel != NULL);
   EXPECT_EQ(config.id, channel->id());
 
   config.id = cricket::kMaxSctpSid + 1;
+  config.negotiated = true;
   channel = pc_->CreateDataChannel("x", &config);
   EXPECT_TRUE(channel == NULL);
 }