commit 57f2a5485a4c83c8045d0dbe9db6281d6bcda847
author Florent Castelli <orphis@webrtc.org> Mon Apr 08 13:34:38 2019 +0000
committer Commit Bot <commit-bot@chromium.org> Mon Apr 08 14:44:48 2019 +0000
tree e9941c32ca0f1eb3e8eddc60433e6bd856461430
parent 14d1c9d968f0c8a4364eb2f7bc395083706ce8af

Revert "Remove TaskQueue constructor that uses GlobalTaskQueueFactory"

This reverts commit 7b7485b796ad77809e3343f3256013488b418235.

Reason for revert: Breaks Chrome autoroll 

video/video_stream_decoder_impl.cc:28:7: error: no matching constructor for initialization of 'rtc::TaskQueue'
      bookkeeping_queue_("video_stream_decoder_bookkeeping_queue"),

Original change's description:
> Remove TaskQueue constructor that uses GlobalTaskQueueFactory
> 
> Bug: webrtc:10284
> Change-Id: I9547fb7110222ce3a3c2323ae2a004024eab911e
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/130471
> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#27464}

TBR=danilchap@webrtc.org,kwiberg@webrtc.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: webrtc:10284
Change-Id: I7684f7c7d5501cc910ac9f9daa8ccf6bdb10f8e1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/131338
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27491}

rtc_base/BUILD.gn

diff --git a/rtc_base/BUILD.gn b/rtc_base/BUILD.gn
index 12b8c05..2bae52c 100644
--- a/rtc_base/BUILD.gn
+++ b/rtc_base/BUILD.gn
@@ -479,6 +479,7 @@
   deps = [
     ":macromagic",
     "../api/task_queue",
+    "../api/task_queue:global_task_queue_factory",
     "system:rtc_export",
     "task_utils:to_queued_task",
     "//third_party/abseil-cpp/absl/memory",

rtc_base/task_queue.cc

diff --git a/rtc_base/task_queue.cc b/rtc_base/task_queue.cc
index 965a4d8..46ab495 100644
--- a/rtc_base/task_queue.cc
+++ b/rtc_base/task_queue.cc
@@ -9,6 +9,7 @@
  */
 #include "rtc_base/task_queue.h"
 
+#include "api/task_queue/global_task_queue_factory.h"
 #include "api/task_queue/task_queue_base.h"
 
 namespace rtc {
@@ -17,6 +18,10 @@
     std::unique_ptr<webrtc::TaskQueueBase, webrtc::TaskQueueDeleter> task_queue)
     : impl_(task_queue.release()) {}
 
+TaskQueue::TaskQueue(const char* queue_name, Priority priority)
+    : TaskQueue(webrtc::GlobalTaskQueueFactory().CreateTaskQueue(queue_name,
+                                                                 priority)) {}
+
 TaskQueue::~TaskQueue() {
   // There might running task that tries to rescheduler itself to the TaskQueue
   // and not yet aware TaskQueue destructor is called.

rtc_base/task_queue.h

diff --git a/rtc_base/task_queue.h b/rtc_base/task_queue.h
index 01fcb78..8d2a89e 100644
--- a/rtc_base/task_queue.h
+++ b/rtc_base/task_queue.h
@@ -80,6 +80,8 @@
 
   explicit TaskQueue(std::unique_ptr<webrtc::TaskQueueBase,
                                      webrtc::TaskQueueDeleter> task_queue);
+  explicit TaskQueue(const char* queue_name,
+                     Priority priority = Priority::NORMAL);
   ~TaskQueue();
 
   // Used for DCHECKing the current queue.