Remove //rtc_base:stringutils from public deps
Bug: webrtc:8603
Change-Id: Ic2dfbe28d310cb4b35983b73e895fc95e8439669
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/257913
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Auto-Submit: Florent Castelli <orphis@webrtc.org>
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36453}
diff --git a/modules/audio_coding/BUILD.gn b/modules/audio_coding/BUILD.gn
index 4b3474c..a6aacea 100644
--- a/modules/audio_coding/BUILD.gn
+++ b/modules/audio_coding/BUILD.gn
@@ -766,6 +766,7 @@
"../../rtc_base:rtc_numerics",
"../../rtc_base:safe_conversions",
"../../rtc_base:safe_minmax",
+ "../../rtc_base:stringutils",
"../../system_wrappers:field_trial",
]
absl_deps = [
@@ -1090,6 +1091,7 @@
"../../rtc_base:checks",
"../../rtc_base:rtc_base_approved",
"../../rtc_base:safe_conversions",
+ "../../rtc_base:stringutils",
"../../system_wrappers",
"../rtp_rtcp:rtp_rtcp_format",
]
@@ -1126,6 +1128,7 @@
"../../rtc_base",
"../../rtc_base:checks",
"../../rtc_base:rtc_base_approved",
+ "../../rtc_base:stringutils",
"../../rtc_base/system:arch",
"../../test:rtp_test_utils",
"../rtp_rtcp:rtp_rtcp_format",
@@ -1168,6 +1171,7 @@
"../../rtc_base:checks",
"../../rtc_base:rtc_base_approved",
"../../rtc_base:safe_conversions",
+ "../../rtc_base:stringutils",
"../rtp_rtcp",
"../rtp_rtcp:rtp_rtcp_format",
]
@@ -1414,6 +1418,7 @@
"../../rtc_base:logging",
"../../rtc_base:macromagic",
"../../rtc_base:rtc_base_approved",
+ "../../rtc_base:stringutils",
"../../rtc_base/synchronization:mutex",
"../../test:fileutils",
"../../test:scoped_key_value_config",
@@ -1479,19 +1484,20 @@
defines = audio_coding_defines
- deps = audio_coding_deps + [
- "../../api/audio:audio_frame_api",
- "../../rtc_base:checks",
- ":audio_coding",
- ":neteq_tools",
- "../../api/audio_codecs:builtin_audio_decoder_factory",
- "../../api/audio_codecs:builtin_audio_encoder_factory",
- "../../api/audio_codecs:audio_codecs_api",
- "../../rtc_base:rtc_base_approved",
- "../../test:test_support",
- "//testing/gtest",
- ]
-
+ deps = [
+ ":audio_coding",
+ ":neteq_tools",
+ "../../api/audio:audio_frame_api",
+ "../../api/audio_codecs:audio_codecs_api",
+ "../../api/audio_codecs:builtin_audio_decoder_factory",
+ "../../api/audio_codecs:builtin_audio_encoder_factory",
+ "../../rtc_base:checks",
+ "../../rtc_base:rtc_base_approved",
+ "../../rtc_base:stringutils",
+ "../../test:test_support",
+ "//testing/gtest",
+ ]
+ deps += audio_coding_deps
absl_deps = [ "//third_party/abseil-cpp/absl/strings" ]
}
@@ -2105,6 +2111,7 @@
"../../rtc_base:rtc_event",
"../../rtc_base:safe_conversions",
"../../rtc_base:sanitizer",
+ "../../rtc_base:stringutils",
"../../rtc_base:timeutils",
"../../rtc_base/synchronization:mutex",
"../../rtc_base/system:arch",
diff --git a/modules/audio_device/BUILD.gn b/modules/audio_device/BUILD.gn
index aa2a1d2..6171a55 100644
--- a/modules/audio_device/BUILD.gn
+++ b/modules/audio_device/BUILD.gn
@@ -118,6 +118,7 @@
"../../rtc_base:logging",
"../../rtc_base:macromagic",
"../../rtc_base:rtc_base_approved",
+ "../../rtc_base:stringutils",
]
libs = [ "oleaut32.lib" ]
@@ -158,6 +159,7 @@
"../../rtc_base:refcount",
"../../rtc_base:rtc_base_approved",
"../../rtc_base:safe_conversions",
+ "../../rtc_base:stringutils",
]
absl_deps = [ "//third_party/abseil-cpp/absl/types:optional" ]
}
@@ -188,6 +190,7 @@
"../../rtc_base:rtc_event",
"../../rtc_base:rtc_task_queue",
"../../rtc_base:safe_conversions",
+ "../../rtc_base:stringutils",
"../../rtc_base/synchronization:mutex",
"../../rtc_base/system:arch",
"../../rtc_base/system:file_wrapper",
diff --git a/modules/audio_mixer/BUILD.gn b/modules/audio_mixer/BUILD.gn
index e4b3830..5b4aefe 100644
--- a/modules/audio_mixer/BUILD.gn
+++ b/modules/audio_mixer/BUILD.gn
@@ -122,6 +122,7 @@
"../../audio/utility:audio_frame_operations",
"../../rtc_base:checks",
"../../rtc_base:rtc_base_approved",
+ "../../rtc_base:stringutils",
"../../rtc_base:task_queue_for_test",
"../../test:test_support",
]
diff --git a/modules/audio_processing/BUILD.gn b/modules/audio_processing/BUILD.gn
index b44624e..39b29aa 100644
--- a/modules/audio_processing/BUILD.gn
+++ b/modules/audio_processing/BUILD.gn
@@ -36,6 +36,7 @@
"../../rtc_base:macromagic",
"../../rtc_base:refcount",
"../../rtc_base:rtc_base_approved",
+ "../../rtc_base:stringutils",
"../../rtc_base/system:arch",
"../../rtc_base/system:file_wrapper",
"../../rtc_base/system:rtc_export",
@@ -306,6 +307,7 @@
"../../common_audio",
"../../rtc_base:checks",
"../../rtc_base:rtc_base_approved",
+ "../../rtc_base:stringutils",
]
absl_deps = [ "//third_party/abseil-cpp/absl/types:optional" ]
defines = []
@@ -387,6 +389,7 @@
"../../rtc_base:rtc_event",
"../../rtc_base:safe_conversions",
"../../rtc_base:safe_minmax",
+ "../../rtc_base:stringutils",
"../../rtc_base:task_queue_for_test",
"../../rtc_base:threading",
"../../rtc_base/synchronization:mutex",
@@ -547,6 +550,7 @@
"../../rtc_base:rtc_base_approved",
"../../rtc_base:rtc_json",
"../../rtc_base:safe_conversions",
+ "../../rtc_base:stringutils",
"../../rtc_base:task_queue_for_test",
"../../rtc_base/system:file_wrapper",
"../../system_wrappers",
diff --git a/modules/audio_processing/aec3/BUILD.gn b/modules/audio_processing/aec3/BUILD.gn
index a209738..128e8f3 100644
--- a/modules/audio_processing/aec3/BUILD.gn
+++ b/modules/audio_processing/aec3/BUILD.gn
@@ -312,6 +312,7 @@
"../../../rtc_base:macromagic",
"../../../rtc_base:rtc_base_approved",
"../../../rtc_base:safe_minmax",
+ "../../../rtc_base:stringutils",
"../../../rtc_base/system:arch",
"../../../system_wrappers",
"../../../test:field_trial",
diff --git a/modules/audio_processing/ns/BUILD.gn b/modules/audio_processing/ns/BUILD.gn
index eb99c77..9baadcb 100644
--- a/modules/audio_processing/ns/BUILD.gn
+++ b/modules/audio_processing/ns/BUILD.gn
@@ -85,6 +85,7 @@
"../../../rtc_base:checks",
"../../../rtc_base:rtc_base_approved",
"../../../rtc_base:safe_minmax",
+ "../../../rtc_base:stringutils",
"../../../rtc_base/system:arch",
"../../../system_wrappers",
"../../../test:test_support",
diff --git a/modules/audio_processing/test/conversational_speech/BUILD.gn b/modules/audio_processing/test/conversational_speech/BUILD.gn
index 8785ce8..5763ff8 100644
--- a/modules/audio_processing/test/conversational_speech/BUILD.gn
+++ b/modules/audio_processing/test/conversational_speech/BUILD.gn
@@ -50,6 +50,7 @@
"../../../../rtc_base:logging",
"../../../../rtc_base:rtc_base_approved",
"../../../../rtc_base:safe_conversions",
+ "../../../../rtc_base:stringutils",
"../../../../test:fileutils",
]
visibility = [ ":*" ] # Only targets in this file can depend on this.
diff --git a/modules/desktop_capture/BUILD.gn b/modules/desktop_capture/BUILD.gn
index 91e0c20..9c82ce2 100644
--- a/modules/desktop_capture/BUILD.gn
+++ b/modules/desktop_capture/BUILD.gn
@@ -484,6 +484,7 @@
"../../rtc_base:logging",
"../../rtc_base:macromagic",
"../../rtc_base:refcount",
+ "../../rtc_base:stringutils",
"../../rtc_base/synchronization:mutex",
"../../rtc_base/system:arch",
"../../rtc_base/system:no_unique_address",
diff --git a/modules/remote_bitrate_estimator/BUILD.gn b/modules/remote_bitrate_estimator/BUILD.gn
index 8a6bc93..06d04be 100644
--- a/modules/remote_bitrate_estimator/BUILD.gn
+++ b/modules/remote_bitrate_estimator/BUILD.gn
@@ -60,6 +60,7 @@
"../../rtc_base:rtc_base_approved",
"../../rtc_base:rtc_numerics",
"../../rtc_base:safe_minmax",
+ "../../rtc_base:stringutils",
"../../rtc_base/experiments:field_trial_parser",
"../../rtc_base/synchronization:mutex",
"../../system_wrappers",
diff --git a/modules/rtp_rtcp/BUILD.gn b/modules/rtp_rtcp/BUILD.gn
index 7758738..1704ea0 100644
--- a/modules/rtp_rtcp/BUILD.gn
+++ b/modules/rtp_rtcp/BUILD.gn
@@ -125,6 +125,7 @@
"../../rtc_base:macromagic",
"../../rtc_base:rtc_base_approved",
"../../rtc_base:safe_conversions",
+ "../../rtc_base:stringutils",
"../../system_wrappers",
"../video_coding:codec_globals_headers",
]
@@ -624,6 +625,7 @@
"../../rtc_base:rtc_base_tests_utils",
"../../rtc_base:rtc_event",
"../../rtc_base:rtc_numerics",
+ "../../rtc_base:stringutils",
"../../rtc_base:task_queue_for_test",
"../../rtc_base/task_utils:to_queued_task",
"../../system_wrappers",
diff --git a/modules/video_capture/BUILD.gn b/modules/video_capture/BUILD.gn
index e8b0d9b..b15b733 100644
--- a/modules/video_capture/BUILD.gn
+++ b/modules/video_capture/BUILD.gn
@@ -55,6 +55,7 @@
"../../rtc_base:macromagic",
"../../rtc_base:refcount",
"../../rtc_base:rtc_base_approved",
+ "../../rtc_base:stringutils",
"../../rtc_base/synchronization:mutex",
"../../system_wrappers",
]
diff --git a/modules/video_coding/BUILD.gn b/modules/video_coding/BUILD.gn
index 734ebdc..5168492 100644
--- a/modules/video_coding/BUILD.gn
+++ b/modules/video_coding/BUILD.gn
@@ -528,6 +528,7 @@
"../../rtc_base:rtc_base_approved",
"../../rtc_base:rtc_numerics",
"../../rtc_base:rtc_task_queue",
+ "../../rtc_base:stringutils",
"../../rtc_base:weak_ptr",
"../../rtc_base/experiments:bandwidth_quality_scaler_settings",
"../../rtc_base/experiments:encoder_info_settings",
@@ -784,6 +785,7 @@
"../../rtc_base",
"../../rtc_base:checks",
"../../rtc_base:logging",
+ "../../rtc_base:stringutils",
"../../rtc_base/experiments:encoder_info_settings",
"../../rtc_base/experiments:field_trial_parser",
"../../rtc_base/experiments:rate_control_settings",
@@ -1003,6 +1005,7 @@
"../../rtc_base:logging",
"../../rtc_base:rtc_base_approved",
"../../rtc_base:rtc_base_tests_utils",
+ "../../rtc_base:stringutils",
"../../rtc_base:task_queue_for_test",
"../../system_wrappers",
"../../test:fileutils",
@@ -1089,6 +1092,7 @@
"../../media:rtc_simulcast_encoder_adapter",
"../../rtc_base",
"../../rtc_base:refcount",
+ "../../rtc_base:stringutils",
"../../test:explicit_key_value_config",
"../../test:field_trial",
"../../test:fileutils",
@@ -1250,6 +1254,7 @@
"../../rtc_base:rtc_event",
"../../rtc_base:rtc_numerics",
"../../rtc_base:rtc_task_queue",
+ "../../rtc_base:stringutils",
"../../rtc_base:task_queue_for_test",
"../../rtc_base/experiments:encoder_info_settings",
"../../rtc_base/experiments:jitter_upper_bound_experiment",