tools_webrtc dir converted to py3 + top level PRESUBMIT script
Bug: webrtc:13607
Change-Id: Ib018e43ea977cc24dd71048e68e3343741f7f31b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249083
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Christoffer Jansson <jansson@google.com>
Cr-Commit-Position: refs/heads/main@{#35953}
diff --git a/tools_webrtc/libs/generate_licenses_test.py b/tools_webrtc/libs/generate_licenses_test.py
index ebef78e..6dfd8f3 100755
--- a/tools_webrtc/libs/generate_licenses_test.py
+++ b/tools_webrtc/libs/generate_licenses_test.py
@@ -1,5 +1,6 @@
-#!/usr/bin/env vpython
-# pylint: disable=relative-import,protected-access,unused-argument
+#!/usr/bin/env vpython3
+
+# pylint: disable=protected-access,unused-argument
# Copyright 2017 The WebRTC project authors. All Rights Reserved.
#
@@ -10,20 +11,15 @@
# be found in the AUTHORS file in the root of the source tree.
import unittest
-try:
- # python 3.3+
- from unittest.mock import patch
-except ImportError:
- # From site-package
- from mock import patch
+from mock import patch
from generate_licenses import LicenseBuilder
class TestLicenseBuilder(unittest.TestCase):
- @staticmethod
- def _FakeRunGN(buildfile_dir, target):
- return """
+ @staticmethod
+ def _FakeRunGN(buildfile_dir, target):
+ return """
{
"target1": {
"deps": [
@@ -36,93 +32,89 @@
}
"""
- def testParseLibraryName(self):
- self.assertEqual(
- LicenseBuilder._ParseLibraryName('//a/b/third_party/libname1:c'),
- 'libname1')
- self.assertEqual(
- LicenseBuilder._ParseLibraryName(
- '//a/b/third_party/libname2:c(d)'), 'libname2')
- self.assertEqual(
- LicenseBuilder._ParseLibraryName(
- '//a/b/third_party/libname3/c:d(e)'), 'libname3')
- self.assertEqual(
- LicenseBuilder._ParseLibraryName('//a/b/not_third_party/c'), None)
+ def testParseLibraryName(self):
+ self.assertEqual(
+ LicenseBuilder._ParseLibraryName('//a/b/third_party/libname1:c'),
+ 'libname1')
+ self.assertEqual(
+ LicenseBuilder._ParseLibraryName('//a/b/third_party/libname2:c(d)'),
+ 'libname2')
+ self.assertEqual(
+ LicenseBuilder._ParseLibraryName('//a/b/third_party/libname3/c:d(e)'),
+ 'libname3')
+ self.assertEqual(
+ LicenseBuilder._ParseLibraryName('//a/b/not_third_party/c'), None)
- def testParseLibrarySimpleMatch(self):
- builder = LicenseBuilder([], [], {}, {})
- self.assertEqual(builder._ParseLibrary('//a/b/third_party/libname:c'),
- 'libname')
+ def testParseLibrarySimpleMatch(self):
+ builder = LicenseBuilder([], [], {}, {})
+ self.assertEqual(builder._ParseLibrary('//a/b/third_party/libname:c'),
+ 'libname')
- def testParseLibraryRegExNoMatchFallbacksToDefaultLibname(self):
- lib_dict = {
- 'libname:foo.*': ['path/to/LICENSE'],
- }
- builder = LicenseBuilder([], [], lib_dict, {})
- self.assertEqual(
- builder._ParseLibrary('//a/b/third_party/libname:bar_java'),
- 'libname')
+ def testParseLibraryRegExNoMatchFallbacksToDefaultLibname(self):
+ lib_dict = {
+ 'libname:foo.*': ['path/to/LICENSE'],
+ }
+ builder = LicenseBuilder([], [], lib_dict, {})
+ self.assertEqual(
+ builder._ParseLibrary('//a/b/third_party/libname:bar_java'), 'libname')
- def testParseLibraryRegExMatch(self):
- lib_regex_dict = {
- 'libname:foo.*': ['path/to/LICENSE'],
- }
- builder = LicenseBuilder([], [], {}, lib_regex_dict)
- self.assertEqual(
- builder._ParseLibrary('//a/b/third_party/libname:foo_bar_java'),
- 'libname:foo.*')
+ def testParseLibraryRegExMatch(self):
+ lib_regex_dict = {
+ 'libname:foo.*': ['path/to/LICENSE'],
+ }
+ builder = LicenseBuilder([], [], {}, lib_regex_dict)
+ self.assertEqual(
+ builder._ParseLibrary('//a/b/third_party/libname:foo_bar_java'),
+ 'libname:foo.*')
- def testParseLibraryRegExMatchWithSubDirectory(self):
- lib_regex_dict = {
- 'libname/foo:bar.*': ['path/to/LICENSE'],
- }
- builder = LicenseBuilder([], [], {}, lib_regex_dict)
- self.assertEqual(
- builder._ParseLibrary('//a/b/third_party/libname/foo:bar_java'),
- 'libname/foo:bar.*')
+ def testParseLibraryRegExMatchWithSubDirectory(self):
+ lib_regex_dict = {
+ 'libname/foo:bar.*': ['path/to/LICENSE'],
+ }
+ builder = LicenseBuilder([], [], {}, lib_regex_dict)
+ self.assertEqual(
+ builder._ParseLibrary('//a/b/third_party/libname/foo:bar_java'),
+ 'libname/foo:bar.*')
- def testParseLibraryRegExMatchWithStarInside(self):
- lib_regex_dict = {
- 'libname/foo.*bar.*': ['path/to/LICENSE'],
- }
- builder = LicenseBuilder([], [], {}, lib_regex_dict)
- self.assertEqual(
- builder._ParseLibrary(
- '//a/b/third_party/libname/fooHAHA:bar_java'),
- 'libname/foo.*bar.*')
+ def testParseLibraryRegExMatchWithStarInside(self):
+ lib_regex_dict = {
+ 'libname/foo.*bar.*': ['path/to/LICENSE'],
+ }
+ builder = LicenseBuilder([], [], {}, lib_regex_dict)
+ self.assertEqual(
+ builder._ParseLibrary('//a/b/third_party/libname/fooHAHA:bar_java'),
+ 'libname/foo.*bar.*')
- @patch('generate_licenses.LicenseBuilder._RunGN', _FakeRunGN)
- def testGetThirdPartyLibrariesWithoutRegex(self):
- builder = LicenseBuilder([], [], {}, {})
- self.assertEqual(
- builder._GetThirdPartyLibraries('out/arm', 'target1'),
- set(['libname1', 'libname2', 'libname3']))
+ @patch('generate_licenses.LicenseBuilder._RunGN', _FakeRunGN)
+ def testGetThirdPartyLibrariesWithoutRegex(self):
+ builder = LicenseBuilder([], [], {}, {})
+ self.assertEqual(builder._GetThirdPartyLibraries('out/arm', 'target1'),
+ set(['libname1', 'libname2', 'libname3']))
- @patch('generate_licenses.LicenseBuilder._RunGN', _FakeRunGN)
- def testGetThirdPartyLibrariesWithRegex(self):
- lib_regex_dict = {
- 'libname2:c.*': ['path/to/LICENSE'],
- }
- builder = LicenseBuilder([], [], {}, lib_regex_dict)
- self.assertEqual(
- builder._GetThirdPartyLibraries('out/arm', 'target1'),
- set(['libname1', 'libname2:c.*', 'libname3']))
+ @patch('generate_licenses.LicenseBuilder._RunGN', _FakeRunGN)
+ def testGetThirdPartyLibrariesWithRegex(self):
+ lib_regex_dict = {
+ 'libname2:c.*': ['path/to/LICENSE'],
+ }
+ builder = LicenseBuilder([], [], {}, lib_regex_dict)
+ self.assertEqual(builder._GetThirdPartyLibraries('out/arm', 'target1'),
+ set(['libname1', 'libname2:c.*', 'libname3']))
- @patch('generate_licenses.LicenseBuilder._RunGN', _FakeRunGN)
- def testGenerateLicenseTextFailIfUnknownLibrary(self):
- lib_dict = {
- 'simple_library': ['path/to/LICENSE'],
- }
- builder = LicenseBuilder(['dummy_dir'], ['dummy_target'], lib_dict, {})
+ @patch('generate_licenses.LicenseBuilder._RunGN', _FakeRunGN)
+ def testGenerateLicenseTextFailIfUnknownLibrary(self):
+ lib_dict = {
+ 'simple_library': ['path/to/LICENSE'],
+ }
+ builder = LicenseBuilder(['dummy_dir'], ['dummy_target'], lib_dict, {})
- with self.assertRaises(Exception) as context:
- builder.GenerateLicenseText('dummy/dir')
+ with self.assertRaises(Exception) as context:
+ builder.GenerateLicenseText('dummy/dir')
- self.assertEqual(
- context.exception.args[0],
- 'Missing licenses for following third_party targets: '
- 'libname1, libname2, libname3')
+ self.assertEqual(
+ context.exception.args[0],
+ 'Missing licenses for following third_party targets: '
+ 'libname1, libname2, libname3')
if __name__ == '__main__':
- unittest.main()
+ unittest.main()