commit 4aeb35b6d04bfb462490bce2847d0eb20926e3be
author Jiawei Ou <ouj@fb.com> Fri Nov 09 13:55:45 2018 -0800
committer Commit Bot <commit-bot@chromium.org> Mon Nov 12 19:45:17 2018 +0000
tree 8484819192f894744ffb614d292d67eddea6ebf9
parent 0c32e33b489ae57211dea1bb54f932d6f0f4356f

Explicitly retain self in objc blocks to avoid compiler warning.

Implicitly retaining self pointer (assuming this is intended behavior) causes compiler warning `-Wimplicit-retain-self`. We should do it explicitly.

Bug: webrtc:9971
Change-Id: If77a67168d8a65ced78d5119b9a7332391d20bc9
Reviewed-on: https://webrtc-review.googlesource.com/c/109641
Commit-Queue: Jiawei Ou <ouj@fb.com>
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Reviewed-by: Tommi <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25609}

sdk/BUILD.gn

diff --git a/sdk/BUILD.gn b/sdk/BUILD.gn
index 31a7901..cc8f0a2 100644
--- a/sdk/BUILD.gn
+++ b/sdk/BUILD.gn
@@ -40,6 +40,7 @@
       "objc/Framework/Headers",  # TODO(bugs.webrtc.org/9627): Remove this.
     ]
     cflags = [
+      "-Wimplicit-retain-self",
       "-Wstrict-overflow",
       "-Wmissing-field-initializers",
     ]