commit 49a1d621be799d3da7ac02ed422a0c1f8f802542
author Henrik Boström <hbos@webrtc.org> Mon Jan 24 09:19:42 2022 +0100
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Jan 24 10:19:59 2022 +0000
tree da5ac09ecaab63b2dd5a28bc3452aaecf67c2ae5
parent 347488e450a4ae5d5b9284b6f567f2d80eda6ed9

Fix possible compile issue with PeerConnectionInterface::AsString.

AsString is constexpr, but RTC_CHECK_NOTREACHED is not. Using some gcc
compile rules, having a constexpr make use of RTC_CHECK_NOTREACHED does
not compile.

See internal issue number 215785261. We could either remove constexpr
or remove the RTC_CHECK_NOTREACHED. This CL does the latter.

Bug: None
Change-Id: I7ea84b345e9abdba60a7620e1d92c3159c0d7974
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/248167
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35768}

api/peer_connection_interface.h

diff --git a/api/peer_connection_interface.h b/api/peer_connection_interface.h
index 72a0765..0b402c9 100644
--- a/api/peer_connection_interface.h
+++ b/api/peer_connection_interface.h
@@ -1625,7 +1625,8 @@
     case SignalingState::kClosed:
       return "closed";
   }
-  RTC_CHECK_NOTREACHED();
+  // This cannot happen.
+  // Not using "RTC_CHECK_NOTREACHED()" because AsString() is constexpr.
   return "";
 }
 
@@ -1640,7 +1641,8 @@
     case IceGatheringState::kIceGatheringComplete:
       return "complete";
   }
-  RTC_CHECK_NOTREACHED();
+  // This cannot happen.
+  // Not using "RTC_CHECK_NOTREACHED()" because AsString() is constexpr.
   return "";
 }
 
@@ -1661,7 +1663,8 @@
     case PeerConnectionState::kClosed:
       return "closed";
   }
-  RTC_CHECK_NOTREACHED();
+  // This cannot happen.
+  // Not using "RTC_CHECK_NOTREACHED()" because AsString() is constexpr.
   return "";
 }
 
@@ -1683,10 +1686,12 @@
     case kIceConnectionClosed:
       return "closed";
     case kIceConnectionMax:
-      RTC_CHECK_NOTREACHED();
+      // This cannot happen.
+      // Not using "RTC_CHECK_NOTREACHED()" because AsString() is constexpr.
       return "";
   }
-  RTC_CHECK_NOTREACHED();
+  // This cannot happen.
+  // Not using "RTC_CHECK_NOTREACHED()" because AsString() is constexpr.
   return "";
 }