commit | 481e3451d161bd25ce9d31605974a6273aab9e7a | [log] [tgz] |
---|---|---|
author | Mirko Bonadei <mbonadei@webrtc.org> | Fri Jul 30 13:57:25 2021 +0200 |
committer | WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Jul 30 13:47:50 2021 +0000 |
tree | f899c9a5d160d6ae143cbae556d6668f5376d820 | |
parent | 2e6323e153881566125cdb1d21a280e94f113d5c [diff] [blame] |
Revert rtc_dcheck_always_on. This CL reverts: https://webrtc-review.googlesource.com/c/src/+/226864 https://webrtc-review.googlesource.com/c/src/+/226563 Reason for revert: See also V8 equivalent: crrev.com/c/3055294. This has been properly fixed by crrev.com/c/3053740. Now dcheck_always_on already defaults to false for subprojects like WebRTC and no other switch is required. The switch didn't fully work anyways due to https://crbug.com/1231890. No-Try: True Bug: chromium:1225701, webrtc:12988 Change-Id: I9888d7ac02ef2ba4fdc372de20f1d2d71f6d0299 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227021 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Andrey Logvin <landrey@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34603}
diff --git a/tools_webrtc/coverage/generate_ios_coverage_command.py b/tools_webrtc/coverage/generate_ios_coverage_command.py index ff17c58..4feaacd 100644 --- a/tools_webrtc/coverage/generate_ios_coverage_command.py +++ b/tools_webrtc/coverage/generate_ios_coverage_command.py
@@ -89,7 +89,7 @@ target_cpu = 'x64' if is_simulator else 'arm64' return ([] + ['target_os="ios"'] + ['target_cpu="%s"' % target_cpu] + ['use_clang_coverage=true'] + ['is_component_build=false'] + - ['rtc_dcheck_always_on=true']) + ['dcheck_always_on=true']) def GenerateIOSSimulatorCommand():