commit 41a32874727160d3309ba5b1783a4c87a7fd9d64
author tkchin <tkchin@webrtc.org> Wed Aug 17 16:02:58 2016 -0700
committer Commit bot <commit-bot@chromium.org> Wed Aug 17 23:03:09 2016 +0000
tree 0d7a90c78ec05acb53d5d1f920002306d9206f03
parent 869dab775cf08eb43ac152cb15ecfc5e8a7ba3ab

Nil out EAGLContext explicitly on RTCEAGLVideoView dealloc.

Theoretical fix to address some EAGLContext issues from other UIImageViews that could be active.

NOTRY=True
BUG=

Review-Url: https://codereview.webrtc.org/2259513002
Cr-Commit-Position: refs/heads/master@{#13806}

webrtc/sdk/objc/Framework/Classes/RTCEAGLVideoView.m

diff --git a/webrtc/sdk/objc/Framework/Classes/RTCEAGLVideoView.m b/webrtc/sdk/objc/Framework/Classes/RTCEAGLVideoView.m
index 01c839a..d39c598 100644
--- a/webrtc/sdk/objc/Framework/Classes/RTCEAGLVideoView.m
+++ b/webrtc/sdk/objc/Framework/Classes/RTCEAGLVideoView.m
@@ -93,6 +93,7 @@
 
 @implementation RTCEAGLVideoView {
   RTCDisplayLinkTimer *_timer;
+  EAGLContext *_glContext;
   // This flag should only be set and read on the main thread (e.g. by
   // setNeedsDisplay)
   BOOL _isDirty;
@@ -123,11 +124,12 @@
   if (!glContext) {
     glContext = [[EAGLContext alloc] initWithAPI:kEAGLRenderingAPIOpenGLES2];
   }
-  _glRenderer = [[RTCOpenGLVideoRenderer alloc] initWithContext:glContext];
+  _glContext = glContext;
+  _glRenderer = [[RTCOpenGLVideoRenderer alloc] initWithContext:_glContext];
 
   // GLKView manages a framebuffer for us.
   _glkView = [[GLKView alloc] initWithFrame:CGRectZero
-                                    context:glContext];
+                                    context:_glContext];
   _glkView.drawableColorFormat = GLKViewDrawableColorFormatRGBA8888;
   _glkView.drawableDepthFormat = GLKViewDrawableDepthFormatNone;
   _glkView.drawableStencilFormat = GLKViewDrawableStencilFormatNone;
@@ -169,6 +171,9 @@
     [self teardownGL];
   }
   [_timer invalidate];
+  if (_glContext && [EAGLContext currentContext] == _glContext) {
+    [EAGLContext setCurrentContext:nil];
+  }
 }
 
 #pragma mark - UIView