commit 418cfee167bbc7f08a3e37ce9d4faf0fba34d7e4
author Danil Chapovalov <danilchap@webrtc.org> Wed Mar 25 11:02:37 2020 +0100
committer Commit Bot <commit-bot@chromium.org> Wed Mar 25 14:13:19 2020 +0000
tree 74a3d7cbc39e5b4a60dd7671d2fef040025ea94a
parent 7e91482fcc496103f36333a569992c81b6dc9e9c

Make all RtpExtension uris constexpr rather than just const

while at it removed unused deprecated kGenericFrameDescriptorUri
and slightly reorded extensions for better grouping.

Bug: webrtc:7472
Change-Id: I42c03d5f20798ec9148b5085d57953ff3633e055
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168541
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#30883}

api/rtp_parameters.cc

diff --git a/api/rtp_parameters.cc b/api/rtp_parameters.cc
index d0040a5..4b300a7 100644
--- a/api/rtp_parameters.cc
+++ b/api/rtp_parameters.cc
@@ -96,64 +96,25 @@
   return sb.str();
 }
 
-const char RtpExtension::kAudioLevelUri[] =
-    "urn:ietf:params:rtp-hdrext:ssrc-audio-level";
-
-const char RtpExtension::kTimestampOffsetUri[] =
-    "urn:ietf:params:rtp-hdrext:toffset";
-
-const char RtpExtension::kAbsSendTimeUri[] =
-    "http://www.webrtc.org/experiments/rtp-hdrext/abs-send-time";
-
-const char RtpExtension::kAbsoluteCaptureTimeUri[] =
-    "http://www.webrtc.org/experiments/rtp-hdrext/abs-capture-time";
-
-const char RtpExtension::kVideoRotationUri[] = "urn:3gpp:video-orientation";
-
-const char RtpExtension::kTransportSequenceNumberUri[] =
-    "http://www.ietf.org/id/draft-holmer-rmcat-transport-wide-cc-extensions-01";
-const char RtpExtension::kTransportSequenceNumberV2Uri[] =
-    "http://www.webrtc.org/experiments/rtp-hdrext/transport-wide-cc-02";
-
-// This extension allows applications to adaptively limit the playout delay
-// on frames as per the current needs. For example, a gaming application
-// has very different needs on end-to-end delay compared to a video-conference
-// application.
-const char RtpExtension::kPlayoutDelayUri[] =
-    "http://www.webrtc.org/experiments/rtp-hdrext/playout-delay";
-
-const char RtpExtension::kVideoContentTypeUri[] =
-    "http://www.webrtc.org/experiments/rtp-hdrext/video-content-type";
-
-const char RtpExtension::kVideoTimingUri[] =
-    "http://www.webrtc.org/experiments/rtp-hdrext/video-timing";
-
-const char RtpExtension::kMidUri[] = "urn:ietf:params:rtp-hdrext:sdes:mid";
-
-const char RtpExtension::kFrameMarkingUri[] =
-    "http://tools.ietf.org/html/draft-ietf-avtext-framemarking-07";
-
-const char RtpExtension::kGenericFrameDescriptorUri00[] =
-    "http://www.webrtc.org/experiments/rtp-hdrext/generic-frame-descriptor-00";
-const char RtpExtension::kGenericFrameDescriptorUri01[] =
-    "http://www.webrtc.org/experiments/rtp-hdrext/generic-frame-descriptor-01";
-const char RtpExtension::kDependencyDescriptorUri[] =
-    "https://aomediacodec.github.io/av1-rtp-spec/"
-    "#dependency-descriptor-rtp-header-extension";
-const char RtpExtension::kGenericFrameDescriptorUri[] =
-    "http://www.webrtc.org/experiments/rtp-hdrext/generic-frame-descriptor-00";
-
-const char RtpExtension::kEncryptHeaderExtensionsUri[] =
-    "urn:ietf:params:rtp-hdrext:encrypt";
-
-const char RtpExtension::kColorSpaceUri[] =
-    "http://www.webrtc.org/experiments/rtp-hdrext/color-space";
-
-const char RtpExtension::kRidUri[] =
-    "urn:ietf:params:rtp-hdrext:sdes:rtp-stream-id";
-
-const char RtpExtension::kRepairedRidUri[] =
-    "urn:ietf:params:rtp-hdrext:sdes:repaired-rtp-stream-id";
+constexpr char RtpExtension::kEncryptHeaderExtensionsUri[];
+constexpr char RtpExtension::kAudioLevelUri[];
+constexpr char RtpExtension::kTimestampOffsetUri[];
+constexpr char RtpExtension::kAbsSendTimeUri[];
+constexpr char RtpExtension::kAbsoluteCaptureTimeUri[];
+constexpr char RtpExtension::kVideoRotationUri[];
+constexpr char RtpExtension::kVideoContentTypeUri[];
+constexpr char RtpExtension::kVideoTimingUri[];
+constexpr char RtpExtension::kFrameMarkingUri[];
+constexpr char RtpExtension::kGenericFrameDescriptorUri00[];
+constexpr char RtpExtension::kGenericFrameDescriptorUri01[];
+constexpr char RtpExtension::kDependencyDescriptorUri[];
+constexpr char RtpExtension::kTransportSequenceNumberUri[];
+constexpr char RtpExtension::kTransportSequenceNumberV2Uri[];
+constexpr char RtpExtension::kPlayoutDelayUri[];
+constexpr char RtpExtension::kColorSpaceUri[];
+constexpr char RtpExtension::kMidUri[];
+constexpr char RtpExtension::kRidUri[];
+constexpr char RtpExtension::kRepairedRidUri[];
 
 constexpr int RtpExtension::kMinId;
 constexpr int RtpExtension::kMaxId;