Remove ChangeUniqueID.
This fixes a two year old TODO of deleting dead code :)
In cases where the _id or id_ member variable is being used for tracing,
I changed the member to at least be const.
It doesn't look like id's are that useful anymore so maybe the next step is to get rid of them.
BUG=
R=henrika@webrtc.org, perkj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/37849004
Cr-Commit-Position: refs/heads/master@{#8201}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8201 4adac7df-926f-26a2-2b94-8c16560cd09d
diff --git a/webrtc/modules/interface/module.h b/webrtc/modules/interface/module.h
index ccaee8b..c3e3030 100644
--- a/webrtc/modules/interface/module.h
+++ b/webrtc/modules/interface/module.h
@@ -11,51 +11,38 @@
#ifndef MODULES_INTERFACE_MODULE_H_
#define MODULES_INTERFACE_MODULE_H_
-#include <assert.h>
-
#include "webrtc/typedefs.h"
namespace webrtc {
class Module {
public:
- // TODO(henrika): Remove this when chrome is updated.
- // DEPRICATED Change the unique identifier of this object.
- virtual int32_t ChangeUniqueId(const int32_t id) { return 0; }
-
- // Returns the number of milliseconds until the module want a worker
+ // Returns the number of milliseconds until the module wants a worker
// thread to call Process.
+ // This method is called on the same worker thread as Process will
+ // be called on.
virtual int64_t TimeUntilNextProcess() = 0;
// Process any pending tasks such as timeouts.
+ // Called on a worker thread.
virtual int32_t Process() = 0;
protected:
virtual ~Module() {}
};
-// Reference counted version of the module interface.
+// Reference counted version of the Module interface.
class RefCountedModule : public Module {
public:
// Increase the reference count by one.
// Returns the incremented reference count.
- // TODO(perkj): Make this pure virtual when Chromium have implemented
- // reference counting ADM and Video capture module.
- virtual int32_t AddRef() {
- assert(false && "Not implemented.");
- return 1;
- }
+ virtual int32_t AddRef() = 0;
// Decrease the reference count by one.
// Returns the decreased reference count.
// Returns 0 if the last reference was just released.
- // When the reference count reach 0 the object will self-destruct.
- // TODO(perkj): Make this pure virtual when Chromium have implemented
- // reference counting ADM and Video capture module.
- virtual int32_t Release() {
- assert(false && "Not implemented.");
- return 1;
- }
+ // When the reference count reaches 0 the object will self-destruct.
+ virtual int32_t Release() = 0;
protected:
virtual ~RefCountedModule() {}