commit 4011de012fab84af63d4a91adba9a605e4bf4161
author Per Åhgren <peah@webrtc.org> Tue Dec 03 11:48:48 2019 +0000
committer Commit Bot <commit-bot@chromium.org> Tue Dec 03 11:49:00 2019 +0000
tree 3b205e9d89fc72d895e9bbd08aa318e6ecbcd182
parent 6a05bb1b1214fd914c35e4cdbaabbd5003b6ecde

Revert "AEC3: Ensure that the high-pass filter effect is on when AEC3 is active"

This reverts commit 3a77f93589f77aabfdfa75cd7202f09b4315ff7c.

Reason for revert: The change is breaking downstream tests.

Original change's description:
> AEC3: Ensure that the high-pass filter effect is on when AEC3 is active
> 
> This CL ensures that the high-pass filter is on whenever the echo
> controller is on. This is important as the echo controller code assumes
> that the external high-pass filter is active.
> 
> The CL also corrects the ToggleAec unit test (which started failing
> after this code change).
> 
> Bug: webrtc:11159,chromium:1030179
> Change-Id: Ie29db74bf3de6279a08564398d32d67d5e1569db
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161222
> Reviewed-by: Sam Zackrisson <saza@webrtc.org>
> Commit-Queue: Per Åhgren <peah@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#29979}

TBR=saza@webrtc.org,peah@webrtc.org

Change-Id: I78b4e397555f50898ca42c4b32fb39cf06a2541a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:11159, chromium:1030179
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/161226
Reviewed-by: Per Åhgren <peah@webrtc.org>
Commit-Queue: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29981}

modules/audio_processing/test/debug_dump_test.cc

diff --git a/modules/audio_processing/test/debug_dump_test.cc b/modules/audio_processing/test/debug_dump_test.cc
index 1d3451d..b769a66 100644
--- a/modules/audio_processing/test/debug_dump_test.cc
+++ b/modules/audio_processing/test/debug_dump_test.cc
@@ -51,8 +51,8 @@
                      bool enable_pre_amplifier);
 
   // Constructor that uses default input files.
-  DebugDumpGenerator(const Config& config,
-                     const AudioProcessing::Config& apm_config);
+  explicit DebugDumpGenerator(const Config& config,
+                              const AudioProcessing::Config& apm_config);
 
   ~DebugDumpGenerator();
 
@@ -346,7 +346,7 @@
   generator.StartRecording();
   generator.Process(100);
 
-  apm_config.echo_canceller.enabled = false;
+  apm_config.echo_canceller.enabled = true;
   generator.apm()->ApplyConfig(apm_config);
 
   generator.Process(100);