commit 3e113438b10cffee6239aa85ac3ec08369dc6113
author Patrik Höglund <phoglund@webrtc.org> Fri Dec 15 14:40:10 2017 +0100
committer Commit Bot <commit-bot@chromium.org> Fri Dec 15 14:33:26 2017 +0000
tree ca74e8a3b8b1e92ecf57ea4592a10222cf4c2741
parent d5d0540b86978aa7c121a37f9d8a232091498199

Fix circular dependencies in webrtc_common.

One reason for the circular deps is that common_types.h is a
historical dumping ground for various structs and defines that
are believed to be generally useful. I tried moving things out
that did not appear to be used downstream (StreamCounters,
RtpCounters etc) and moved the things that seemed used
(RtpHeader + supporting structs) to a new file api/rtp_headers.h.
This makes their place in the api more clear while moving out
the things that don't belong in the API in the first place.

I had to extract out typedefs.h from webrtc_common to resolve
another circular dependency. I believe checks includes typedefs,
but common depends on checks.

Bug: webrtc:7745
Change-Id: I725d49616b1ec0cdc8b74be7c078f7a4d46f084b
Reviewed-on: https://webrtc-review.googlesource.com/33001
Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21295}

modules/audio_processing/BUILD.gn

diff --git a/modules/audio_processing/BUILD.gn b/modules/audio_processing/BUILD.gn
index b190f02..d879076 100644
--- a/modules/audio_processing/BUILD.gn
+++ b/modules/audio_processing/BUILD.gn
@@ -226,10 +226,12 @@
     ":audio_processing_statistics",
     "..:module_api",
     "../..:webrtc_common",
+    "../../:typedefs",
     "../../api:array_view",
     "../../api:optional",
     "../../audio/utility:audio_frame_operations",
     "../../rtc_base:checks",
+    "../../rtc_base:deprecation",
     "../../rtc_base:gtest_prod",
     "../../rtc_base:protobuf_utils",
     "../../rtc_base:sanitizer",
@@ -341,6 +343,7 @@
 
   deps = [
     "../..:webrtc_common",
+    "../../:typedefs",
     "../../common_audio",
     "../../rtc_base:checks",
     "../../rtc_base:rtc_base_approved",
@@ -371,6 +374,7 @@
     "../../api:array_view",
     "../../common_audio:common_audio",
     "../../rtc_base:rtc_base_approved",
+    "../../rtc_base:stringutils",
   ]
   defines = []
   if (apm_debug_dump) {
@@ -404,6 +408,7 @@
     ":apm_logging",
     ":audio_processing_statistics",
     "../..:webrtc_common",
+    "../../:typedefs",
     "../../common_audio:common_audio",
     "../../rtc_base:checks",
     "../../rtc_base:rtc_base_approved",
@@ -582,6 +587,7 @@
       ":audioproc_test_utils",
       "..:module_api",
       "../..:webrtc_common",
+      "../../:typedefs",
       "../../api:array_view",
       "../../api:optional",
       "../../common_audio:common_audio",
@@ -768,6 +774,7 @@
         "../../rtc_base:protobuf_utils",
         "../../rtc_base:rtc_base_approved",
         "../../rtc_base:rtc_task_queue",
+        "../../rtc_base:stringutils",
         "../../system_wrappers",
         "../../system_wrappers:system_wrappers_default",
         "../../test:test_support",
@@ -819,6 +826,7 @@
       ":audio_processing",
       "..:module_api",
       "../..:webrtc_common",
+      "../../:typedefs",
       "../../common_audio:common_audio",
       "../../rtc_base:rtc_base_approved",
       "../../system_wrappers",
@@ -838,6 +846,7 @@
     deps = [
       ":audio_processing",
       "../..:webrtc_common",
+      "../../:typedefs",
       "../../system_wrappers",
       "../../system_wrappers:metrics_default",
     ]
@@ -892,6 +901,7 @@
       deps = [
         ":audioproc_debug_proto",
         "../..:webrtc_common",
+        "../../:typedefs",
         "../../rtc_base:protobuf_utils",
         "../../rtc_base:rtc_base_approved",
       ]