commit 3b9ff38d8a10d46f69680c5634b4814fb02378e2
author ossu <ossu@webrtc.org> Thu Apr 27 08:03:42 2017 -0700
committer Commit bot <commit-bot@chromium.org> Thu Apr 27 15:03:42 2017 +0000
tree b091a79173007593464dcc346efbf0243257d3a5
parent 9078d8cf05f6307db640509ab9950592d3956e20

Have AudioSendStream register CNG payload types with the RtpRtcpModule.

TBR=kwiberg@webrtc.org # Turn perf-bots green again

BUG=webrtc:5806

Review-Url: https://codereview.webrtc.org/2844803003
Cr-Commit-Position: refs/heads/master@{#17911}

webrtc/audio/audio_send_stream.cc

diff --git a/webrtc/audio/audio_send_stream.cc b/webrtc/audio/audio_send_stream.cc
index 28541ca..d413a96 100644
--- a/webrtc/audio/audio_send_stream.cc
+++ b/webrtc/audio/audio_send_stream.cc
@@ -28,7 +28,7 @@
 #include "webrtc/modules/bitrate_controller/include/bitrate_controller.h"
 #include "webrtc/modules/congestion_controller/include/send_side_congestion_controller.h"
 #include "webrtc/modules/pacing/paced_sender.h"
-#include "webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h"
+#include "webrtc/modules/rtp_rtcp/include/rtp_rtcp.h"
 #include "webrtc/voice_engine/channel_proxy.h"
 #include "webrtc/voice_engine/include/voe_base.h"
 #include "webrtc/voice_engine/transmit_mixer.h"
@@ -421,6 +421,10 @@
     cng_config.speech_encoder = std::move(encoder);
     cng_config.vad_mode = Vad::kVadNormal;
     encoder.reset(new AudioEncoderCng(std::move(cng_config)));
+
+    stream->RegisterCngPayloadType(
+        *spec.cng_payload_type,
+        new_config.send_codec_spec->format.clockrate_hz);
   }
 
   stream->channel_proxy_->SetEncoder(new_config.send_codec_spec->payload_type,
@@ -498,6 +502,14 @@
     return;
   }
 
+  // Register the CNG payload type if it's been added, don't do anything if CNG
+  // is removed. Payload types must not be redefined.
+  if (new_config.send_codec_spec->cng_payload_type) {
+    stream->RegisterCngPayloadType(
+        *new_config.send_codec_spec->cng_payload_type,
+        new_config.send_codec_spec->format.clockrate_hz);
+  }
+
   // Wrap or unwrap the encoder in an AudioEncoderCNG.
   stream->channel_proxy_->ModifyEncoder(
       [&](std::unique_ptr<AudioEncoder>* encoder_ptr) {
@@ -572,5 +584,21 @@
   thread_sync_event.Wait(rtc::Event::kForever);
 }
 
+void AudioSendStream::RegisterCngPayloadType(int payload_type,
+                                             int clockrate_hz) {
+  RtpRtcp* rtpRtcpModule = nullptr;
+  RtpReceiver* rtpReceiver = nullptr;  // Unused, but required for call.
+  channel_proxy_->GetRtpRtcp(&rtpRtcpModule, &rtpReceiver);
+  const CodecInst codec = {payload_type, "CN", clockrate_hz, 0, 1, 0};
+  if (rtpRtcpModule->RegisterSendPayload(codec) != 0) {
+    rtpRtcpModule->DeRegisterSendPayload(codec.pltype);
+    if (rtpRtcpModule->RegisterSendPayload(codec) != 0) {
+      LOG(LS_ERROR) << "RegisterCngPayloadType() failed to register CN to "
+                       "RTP/RTCP module";
+    }
+  }
+}
+
+
 }  // namespace internal
 }  // namespace webrtc