Replace scoped_ptr with unique_ptr in webrtc/modules/audio_coding/neteq/
BUG=webrtc:5520
Review URL: https://codereview.webrtc.org/1697823002
Cr-Commit-Position: refs/heads/master@{#11616}
diff --git a/webrtc/modules/audio_coding/neteq/audio_classifier.h b/webrtc/modules/audio_coding/neteq/audio_classifier.h
index b32f9d5..653b275 100644
--- a/webrtc/modules/audio_coding/neteq/audio_classifier.h
+++ b/webrtc/modules/audio_coding/neteq/audio_classifier.h
@@ -17,7 +17,6 @@
#include "opus_private.h"
}
-#include "webrtc/base/scoped_ptr.h"
#include "webrtc/typedefs.h"
namespace webrtc {
diff --git a/webrtc/modules/audio_coding/neteq/audio_classifier_unittest.cc b/webrtc/modules/audio_coding/neteq/audio_classifier_unittest.cc
index 371282c..bdc5a05 100644
--- a/webrtc/modules/audio_coding/neteq/audio_classifier_unittest.cc
+++ b/webrtc/modules/audio_coding/neteq/audio_classifier_unittest.cc
@@ -14,6 +14,7 @@
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
+#include <memory>
#include <string>
#include "testing/gtest/include/gtest/gtest.h"
@@ -39,7 +40,7 @@
const std::string& data_filename,
size_t channels) {
AudioClassifier classifier;
- rtc::scoped_ptr<int16_t[]> in(new int16_t[channels * kFrameSize]);
+ std::unique_ptr<int16_t[]> in(new int16_t[channels * kFrameSize]);
bool is_music_ref;
FILE* audio_file = fopen(audio_filename.c_str(), "rb");
diff --git a/webrtc/modules/audio_coding/neteq/audio_decoder_unittest.cc b/webrtc/modules/audio_coding/neteq/audio_decoder_unittest.cc
index 599929e..3a3b7bc 100644
--- a/webrtc/modules/audio_coding/neteq/audio_decoder_unittest.cc
+++ b/webrtc/modules/audio_coding/neteq/audio_decoder_unittest.cc
@@ -13,11 +13,11 @@
#include <assert.h>
#include <stdlib.h>
+#include <memory>
#include <string>
#include <vector>
#include "testing/gtest/include/gtest/gtest.h"
-#include "webrtc/base/scoped_ptr.h"
#include "webrtc/modules/audio_coding/codecs/g711/audio_decoder_pcm.h"
#include "webrtc/modules/audio_coding/codecs/g711/audio_encoder_pcm.h"
#include "webrtc/modules/audio_coding/codecs/g722/audio_decoder_g722.h"
@@ -146,7 +146,7 @@
const size_t samples_per_10ms = audio_encoder_->SampleRateHz() / 100;
RTC_CHECK_EQ(samples_per_10ms * audio_encoder_->Num10MsFramesInNextPacket(),
input_len_samples);
- rtc::scoped_ptr<int16_t[]> interleaved_input(
+ std::unique_ptr<int16_t[]> interleaved_input(
new int16_t[channels_ * samples_per_10ms]);
for (size_t i = 0; i < audio_encoder_->Num10MsFramesInNextPacket(); ++i) {
EXPECT_EQ(0u, encoded_info_.encoded_bytes);
@@ -223,14 +223,14 @@
// decode. Verifies that the decoded result is the same.
void ReInitTest() {
InitEncoder();
- rtc::scoped_ptr<int16_t[]> input(new int16_t[frame_size_]);
+ std::unique_ptr<int16_t[]> input(new int16_t[frame_size_]);
ASSERT_TRUE(
input_audio_.Read(frame_size_, codec_input_rate_hz_, input.get()));
size_t enc_len = EncodeFrame(input.get(), frame_size_, encoded_);
size_t dec_len;
AudioDecoder::SpeechType speech_type1, speech_type2;
decoder_->Reset();
- rtc::scoped_ptr<int16_t[]> output1(new int16_t[frame_size_ * channels_]);
+ std::unique_ptr<int16_t[]> output1(new int16_t[frame_size_ * channels_]);
dec_len = decoder_->Decode(encoded_, enc_len, codec_input_rate_hz_,
frame_size_ * channels_ * sizeof(int16_t),
output1.get(), &speech_type1);
@@ -238,7 +238,7 @@
EXPECT_EQ(frame_size_ * channels_, dec_len);
// Re-init decoder and decode again.
decoder_->Reset();
- rtc::scoped_ptr<int16_t[]> output2(new int16_t[frame_size_ * channels_]);
+ std::unique_ptr<int16_t[]> output2(new int16_t[frame_size_ * channels_]);
dec_len = decoder_->Decode(encoded_, enc_len, codec_input_rate_hz_,
frame_size_ * channels_ * sizeof(int16_t),
output2.get(), &speech_type2);
@@ -253,13 +253,13 @@
// Call DecodePlc and verify that the correct number of samples is produced.
void DecodePlcTest() {
InitEncoder();
- rtc::scoped_ptr<int16_t[]> input(new int16_t[frame_size_]);
+ std::unique_ptr<int16_t[]> input(new int16_t[frame_size_]);
ASSERT_TRUE(
input_audio_.Read(frame_size_, codec_input_rate_hz_, input.get()));
size_t enc_len = EncodeFrame(input.get(), frame_size_, encoded_);
AudioDecoder::SpeechType speech_type;
decoder_->Reset();
- rtc::scoped_ptr<int16_t[]> output(new int16_t[frame_size_ * channels_]);
+ std::unique_ptr<int16_t[]> output(new int16_t[frame_size_ * channels_]);
size_t dec_len = decoder_->Decode(encoded_, enc_len, codec_input_rate_hz_,
frame_size_ * channels_ * sizeof(int16_t),
output.get(), &speech_type);
@@ -281,7 +281,7 @@
const int payload_type_;
AudioEncoder::EncodedInfo encoded_info_;
AudioDecoder* decoder_;
- rtc::scoped_ptr<AudioEncoder> audio_encoder_;
+ std::unique_ptr<AudioEncoder> audio_encoder_;
};
class AudioDecoderPcmUTest : public AudioDecoderTest {
@@ -345,13 +345,13 @@
// not return any data. It simply resets a few states and returns 0.
void DecodePlcTest() {
InitEncoder();
- rtc::scoped_ptr<int16_t[]> input(new int16_t[frame_size_]);
+ std::unique_ptr<int16_t[]> input(new int16_t[frame_size_]);
ASSERT_TRUE(
input_audio_.Read(frame_size_, codec_input_rate_hz_, input.get()));
size_t enc_len = EncodeFrame(input.get(), frame_size_, encoded_);
AudioDecoder::SpeechType speech_type;
decoder_->Reset();
- rtc::scoped_ptr<int16_t[]> output(new int16_t[frame_size_ * channels_]);
+ std::unique_ptr<int16_t[]> output(new int16_t[frame_size_ * channels_]);
size_t dec_len = decoder_->Decode(encoded_, enc_len, codec_input_rate_hz_,
frame_size_ * channels_ * sizeof(int16_t),
output.get(), &speech_type);
diff --git a/webrtc/modules/audio_coding/neteq/audio_vector.cc b/webrtc/modules/audio_coding/neteq/audio_vector.cc
index fa16481..013e1d8 100644
--- a/webrtc/modules/audio_coding/neteq/audio_vector.cc
+++ b/webrtc/modules/audio_coding/neteq/audio_vector.cc
@@ -13,6 +13,7 @@
#include <assert.h>
#include <algorithm>
+#include <memory>
#include "webrtc/typedefs.h"
@@ -180,7 +181,7 @@
void AudioVector::Reserve(size_t n) {
if (capacity_ < n) {
- rtc::scoped_ptr<int16_t[]> temp_array(new int16_t[n]);
+ std::unique_ptr<int16_t[]> temp_array(new int16_t[n]);
memcpy(temp_array.get(), array_.get(), Size() * sizeof(int16_t));
array_.swap(temp_array);
capacity_ = n;
diff --git a/webrtc/modules/audio_coding/neteq/audio_vector.h b/webrtc/modules/audio_coding/neteq/audio_vector.h
index e046e38..15297f9 100644
--- a/webrtc/modules/audio_coding/neteq/audio_vector.h
+++ b/webrtc/modules/audio_coding/neteq/audio_vector.h
@@ -12,9 +12,9 @@
#define WEBRTC_MODULES_AUDIO_CODING_NETEQ_AUDIO_VECTOR_H_
#include <string.h> // Access to size_t.
+#include <memory>
#include "webrtc/base/constructormagic.h"
-#include "webrtc/base/scoped_ptr.h"
#include "webrtc/typedefs.h"
namespace webrtc {
@@ -100,7 +100,7 @@
void Reserve(size_t n);
- rtc::scoped_ptr<int16_t[]> array_;
+ std::unique_ptr<int16_t[]> array_;
size_t first_free_ix_; // The first index after the last sample in array_.
// Note that this index may point outside of array_.
size_t capacity_; // Allocated number of samples in the array.
diff --git a/webrtc/modules/audio_coding/neteq/background_noise.h b/webrtc/modules/audio_coding/neteq/background_noise.h
index 976c558..2e54667 100644
--- a/webrtc/modules/audio_coding/neteq/background_noise.h
+++ b/webrtc/modules/audio_coding/neteq/background_noise.h
@@ -12,9 +12,9 @@
#define WEBRTC_MODULES_AUDIO_CODING_NETEQ_BACKGROUND_NOISE_H_
#include <string.h> // size_t
+#include <memory>
#include "webrtc/base/constructormagic.h"
-#include "webrtc/base/scoped_ptr.h"
#include "webrtc/modules/audio_coding/neteq/audio_multi_vector.h"
#include "webrtc/modules/audio_coding/neteq/include/neteq.h"
#include "webrtc/typedefs.h"
@@ -126,7 +126,7 @@
int32_t residual_energy);
size_t num_channels_;
- rtc::scoped_ptr<ChannelParameters[]> channel_parameters_;
+ std::unique_ptr<ChannelParameters[]> channel_parameters_;
bool initialized_;
NetEq::BackgroundNoiseMode mode_;
diff --git a/webrtc/modules/audio_coding/neteq/decoder_database.h b/webrtc/modules/audio_coding/neteq/decoder_database.h
index f34904f..01ff0c9 100644
--- a/webrtc/modules/audio_coding/neteq/decoder_database.h
+++ b/webrtc/modules/audio_coding/neteq/decoder_database.h
@@ -15,7 +15,6 @@
#include <string>
#include "webrtc/base/constructormagic.h"
-#include "webrtc/base/scoped_ptr.h"
#include "webrtc/common_types.h" // NULL
#include "webrtc/modules/audio_coding/neteq/audio_decoder_impl.h"
#include "webrtc/modules/audio_coding/neteq/packet.h"
diff --git a/webrtc/modules/audio_coding/neteq/expand.h b/webrtc/modules/audio_coding/neteq/expand.h
index 25c8c21..7f61bf3 100644
--- a/webrtc/modules/audio_coding/neteq/expand.h
+++ b/webrtc/modules/audio_coding/neteq/expand.h
@@ -12,9 +12,9 @@
#define WEBRTC_MODULES_AUDIO_CODING_NETEQ_EXPAND_H_
#include <assert.h>
+#include <memory>
#include "webrtc/base/constructormagic.h"
-#include "webrtc/base/scoped_ptr.h"
#include "webrtc/modules/audio_coding/neteq/audio_multi_vector.h"
#include "webrtc/typedefs.h"
@@ -138,7 +138,7 @@
int current_lag_index_;
bool stop_muting_;
size_t expand_duration_samples_;
- rtc::scoped_ptr<ChannelParameters[]> channel_parameters_;
+ std::unique_ptr<ChannelParameters[]> channel_parameters_;
RTC_DISALLOW_COPY_AND_ASSIGN(Expand);
};
diff --git a/webrtc/modules/audio_coding/neteq/merge.cc b/webrtc/modules/audio_coding/neteq/merge.cc
index b6fb2d8..9aed91f 100644
--- a/webrtc/modules/audio_coding/neteq/merge.cc
+++ b/webrtc/modules/audio_coding/neteq/merge.cc
@@ -14,8 +14,8 @@
#include <string.h> // memmove, memcpy, memset, size_t
#include <algorithm> // min, max
+#include <memory>
-#include "webrtc/base/scoped_ptr.h"
#include "webrtc/common_audio/signal_processing/include/signal_processing_library.h"
#include "webrtc/modules/audio_coding/neteq/audio_multi_vector.h"
#include "webrtc/modules/audio_coding/neteq/dsp_helper.h"
@@ -327,7 +327,7 @@
// Normalize correlation to 14 bits and copy to a 16-bit array.
const size_t pad_length = expand_->overlap_length() - 1;
const size_t correlation_buffer_size = 2 * pad_length + kMaxCorrelationLength;
- rtc::scoped_ptr<int16_t[]> correlation16(
+ std::unique_ptr<int16_t[]> correlation16(
new int16_t[correlation_buffer_size]);
memset(correlation16.get(), 0, correlation_buffer_size * sizeof(int16_t));
int16_t* correlation_ptr = &correlation16[pad_length];
diff --git a/webrtc/modules/audio_coding/neteq/nack.h b/webrtc/modules/audio_coding/neteq/nack.h
index f30e459..c46a85a 100644
--- a/webrtc/modules/audio_coding/neteq/nack.h
+++ b/webrtc/modules/audio_coding/neteq/nack.h
@@ -15,7 +15,6 @@
#include <map>
#include "webrtc/base/gtest_prod_util.h"
-#include "webrtc/base/scoped_ptr.h"
#include "webrtc/modules/audio_coding/include/audio_coding_module_typedefs.h"
//
diff --git a/webrtc/modules/audio_coding/neteq/nack_unittest.cc b/webrtc/modules/audio_coding/neteq/nack_unittest.cc
index 53b19dc..fe76e08 100644
--- a/webrtc/modules/audio_coding/neteq/nack_unittest.cc
+++ b/webrtc/modules/audio_coding/neteq/nack_unittest.cc
@@ -13,9 +13,9 @@
#include <stdint.h>
#include <algorithm>
+#include <memory>
#include "testing/gtest/include/gtest/gtest.h"
-#include "webrtc/base/scoped_ptr.h"
#include "webrtc/typedefs.h"
#include "webrtc/modules/audio_coding/include/audio_coding_module_typedefs.h"
@@ -55,7 +55,7 @@
} // namespace
TEST(NackTest, EmptyListWhenNoPacketLoss) {
- rtc::scoped_ptr<Nack> nack(Nack::Create(kNackThreshold));
+ std::unique_ptr<Nack> nack(Nack::Create(kNackThreshold));
nack->UpdateSampleRate(kSampleRateHz);
int seq_num = 1;
@@ -73,7 +73,7 @@
}
TEST(NackTest, NoNackIfReorderWithinNackThreshold) {
- rtc::scoped_ptr<Nack> nack(Nack::Create(kNackThreshold));
+ std::unique_ptr<Nack> nack(Nack::Create(kNackThreshold));
nack->UpdateSampleRate(kSampleRateHz);
int seq_num = 1;
@@ -102,7 +102,7 @@
sizeof(kSequenceNumberLostPackets[0]);
for (int k = 0; k < 2; k++) { // Two iteration with/without wrap around.
- rtc::scoped_ptr<Nack> nack(Nack::Create(kNackThreshold));
+ std::unique_ptr<Nack> nack(Nack::Create(kNackThreshold));
nack->UpdateSampleRate(kSampleRateHz);
uint16_t sequence_num_lost_packets[kNumAllLostPackets];
@@ -151,7 +151,7 @@
sizeof(kSequenceNumberLostPackets[0]);
for (int k = 0; k < 2; ++k) { // Two iteration with/without wrap around.
- rtc::scoped_ptr<Nack> nack(Nack::Create(kNackThreshold));
+ std::unique_ptr<Nack> nack(Nack::Create(kNackThreshold));
nack->UpdateSampleRate(kSampleRateHz);
uint16_t sequence_num_lost_packets[kNumAllLostPackets];
@@ -213,7 +213,7 @@
sizeof(kLostPackets) / sizeof(kLostPackets[0]);
for (int k = 0; k < 4; ++k) {
- rtc::scoped_ptr<Nack> nack(Nack::Create(kNackThreshold));
+ std::unique_ptr<Nack> nack(Nack::Create(kNackThreshold));
nack->UpdateSampleRate(kSampleRateHz);
// Sequence number wrap around if |k| is 2 or 3;
@@ -284,7 +284,7 @@
TEST(NackTest, MissingPacketsPriorToLastDecodedRtpShouldNotBeInNackList) {
for (int m = 0; m < 2; ++m) {
uint16_t seq_num_offset = (m == 0) ? 0 : 65531; // Wrap around if |m| is 1.
- rtc::scoped_ptr<Nack> nack(Nack::Create(kNackThreshold));
+ std::unique_ptr<Nack> nack(Nack::Create(kNackThreshold));
nack->UpdateSampleRate(kSampleRateHz);
// Two consecutive packets to have a correct estimate of timestamp increase.
@@ -335,7 +335,7 @@
}
TEST(NackTest, Reset) {
- rtc::scoped_ptr<Nack> nack(Nack::Create(kNackThreshold));
+ std::unique_ptr<Nack> nack(Nack::Create(kNackThreshold));
nack->UpdateSampleRate(kSampleRateHz);
// Two consecutive packets to have a correct estimate of timestamp increase.
@@ -362,7 +362,7 @@
const size_t kNackListSize = 10;
for (int m = 0; m < 2; ++m) {
uint16_t seq_num_offset = (m == 0) ? 0 : 65525; // Wrap around if |m| is 1.
- rtc::scoped_ptr<Nack> nack(Nack::Create(kNackThreshold));
+ std::unique_ptr<Nack> nack(Nack::Create(kNackThreshold));
nack->UpdateSampleRate(kSampleRateHz);
nack->SetMaxNackListSize(kNackListSize);
@@ -386,7 +386,7 @@
const size_t kNackListSize = 10;
for (int m = 0; m < 2; ++m) {
uint16_t seq_num_offset = (m == 0) ? 0 : 65525; // Wrap around if |m| is 1.
- rtc::scoped_ptr<Nack> nack(Nack::Create(kNackThreshold));
+ std::unique_ptr<Nack> nack(Nack::Create(kNackThreshold));
nack->UpdateSampleRate(kSampleRateHz);
uint16_t seq_num = seq_num_offset;
@@ -396,7 +396,7 @@
// Packet lost more than NACK-list size limit.
uint16_t num_lost_packets = kNackThreshold + kNackListSize + 5;
- rtc::scoped_ptr<uint16_t[]> seq_num_lost(new uint16_t[num_lost_packets]);
+ std::unique_ptr<uint16_t[]> seq_num_lost(new uint16_t[num_lost_packets]);
for (int n = 0; n < num_lost_packets; ++n) {
seq_num_lost[n] = ++seq_num;
}
@@ -452,7 +452,7 @@
TEST(NackTest, RoudTripTimeIsApplied) {
const int kNackListSize = 200;
- rtc::scoped_ptr<Nack> nack(Nack::Create(kNackThreshold));
+ std::unique_ptr<Nack> nack(Nack::Create(kNackThreshold));
nack->UpdateSampleRate(kSampleRateHz);
nack->SetMaxNackListSize(kNackListSize);
diff --git a/webrtc/modules/audio_coding/neteq/neteq_external_decoder_unittest.cc b/webrtc/modules/audio_coding/neteq/neteq_external_decoder_unittest.cc
index c03fbb7..73eff45 100644
--- a/webrtc/modules/audio_coding/neteq/neteq_external_decoder_unittest.cc
+++ b/webrtc/modules/audio_coding/neteq/neteq_external_decoder_unittest.cc
@@ -10,8 +10,9 @@
// Test to verify correct operation for externally created decoders.
+#include <memory>
+
#include "testing/gmock/include/gmock/gmock.h"
-#include "webrtc/base/scoped_ptr.h"
#include "webrtc/modules/audio_coding/neteq/mock/mock_external_decoder_pcm16b.h"
#include "webrtc/modules/audio_coding/neteq/tools/input_audio_file.h"
#include "webrtc/modules/audio_coding/neteq/tools/neteq_external_decoder_test.h"
@@ -145,16 +146,16 @@
int samples_per_ms() const { return samples_per_ms_; }
private:
- rtc::scoped_ptr<MockExternalPcm16B> external_decoder_;
+ std::unique_ptr<MockExternalPcm16B> external_decoder_;
int samples_per_ms_;
size_t frame_size_samples_;
- rtc::scoped_ptr<test::RtpGenerator> rtp_generator_;
+ std::unique_ptr<test::RtpGenerator> rtp_generator_;
int16_t* input_;
uint8_t* encoded_;
size_t payload_size_bytes_;
uint32_t last_send_time_;
uint32_t last_arrival_time_;
- rtc::scoped_ptr<test::InputAudioFile> input_file_;
+ std::unique_ptr<test::InputAudioFile> input_file_;
WebRtcRTPHeader rtp_header_;
};
@@ -225,7 +226,7 @@
private:
int sample_rate_hz_;
- rtc::scoped_ptr<NetEq> neteq_internal_;
+ std::unique_ptr<NetEq> neteq_internal_;
int16_t output_internal_[kMaxBlockSize];
int16_t output_[kMaxBlockSize];
};
diff --git a/webrtc/modules/audio_coding/neteq/neteq_impl.h b/webrtc/modules/audio_coding/neteq/neteq_impl.h
index 02adcd3..78c678c 100644
--- a/webrtc/modules/audio_coding/neteq/neteq_impl.h
+++ b/webrtc/modules/audio_coding/neteq/neteq_impl.h
@@ -11,11 +11,11 @@
#ifndef WEBRTC_MODULES_AUDIO_CODING_NETEQ_NETEQ_IMPL_H_
#define WEBRTC_MODULES_AUDIO_CODING_NETEQ_NETEQ_IMPL_H_
+#include <memory>
#include <string>
#include "webrtc/base/constructormagic.h"
#include "webrtc/base/criticalsection.h"
-#include "webrtc/base/scoped_ptr.h"
#include "webrtc/base/thread_annotations.h"
#include "webrtc/modules/audio_coding/neteq/audio_multi_vector.h"
#include "webrtc/modules/audio_coding/neteq/defines.h"
@@ -339,39 +339,39 @@
virtual void CreateDecisionLogic() EXCLUSIVE_LOCKS_REQUIRED(crit_sect_);
rtc::CriticalSection crit_sect_;
- const rtc::scoped_ptr<BufferLevelFilter> buffer_level_filter_
+ const std::unique_ptr<BufferLevelFilter> buffer_level_filter_
GUARDED_BY(crit_sect_);
- const rtc::scoped_ptr<DecoderDatabase> decoder_database_
+ const std::unique_ptr<DecoderDatabase> decoder_database_
GUARDED_BY(crit_sect_);
- const rtc::scoped_ptr<DelayManager> delay_manager_ GUARDED_BY(crit_sect_);
- const rtc::scoped_ptr<DelayPeakDetector> delay_peak_detector_
+ const std::unique_ptr<DelayManager> delay_manager_ GUARDED_BY(crit_sect_);
+ const std::unique_ptr<DelayPeakDetector> delay_peak_detector_
GUARDED_BY(crit_sect_);
- const rtc::scoped_ptr<DtmfBuffer> dtmf_buffer_ GUARDED_BY(crit_sect_);
- const rtc::scoped_ptr<DtmfToneGenerator> dtmf_tone_generator_
+ const std::unique_ptr<DtmfBuffer> dtmf_buffer_ GUARDED_BY(crit_sect_);
+ const std::unique_ptr<DtmfToneGenerator> dtmf_tone_generator_
GUARDED_BY(crit_sect_);
- const rtc::scoped_ptr<PacketBuffer> packet_buffer_ GUARDED_BY(crit_sect_);
- const rtc::scoped_ptr<PayloadSplitter> payload_splitter_
+ const std::unique_ptr<PacketBuffer> packet_buffer_ GUARDED_BY(crit_sect_);
+ const std::unique_ptr<PayloadSplitter> payload_splitter_
GUARDED_BY(crit_sect_);
- const rtc::scoped_ptr<TimestampScaler> timestamp_scaler_
+ const std::unique_ptr<TimestampScaler> timestamp_scaler_
GUARDED_BY(crit_sect_);
- const rtc::scoped_ptr<PostDecodeVad> vad_ GUARDED_BY(crit_sect_);
- const rtc::scoped_ptr<ExpandFactory> expand_factory_ GUARDED_BY(crit_sect_);
- const rtc::scoped_ptr<AccelerateFactory> accelerate_factory_
+ const std::unique_ptr<PostDecodeVad> vad_ GUARDED_BY(crit_sect_);
+ const std::unique_ptr<ExpandFactory> expand_factory_ GUARDED_BY(crit_sect_);
+ const std::unique_ptr<AccelerateFactory> accelerate_factory_
GUARDED_BY(crit_sect_);
- const rtc::scoped_ptr<PreemptiveExpandFactory> preemptive_expand_factory_
+ const std::unique_ptr<PreemptiveExpandFactory> preemptive_expand_factory_
GUARDED_BY(crit_sect_);
- rtc::scoped_ptr<BackgroundNoise> background_noise_ GUARDED_BY(crit_sect_);
- rtc::scoped_ptr<DecisionLogic> decision_logic_ GUARDED_BY(crit_sect_);
- rtc::scoped_ptr<AudioMultiVector> algorithm_buffer_ GUARDED_BY(crit_sect_);
- rtc::scoped_ptr<SyncBuffer> sync_buffer_ GUARDED_BY(crit_sect_);
- rtc::scoped_ptr<Expand> expand_ GUARDED_BY(crit_sect_);
- rtc::scoped_ptr<Normal> normal_ GUARDED_BY(crit_sect_);
- rtc::scoped_ptr<Merge> merge_ GUARDED_BY(crit_sect_);
- rtc::scoped_ptr<Accelerate> accelerate_ GUARDED_BY(crit_sect_);
- rtc::scoped_ptr<PreemptiveExpand> preemptive_expand_ GUARDED_BY(crit_sect_);
+ std::unique_ptr<BackgroundNoise> background_noise_ GUARDED_BY(crit_sect_);
+ std::unique_ptr<DecisionLogic> decision_logic_ GUARDED_BY(crit_sect_);
+ std::unique_ptr<AudioMultiVector> algorithm_buffer_ GUARDED_BY(crit_sect_);
+ std::unique_ptr<SyncBuffer> sync_buffer_ GUARDED_BY(crit_sect_);
+ std::unique_ptr<Expand> expand_ GUARDED_BY(crit_sect_);
+ std::unique_ptr<Normal> normal_ GUARDED_BY(crit_sect_);
+ std::unique_ptr<Merge> merge_ GUARDED_BY(crit_sect_);
+ std::unique_ptr<Accelerate> accelerate_ GUARDED_BY(crit_sect_);
+ std::unique_ptr<PreemptiveExpand> preemptive_expand_ GUARDED_BY(crit_sect_);
RandomVector random_vector_ GUARDED_BY(crit_sect_);
- rtc::scoped_ptr<ComfortNoise> comfort_noise_ GUARDED_BY(crit_sect_);
+ std::unique_ptr<ComfortNoise> comfort_noise_ GUARDED_BY(crit_sect_);
Rtcp rtcp_ GUARDED_BY(crit_sect_);
StatisticsCalculator stats_ GUARDED_BY(crit_sect_);
int fs_hz_ GUARDED_BY(crit_sect_);
@@ -380,9 +380,9 @@
size_t output_size_samples_ GUARDED_BY(crit_sect_);
size_t decoder_frame_length_ GUARDED_BY(crit_sect_);
Modes last_mode_ GUARDED_BY(crit_sect_);
- rtc::scoped_ptr<int16_t[]> mute_factor_array_ GUARDED_BY(crit_sect_);
+ std::unique_ptr<int16_t[]> mute_factor_array_ GUARDED_BY(crit_sect_);
size_t decoded_buffer_length_ GUARDED_BY(crit_sect_);
- rtc::scoped_ptr<int16_t[]> decoded_buffer_ GUARDED_BY(crit_sect_);
+ std::unique_ptr<int16_t[]> decoded_buffer_ GUARDED_BY(crit_sect_);
uint32_t playout_timestamp_ GUARDED_BY(crit_sect_);
bool new_codec_ GUARDED_BY(crit_sect_);
uint32_t timestamp_ GUARDED_BY(crit_sect_);
@@ -396,7 +396,7 @@
const BackgroundNoiseMode background_noise_mode_ GUARDED_BY(crit_sect_);
NetEqPlayoutMode playout_mode_ GUARDED_BY(crit_sect_);
bool enable_fast_accelerate_ GUARDED_BY(crit_sect_);
- rtc::scoped_ptr<Nack> nack_ GUARDED_BY(crit_sect_);
+ std::unique_ptr<Nack> nack_ GUARDED_BY(crit_sect_);
bool nack_enabled_ GUARDED_BY(crit_sect_);
private:
diff --git a/webrtc/modules/audio_coding/neteq/neteq_network_stats_unittest.cc b/webrtc/modules/audio_coding/neteq/neteq_network_stats_unittest.cc
index d7d48a3..f22c51b 100644
--- a/webrtc/modules/audio_coding/neteq/neteq_network_stats_unittest.cc
+++ b/webrtc/modules/audio_coding/neteq/neteq_network_stats_unittest.cc
@@ -8,8 +8,9 @@
* be found in the AUTHORS file in the root of the source tree.
*/
+#include <memory>
+
#include "testing/gmock/include/gmock/gmock.h"
-#include "webrtc/base/scoped_ptr.h"
#include "webrtc/modules/audio_coding/neteq/tools/neteq_external_decoder_test.h"
#include "webrtc/modules/audio_coding/neteq/tools/rtp_generator.h"
@@ -263,7 +264,7 @@
MockAudioDecoder* external_decoder_;
const int samples_per_ms_;
const size_t frame_size_samples_;
- rtc::scoped_ptr<test::RtpGenerator> rtp_generator_;
+ std::unique_ptr<test::RtpGenerator> rtp_generator_;
WebRtcRTPHeader rtp_header_;
uint32_t last_lost_time_;
uint32_t packet_loss_interval_;
diff --git a/webrtc/modules/audio_coding/neteq/neteq_stereo_unittest.cc b/webrtc/modules/audio_coding/neteq/neteq_stereo_unittest.cc
index 0b4754d..aaff471 100644
--- a/webrtc/modules/audio_coding/neteq/neteq_stereo_unittest.cc
+++ b/webrtc/modules/audio_coding/neteq/neteq_stereo_unittest.cc
@@ -11,11 +11,11 @@
// Test to verify correct stereo and multi-channel operation.
#include <algorithm>
+#include <memory>
#include <string>
#include <list>
#include "testing/gtest/include/gtest/gtest.h"
-#include "webrtc/base/scoped_ptr.h"
#include "webrtc/modules/audio_coding/codecs/pcm16b/pcm16b.h"
#include "webrtc/modules/audio_coding/neteq/include/neteq.h"
#include "webrtc/modules/audio_coding/neteq/tools/input_audio_file.h"
@@ -261,7 +261,7 @@
size_t multi_payload_size_bytes_;
int last_send_time_;
int last_arrival_time_;
- rtc::scoped_ptr<test::InputAudioFile> input_file_;
+ std::unique_ptr<test::InputAudioFile> input_file_;
};
class NetEqStereoTestNoJitter : public NetEqStereoTest {
diff --git a/webrtc/modules/audio_coding/neteq/neteq_unittest.cc b/webrtc/modules/audio_coding/neteq/neteq_unittest.cc
index a304e82..0a85466 100644
--- a/webrtc/modules/audio_coding/neteq/neteq_unittest.cc
+++ b/webrtc/modules/audio_coding/neteq/neteq_unittest.cc
@@ -19,13 +19,13 @@
#include <string.h> // memset
#include <algorithm>
+#include <memory>
#include <set>
#include <string>
#include <vector>
#include "gflags/gflags.h"
#include "testing/gtest/include/gtest/gtest.h"
-#include "webrtc/base/scoped_ptr.h"
#include "webrtc/modules/audio_coding/neteq/tools/audio_loop.h"
#include "webrtc/modules/audio_coding/neteq/tools/rtp_file_source.h"
#include "webrtc/modules/audio_coding/codecs/pcm16b/pcm16b.h"
@@ -102,7 +102,7 @@
ASSERT_EQ(1u, fread(&size, sizeof(size), 1, file));
if (size <= 0)
return;
- rtc::scoped_ptr<char[]> buffer(new char[size]);
+ std::unique_ptr<char[]> buffer(new char[size]);
ASSERT_EQ(static_cast<size_t>(size),
fread(buffer.get(), sizeof(char), size, file));
message->assign(buffer.get(), size);
@@ -320,8 +320,8 @@
NetEq* neteq_;
NetEq::Config config_;
- rtc::scoped_ptr<test::RtpFileSource> rtp_source_;
- rtc::scoped_ptr<test::Packet> packet_;
+ std::unique_ptr<test::RtpFileSource> rtp_source_;
+ std::unique_ptr<test::Packet> packet_;
unsigned int sim_clock_;
int16_t out_data_[kMaxBlockSize];
int output_sample_rate_;
diff --git a/webrtc/modules/audio_coding/neteq/normal_unittest.cc b/webrtc/modules/audio_coding/neteq/normal_unittest.cc
index 1ac32f4..f98e99a 100644
--- a/webrtc/modules/audio_coding/neteq/normal_unittest.cc
+++ b/webrtc/modules/audio_coding/neteq/normal_unittest.cc
@@ -12,10 +12,10 @@
#include "webrtc/modules/audio_coding/neteq/normal.h"
+#include <memory>
#include <vector>
#include "testing/gtest/include/gtest/gtest.h"
-#include "webrtc/base/scoped_ptr.h"
#include "webrtc/common_audio/signal_processing/include/signal_processing_library.h"
#include "webrtc/modules/audio_coding/neteq/audio_multi_vector.h"
#include "webrtc/modules/audio_coding/neteq/background_noise.h"
@@ -57,7 +57,7 @@
Normal normal(fs, &db, bgn, &expand);
int16_t input[1000] = {0};
- rtc::scoped_ptr<int16_t[]> mute_factor_array(new int16_t[channels]);
+ std::unique_ptr<int16_t[]> mute_factor_array(new int16_t[channels]);
for (size_t i = 0; i < channels; ++i) {
mute_factor_array[i] = 16384;
}
@@ -103,7 +103,7 @@
Normal normal(fs, &db, bgn, &expand);
int16_t input[1000] = {0};
- rtc::scoped_ptr<int16_t[]> mute_factor_array(new int16_t[channels]);
+ std::unique_ptr<int16_t[]> mute_factor_array(new int16_t[channels]);
for (size_t i = 0; i < channels; ++i) {
mute_factor_array[i] = 16384;
}
diff --git a/webrtc/modules/audio_coding/neteq/payload_splitter_unittest.cc b/webrtc/modules/audio_coding/neteq/payload_splitter_unittest.cc
index 07c4bac..a68e8d6 100644
--- a/webrtc/modules/audio_coding/neteq/payload_splitter_unittest.cc
+++ b/webrtc/modules/audio_coding/neteq/payload_splitter_unittest.cc
@@ -14,10 +14,10 @@
#include <assert.h>
+#include <memory>
#include <utility> // pair
#include "testing/gtest/include/gtest/gtest.h"
-#include "webrtc/base/scoped_ptr.h"
#include "webrtc/modules/audio_coding/neteq/mock/mock_decoder_database.h"
#include "webrtc/modules/audio_coding/neteq/packet.h"
@@ -371,32 +371,32 @@
// Tell the mock decoder database to return DecoderInfo structs with different
// codec types.
// Use scoped pointers to avoid having to delete them later.
- rtc::scoped_ptr<DecoderDatabase::DecoderInfo> info0(
+ std::unique_ptr<DecoderDatabase::DecoderInfo> info0(
new DecoderDatabase::DecoderInfo(NetEqDecoder::kDecoderISAC, 16000, NULL,
false));
EXPECT_CALL(decoder_database, GetDecoderInfo(0))
.WillRepeatedly(Return(info0.get()));
- rtc::scoped_ptr<DecoderDatabase::DecoderInfo> info1(
+ std::unique_ptr<DecoderDatabase::DecoderInfo> info1(
new DecoderDatabase::DecoderInfo(NetEqDecoder::kDecoderISACswb, 32000,
NULL, false));
EXPECT_CALL(decoder_database, GetDecoderInfo(1))
.WillRepeatedly(Return(info1.get()));
- rtc::scoped_ptr<DecoderDatabase::DecoderInfo> info2(
+ std::unique_ptr<DecoderDatabase::DecoderInfo> info2(
new DecoderDatabase::DecoderInfo(NetEqDecoder::kDecoderRED, 8000, NULL,
false));
EXPECT_CALL(decoder_database, GetDecoderInfo(2))
.WillRepeatedly(Return(info2.get()));
- rtc::scoped_ptr<DecoderDatabase::DecoderInfo> info3(
+ std::unique_ptr<DecoderDatabase::DecoderInfo> info3(
new DecoderDatabase::DecoderInfo(NetEqDecoder::kDecoderAVT, 8000, NULL,
false));
EXPECT_CALL(decoder_database, GetDecoderInfo(3))
.WillRepeatedly(Return(info3.get()));
- rtc::scoped_ptr<DecoderDatabase::DecoderInfo> info4(
+ std::unique_ptr<DecoderDatabase::DecoderInfo> info4(
new DecoderDatabase::DecoderInfo(NetEqDecoder::kDecoderCNGnb, 8000, NULL,
false));
EXPECT_CALL(decoder_database, GetDecoderInfo(4))
.WillRepeatedly(Return(info4.get()));
- rtc::scoped_ptr<DecoderDatabase::DecoderInfo> info5(
+ std::unique_ptr<DecoderDatabase::DecoderInfo> info5(
new DecoderDatabase::DecoderInfo(NetEqDecoder::kDecoderArbitrary, 8000,
NULL, false));
EXPECT_CALL(decoder_database, GetDecoderInfo(5))
@@ -535,7 +535,7 @@
// codec types.
// Use scoped pointers to avoid having to delete them later.
// (Sample rate is set to 8000 Hz, but does not matter.)
- rtc::scoped_ptr<DecoderDatabase::DecoderInfo> info(
+ std::unique_ptr<DecoderDatabase::DecoderInfo> info(
new DecoderDatabase::DecoderInfo(decoder_type_, 8000, NULL, false));
EXPECT_CALL(decoder_database, GetDecoderInfo(kPayloadType))
.WillRepeatedly(Return(info.get()));
@@ -622,7 +622,7 @@
// Tell the mock decoder database to return DecoderInfo structs with different
// codec types.
// Use scoped pointers to avoid having to delete them later.
- rtc::scoped_ptr<DecoderDatabase::DecoderInfo> info(
+ std::unique_ptr<DecoderDatabase::DecoderInfo> info(
new DecoderDatabase::DecoderInfo(NetEqDecoder::kDecoderILBC, 8000, NULL,
false));
EXPECT_CALL(decoder_database, GetDecoderInfo(kPayloadType))
@@ -686,7 +686,7 @@
packet_list.push_back(packet);
MockDecoderDatabase decoder_database;
- rtc::scoped_ptr<DecoderDatabase::DecoderInfo> info(
+ std::unique_ptr<DecoderDatabase::DecoderInfo> info(
new DecoderDatabase::DecoderInfo(NetEqDecoder::kDecoderILBC, 8000, NULL,
false));
EXPECT_CALL(decoder_database, GetDecoderInfo(kPayloadType))
@@ -718,7 +718,7 @@
packet_list.push_back(packet);
MockDecoderDatabase decoder_database;
- rtc::scoped_ptr<DecoderDatabase::DecoderInfo> info(
+ std::unique_ptr<DecoderDatabase::DecoderInfo> info(
new DecoderDatabase::DecoderInfo(NetEqDecoder::kDecoderILBC, 8000, NULL,
false));
EXPECT_CALL(decoder_database, GetDecoderInfo(kPayloadType))
diff --git a/webrtc/modules/audio_coding/neteq/test/audio_classifier_test.cc b/webrtc/modules/audio_coding/neteq/test/audio_classifier_test.cc
index a14238c..22de05a 100644
--- a/webrtc/modules/audio_coding/neteq/test/audio_classifier_test.cc
+++ b/webrtc/modules/audio_coding/neteq/test/audio_classifier_test.cc
@@ -15,10 +15,9 @@
#include <stdlib.h>
#include <string.h>
-#include <string>
#include <iostream>
-
-#include "webrtc/base/scoped_ptr.h"
+#include <memory>
+#include <string>
int main(int argc, char* argv[]) {
if (argc != 5) {
@@ -48,7 +47,7 @@
}
const int data_size = channels * kFrameSizeSamples;
- rtc::scoped_ptr<int16_t[]> in(new int16_t[data_size]);
+ std::unique_ptr<int16_t[]> in(new int16_t[data_size]);
std::string input_filename = argv[3];
std::string output_filename = argv[4];
diff --git a/webrtc/modules/audio_coding/neteq/test/neteq_ilbc_quality_test.cc b/webrtc/modules/audio_coding/neteq/test/neteq_ilbc_quality_test.cc
index 0c09e92..6d0fdb0 100644
--- a/webrtc/modules/audio_coding/neteq/test/neteq_ilbc_quality_test.cc
+++ b/webrtc/modules/audio_coding/neteq/test/neteq_ilbc_quality_test.cc
@@ -8,9 +8,10 @@
* be found in the AUTHORS file in the root of the source tree.
*/
+#include <memory>
+
#include "webrtc/base/checks.h"
#include "webrtc/base/safe_conversions.h"
-#include "webrtc/base/scoped_ptr.h"
#include "webrtc/modules/audio_coding/codecs/ilbc/audio_encoder_ilbc.h"
#include "webrtc/modules/audio_coding/neteq/tools/neteq_quality_test.h"
#include "webrtc/test/testsupport/fileutils.h"
@@ -76,7 +77,7 @@
}
private:
- rtc::scoped_ptr<AudioEncoderIlbc> encoder_;
+ std::unique_ptr<AudioEncoderIlbc> encoder_;
};
TEST_F(NetEqIlbcQualityTest, Test) {
diff --git a/webrtc/modules/audio_coding/neteq/test/neteq_pcmu_quality_test.cc b/webrtc/modules/audio_coding/neteq/test/neteq_pcmu_quality_test.cc
index ac478ab..cb3f483 100644
--- a/webrtc/modules/audio_coding/neteq/test/neteq_pcmu_quality_test.cc
+++ b/webrtc/modules/audio_coding/neteq/test/neteq_pcmu_quality_test.cc
@@ -8,9 +8,10 @@
* be found in the AUTHORS file in the root of the source tree.
*/
+#include <memory>
+
#include "webrtc/base/checks.h"
#include "webrtc/base/safe_conversions.h"
-#include "webrtc/base/scoped_ptr.h"
#include "webrtc/modules/audio_coding/codecs/g711/audio_encoder_pcm.h"
#include "webrtc/modules/audio_coding/neteq/tools/neteq_quality_test.h"
#include "webrtc/test/testsupport/fileutils.h"
@@ -76,7 +77,7 @@
}
private:
- rtc::scoped_ptr<AudioEncoderPcmU> encoder_;
+ std::unique_ptr<AudioEncoderPcmU> encoder_;
};
TEST_F(NetEqPcmuQualityTest, Test) {
diff --git a/webrtc/modules/audio_coding/neteq/time_stretch.cc b/webrtc/modules/audio_coding/neteq/time_stretch.cc
index 6ae81e6..6a91ea4 100644
--- a/webrtc/modules/audio_coding/neteq/time_stretch.cc
+++ b/webrtc/modules/audio_coding/neteq/time_stretch.cc
@@ -11,9 +11,9 @@
#include "webrtc/modules/audio_coding/neteq/time_stretch.h"
#include <algorithm> // min, max
+#include <memory>
#include "webrtc/base/safe_conversions.h"
-#include "webrtc/base/scoped_ptr.h"
#include "webrtc/common_audio/signal_processing/include/signal_processing_library.h"
#include "webrtc/modules/audio_coding/neteq/background_noise.h"
#include "webrtc/modules/audio_coding/neteq/dsp_helper.h"
@@ -30,7 +30,7 @@
static_cast<size_t>(fs_mult_ * 120); // Corresponds to 15 ms.
const int16_t* signal;
- rtc::scoped_ptr<int16_t[]> signal_array;
+ std::unique_ptr<int16_t[]> signal_array;
size_t signal_len;
if (num_channels_ == 1) {
signal = input;
diff --git a/webrtc/modules/audio_coding/neteq/time_stretch_unittest.cc b/webrtc/modules/audio_coding/neteq/time_stretch_unittest.cc
index 0769fd3..8a32d20 100644
--- a/webrtc/modules/audio_coding/neteq/time_stretch_unittest.cc
+++ b/webrtc/modules/audio_coding/neteq/time_stretch_unittest.cc
@@ -14,10 +14,10 @@
#include "webrtc/modules/audio_coding/neteq/preemptive_expand.h"
#include <map>
+#include <memory>
#include "testing/gtest/include/gtest/gtest.h"
#include "webrtc/base/checks.h"
-#include "webrtc/base/scoped_ptr.h"
#include "webrtc/common_audio/signal_processing/include/signal_processing_library.h"
#include "webrtc/modules/audio_coding/neteq/background_noise.h"
#include "webrtc/modules/audio_coding/neteq/tools/input_audio_file.h"
@@ -100,10 +100,10 @@
}
}
- rtc::scoped_ptr<test::InputAudioFile> input_file_;
+ std::unique_ptr<test::InputAudioFile> input_file_;
const int sample_rate_hz_;
const size_t block_size_;
- rtc::scoped_ptr<int16_t[]> audio_;
+ std::unique_ptr<int16_t[]> audio_;
std::map<TimeStretch::ReturnCodes, int> return_stats_;
BackgroundNoise background_noise_;
};
diff --git a/webrtc/modules/audio_coding/neteq/tools/audio_loop.h b/webrtc/modules/audio_coding/neteq/tools/audio_loop.h
index 14e20f6..40b2c55 100644
--- a/webrtc/modules/audio_coding/neteq/tools/audio_loop.h
+++ b/webrtc/modules/audio_coding/neteq/tools/audio_loop.h
@@ -11,11 +11,11 @@
#ifndef WEBRTC_MODULES_AUDIO_CODING_NETEQ_TOOLS_AUDIO_LOOP_H_
#define WEBRTC_MODULES_AUDIO_CODING_NETEQ_TOOLS_AUDIO_LOOP_H_
+#include <memory>
#include <string>
#include "webrtc/base/array_view.h"
#include "webrtc/base/constructormagic.h"
-#include "webrtc/base/scoped_ptr.h"
#include "webrtc/typedefs.h"
namespace webrtc {
@@ -49,7 +49,7 @@
size_t next_index_;
size_t loop_length_samples_;
size_t block_length_samples_;
- rtc::scoped_ptr<int16_t[]> audio_array_;
+ std::unique_ptr<int16_t[]> audio_array_;
RTC_DISALLOW_COPY_AND_ASSIGN(AudioLoop);
};
diff --git a/webrtc/modules/audio_coding/neteq/tools/neteq_external_decoder_test.h b/webrtc/modules/audio_coding/neteq/tools/neteq_external_decoder_test.h
index d7b01fe..1b36d8b 100644
--- a/webrtc/modules/audio_coding/neteq/tools/neteq_external_decoder_test.h
+++ b/webrtc/modules/audio_coding/neteq/tools/neteq_external_decoder_test.h
@@ -11,9 +11,9 @@
#ifndef WEBRTC_MODULES_AUDIO_CODING_NETEQ_TOOLS_NETEQ_EXTERNAL_DECODER_TEST_H_
#define WEBRTC_MODULES_AUDIO_CODING_NETEQ_TOOLS_NETEQ_EXTERNAL_DECODER_TEST_H_
+#include <memory>
#include <string>
-#include "webrtc/base/scoped_ptr.h"
#include "webrtc/modules/audio_coding/codecs/audio_decoder.h"
#include "webrtc/modules/audio_coding/neteq/include/neteq.h"
#include "webrtc/modules/include/module_common_types.h"
@@ -55,7 +55,7 @@
AudioDecoder* decoder_;
int sample_rate_hz_;
size_t channels_;
- rtc::scoped_ptr<NetEq> neteq_;
+ std::unique_ptr<NetEq> neteq_;
};
} // namespace test
diff --git a/webrtc/modules/audio_coding/neteq/tools/neteq_quality_test.h b/webrtc/modules/audio_coding/neteq/tools/neteq_quality_test.h
index c2b2eff..8bae160 100644
--- a/webrtc/modules/audio_coding/neteq/tools/neteq_quality_test.h
+++ b/webrtc/modules/audio_coding/neteq/tools/neteq_quality_test.h
@@ -12,9 +12,9 @@
#define WEBRTC_MODULES_AUDIO_CODING_NETEQ_TOOLS_NETEQ_QUALITY_TEST_H_
#include <fstream>
+#include <memory>
#include <gflags/gflags.h>
#include "testing/gtest/include/gtest/gtest.h"
-#include "webrtc/base/scoped_ptr.h"
#include "webrtc/modules/audio_coding/neteq/include/neteq.h"
#include "webrtc/modules/audio_coding/neteq/tools/audio_sink.h"
#include "webrtc/modules/audio_coding/neteq/tools/input_audio_file.h"
@@ -58,7 +58,7 @@
// Prob. of losing current packet, when previous packet is not lost.
double prob_trans_01_;
bool lost_last_;
- rtc::scoped_ptr<UniformLoss> uniform_loss_model_;
+ std::unique_ptr<UniformLoss> uniform_loss_model_;
};
class NetEqQualityTest : public ::testing::Test {
@@ -119,17 +119,17 @@
size_t payload_size_bytes_;
size_t max_payload_bytes_;
- rtc::scoped_ptr<InputAudioFile> in_file_;
- rtc::scoped_ptr<AudioSink> output_;
+ std::unique_ptr<InputAudioFile> in_file_;
+ std::unique_ptr<AudioSink> output_;
std::ofstream log_file_;
- rtc::scoped_ptr<RtpGenerator> rtp_generator_;
- rtc::scoped_ptr<NetEq> neteq_;
- rtc::scoped_ptr<LossModel> loss_model_;
+ std::unique_ptr<RtpGenerator> rtp_generator_;
+ std::unique_ptr<NetEq> neteq_;
+ std::unique_ptr<LossModel> loss_model_;
- rtc::scoped_ptr<int16_t[]> in_data_;
- rtc::scoped_ptr<uint8_t[]> payload_;
- rtc::scoped_ptr<int16_t[]> out_data_;
+ std::unique_ptr<int16_t[]> in_data_;
+ std::unique_ptr<uint8_t[]> payload_;
+ std::unique_ptr<int16_t[]> out_data_;
WebRtcRTPHeader rtp_header_;
size_t total_payload_size_bytes_;
diff --git a/webrtc/modules/audio_coding/neteq/tools/neteq_rtpplay.cc b/webrtc/modules/audio_coding/neteq/tools/neteq_rtpplay.cc
index 57005ae..1701c47 100644
--- a/webrtc/modules/audio_coding/neteq/tools/neteq_rtpplay.cc
+++ b/webrtc/modules/audio_coding/neteq/tools/neteq_rtpplay.cc
@@ -19,13 +19,13 @@
#include <algorithm>
#include <iostream>
+#include <memory>
#include <limits>
#include <string>
#include "gflags/gflags.h"
#include "webrtc/base/checks.h"
#include "webrtc/base/safe_conversions.h"
-#include "webrtc/base/scoped_ptr.h"
#include "webrtc/modules/audio_coding/codecs/pcm16b/pcm16b.h"
#include "webrtc/modules/audio_coding/neteq/include/neteq.h"
#include "webrtc/modules/audio_coding/neteq/tools/input_audio_file.h"
@@ -295,8 +295,8 @@
}
size_t ReplacePayload(webrtc::test::InputAudioFile* replacement_audio_file,
- rtc::scoped_ptr<int16_t[]>* replacement_audio,
- rtc::scoped_ptr<uint8_t[]>* payload,
+ std::unique_ptr<int16_t[]>* replacement_audio,
+ std::unique_ptr<uint8_t[]>* payload,
size_t* payload_mem_size_bytes,
size_t* frame_size_samples,
WebRtcRTPHeader* rtp_header,
@@ -411,7 +411,7 @@
printf("Input file: %s\n", argv[1]);
bool is_rtp_dump = false;
- rtc::scoped_ptr<webrtc::test::PacketSource> file_source;
+ std::unique_ptr<webrtc::test::PacketSource> file_source;
webrtc::test::RtcEventLogSource* event_log_source = nullptr;
if (webrtc::test::RtpFileSource::ValidRtpDump(argv[1]) ||
webrtc::test::RtpFileSource::ValidPcap(argv[1])) {
@@ -433,7 +433,7 @@
// Check if a replacement audio file was provided, and if so, open it.
bool replace_payload = false;
- rtc::scoped_ptr<webrtc::test::InputAudioFile> replacement_audio_file;
+ std::unique_ptr<webrtc::test::InputAudioFile> replacement_audio_file;
if (!FLAGS_replacement_audio_file.empty()) {
replacement_audio_file.reset(
new webrtc::test::InputAudioFile(FLAGS_replacement_audio_file));
@@ -441,7 +441,7 @@
}
// Read first packet.
- rtc::scoped_ptr<webrtc::test::Packet> packet(file_source->NextPacket());
+ std::unique_ptr<webrtc::test::Packet> packet(file_source->NextPacket());
if (!packet) {
printf(
"Warning: input file is empty, or the filters did not match any "
@@ -468,7 +468,7 @@
// for wav files.)
// Check output file type.
std::string output_file_name = argv[2];
- rtc::scoped_ptr<webrtc::test::AudioSink> output;
+ std::unique_ptr<webrtc::test::AudioSink> output;
if (output_file_name.size() >= 4 &&
output_file_name.substr(output_file_name.size() - 4) == ".wav") {
// Open a wav file.
@@ -495,11 +495,11 @@
// Set up variables for audio replacement if needed.
- rtc::scoped_ptr<webrtc::test::Packet> next_packet;
+ std::unique_ptr<webrtc::test::Packet> next_packet;
bool next_packet_available = false;
size_t input_frame_size_timestamps = 0;
- rtc::scoped_ptr<int16_t[]> replacement_audio;
- rtc::scoped_ptr<uint8_t[]> payload;
+ std::unique_ptr<int16_t[]> replacement_audio;
+ std::unique_ptr<uint8_t[]> payload;
size_t payload_mem_size_bytes = 0;
if (replace_payload) {
// Initially assume that the frame size is 30 ms at the initial sample rate.
diff --git a/webrtc/modules/audio_coding/neteq/tools/packet.cc b/webrtc/modules/audio_coding/neteq/tools/packet.cc
index 2b2fcc2..46fd0cb 100644
--- a/webrtc/modules/audio_coding/neteq/tools/packet.cc
+++ b/webrtc/modules/audio_coding/neteq/tools/packet.cc
@@ -12,6 +12,8 @@
#include <string.h>
+#include <memory>
+
#include "webrtc/modules/include/module_common_types.h"
#include "webrtc/modules/rtp_rtcp/include/rtp_header_parser.h"
@@ -55,7 +57,7 @@
virtual_packet_length_bytes_(allocated_bytes),
virtual_payload_length_bytes_(0),
time_ms_(time_ms) {
- rtc::scoped_ptr<RtpHeaderParser> parser(RtpHeaderParser::Create());
+ std::unique_ptr<RtpHeaderParser> parser(RtpHeaderParser::Create());
valid_header_ = ParseHeader(*parser);
}
@@ -70,7 +72,7 @@
virtual_packet_length_bytes_(virtual_packet_length_bytes),
virtual_payload_length_bytes_(0),
time_ms_(time_ms) {
- rtc::scoped_ptr<RtpHeaderParser> parser(RtpHeaderParser::Create());
+ std::unique_ptr<RtpHeaderParser> parser(RtpHeaderParser::Create());
valid_header_ = ParseHeader(*parser);
}
diff --git a/webrtc/modules/audio_coding/neteq/tools/packet.h b/webrtc/modules/audio_coding/neteq/tools/packet.h
index 8e43633..86eedc0 100644
--- a/webrtc/modules/audio_coding/neteq/tools/packet.h
+++ b/webrtc/modules/audio_coding/neteq/tools/packet.h
@@ -12,9 +12,9 @@
#define WEBRTC_MODULES_AUDIO_CODING_NETEQ_TOOLS_PACKET_H_
#include <list>
+#include <memory>
#include "webrtc/base/constructormagic.h"
-#include "webrtc/base/scoped_ptr.h"
#include "webrtc/common_types.h"
#include "webrtc/typedefs.h"
@@ -103,7 +103,7 @@
void CopyToHeader(RTPHeader* destination) const;
RTPHeader header_;
- rtc::scoped_ptr<uint8_t[]> payload_memory_;
+ std::unique_ptr<uint8_t[]> payload_memory_;
const uint8_t* payload_; // First byte after header.
const size_t packet_length_bytes_; // Total length of packet.
size_t payload_length_bytes_; // Length of the payload, after RTP header.
diff --git a/webrtc/modules/audio_coding/neteq/tools/resample_input_audio_file.cc b/webrtc/modules/audio_coding/neteq/tools/resample_input_audio_file.cc
index 7a0bb1a..f5fe166 100644
--- a/webrtc/modules/audio_coding/neteq/tools/resample_input_audio_file.cc
+++ b/webrtc/modules/audio_coding/neteq/tools/resample_input_audio_file.cc
@@ -10,8 +10,9 @@
#include "webrtc/modules/audio_coding/neteq/tools/resample_input_audio_file.h"
+#include <memory>
+
#include "webrtc/base/checks.h"
-#include "webrtc/base/scoped_ptr.h"
namespace webrtc {
namespace test {
@@ -22,7 +23,7 @@
const size_t samples_to_read = samples * file_rate_hz_ / output_rate_hz;
RTC_CHECK_EQ(samples_to_read * output_rate_hz, samples * file_rate_hz_)
<< "Frame size and sample rates don't add up to an integer.";
- rtc::scoped_ptr<int16_t[]> temp_destination(new int16_t[samples_to_read]);
+ std::unique_ptr<int16_t[]> temp_destination(new int16_t[samples_to_read]);
if (!InputAudioFile::Read(samples_to_read, temp_destination.get()))
return false;
resampler_.ResetIfNeeded(file_rate_hz_, output_rate_hz, 1);
diff --git a/webrtc/modules/audio_coding/neteq/tools/rtc_event_log_source.h b/webrtc/modules/audio_coding/neteq/tools/rtc_event_log_source.h
index 90d5931..312338e 100644
--- a/webrtc/modules/audio_coding/neteq/tools/rtc_event_log_source.h
+++ b/webrtc/modules/audio_coding/neteq/tools/rtc_event_log_source.h
@@ -11,10 +11,10 @@
#ifndef WEBRTC_MODULES_AUDIO_CODING_NETEQ_TOOLS_RTC_EVENT_LOG_SOURCE_H_
#define WEBRTC_MODULES_AUDIO_CODING_NETEQ_TOOLS_RTC_EVENT_LOG_SOURCE_H_
+#include <memory>
#include <string>
#include "webrtc/base/constructormagic.h"
-#include "webrtc/base/scoped_ptr.h"
#include "webrtc/modules/audio_coding/neteq/tools/packet_source.h"
#include "webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h"
@@ -58,8 +58,8 @@
int rtp_packet_index_ = 0;
int audio_output_index_ = 0;
- rtc::scoped_ptr<rtclog::EventStream> event_log_;
- rtc::scoped_ptr<RtpHeaderParser> parser_;
+ std::unique_ptr<rtclog::EventStream> event_log_;
+ std::unique_ptr<RtpHeaderParser> parser_;
RTC_DISALLOW_COPY_AND_ASSIGN(RtcEventLogSource);
};
diff --git a/webrtc/modules/audio_coding/neteq/tools/rtp_analyze.cc b/webrtc/modules/audio_coding/neteq/tools/rtp_analyze.cc
index faabdc2..0735b4c 100644
--- a/webrtc/modules/audio_coding/neteq/tools/rtp_analyze.cc
+++ b/webrtc/modules/audio_coding/neteq/tools/rtp_analyze.cc
@@ -10,10 +10,11 @@
#include <assert.h>
#include <stdio.h>
+
+#include <memory>
#include <vector>
#include "gflags/gflags.h"
-#include "webrtc/base/scoped_ptr.h"
#include "webrtc/modules/audio_coding/neteq/tools/packet.h"
#include "webrtc/modules/audio_coding/neteq/tools/rtp_file_source.h"
@@ -63,7 +64,7 @@
}
printf("Input file: %s\n", argv[1]);
- rtc::scoped_ptr<webrtc::test::RtpFileSource> file_source(
+ std::unique_ptr<webrtc::test::RtpFileSource> file_source(
webrtc::test::RtpFileSource::Create(argv[1]));
assert(file_source.get());
// Set RTP extension IDs.
@@ -104,7 +105,7 @@
uint32_t max_abs_send_time = 0;
int cycles = -1;
- rtc::scoped_ptr<webrtc::test::Packet> packet;
+ std::unique_ptr<webrtc::test::Packet> packet;
while (true) {
packet.reset(file_source->NextPacket());
if (!packet.get()) {
diff --git a/webrtc/modules/audio_coding/neteq/tools/rtp_file_source.cc b/webrtc/modules/audio_coding/neteq/tools/rtp_file_source.cc
index b7a3109..039e1fa 100644
--- a/webrtc/modules/audio_coding/neteq/tools/rtp_file_source.cc
+++ b/webrtc/modules/audio_coding/neteq/tools/rtp_file_source.cc
@@ -18,6 +18,8 @@
#include <netinet/in.h>
#endif
+#include <memory>
+
#include "webrtc/base/checks.h"
#include "webrtc/modules/audio_coding/neteq/tools/packet.h"
#include "webrtc/modules/rtp_rtcp/include/rtp_header_parser.h"
@@ -33,13 +35,13 @@
}
bool RtpFileSource::ValidRtpDump(const std::string& file_name) {
- rtc::scoped_ptr<RtpFileReader> temp_file(
+ std::unique_ptr<RtpFileReader> temp_file(
RtpFileReader::Create(RtpFileReader::kRtpDump, file_name));
return !!temp_file;
}
bool RtpFileSource::ValidPcap(const std::string& file_name) {
- rtc::scoped_ptr<RtpFileReader> temp_file(
+ std::unique_ptr<RtpFileReader> temp_file(
RtpFileReader::Create(RtpFileReader::kPcap, file_name));
return !!temp_file;
}
@@ -64,9 +66,9 @@
// Read the next one.
continue;
}
- rtc::scoped_ptr<uint8_t[]> packet_memory(new uint8_t[temp_packet.length]);
+ std::unique_ptr<uint8_t[]> packet_memory(new uint8_t[temp_packet.length]);
memcpy(packet_memory.get(), temp_packet.data, temp_packet.length);
- rtc::scoped_ptr<Packet> packet(new Packet(
+ std::unique_ptr<Packet> packet(new Packet(
packet_memory.release(), temp_packet.length,
temp_packet.original_length, temp_packet.time_ms, *parser_.get()));
if (!packet->valid_header()) {
diff --git a/webrtc/modules/audio_coding/neteq/tools/rtp_file_source.h b/webrtc/modules/audio_coding/neteq/tools/rtp_file_source.h
index 2febf68..b02e16a 100644
--- a/webrtc/modules/audio_coding/neteq/tools/rtp_file_source.h
+++ b/webrtc/modules/audio_coding/neteq/tools/rtp_file_source.h
@@ -12,10 +12,11 @@
#define WEBRTC_MODULES_AUDIO_CODING_NETEQ_TOOLS_RTP_FILE_SOURCE_H_
#include <stdio.h>
+
+#include <memory>
#include <string>
#include "webrtc/base/constructormagic.h"
-#include "webrtc/base/scoped_ptr.h"
#include "webrtc/common_types.h"
#include "webrtc/modules/audio_coding/neteq/tools/packet_source.h"
#include "webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h"
@@ -56,8 +57,8 @@
bool OpenFile(const std::string& file_name);
- rtc::scoped_ptr<RtpFileReader> rtp_reader_;
- rtc::scoped_ptr<RtpHeaderParser> parser_;
+ std::unique_ptr<RtpFileReader> rtp_reader_;
+ std::unique_ptr<RtpHeaderParser> parser_;
RTC_DISALLOW_COPY_AND_ASSIGN(RtpFileSource);
};
diff --git a/webrtc/modules/audio_coding/neteq/tools/rtpcat.cc b/webrtc/modules/audio_coding/neteq/tools/rtpcat.cc
index f2b87a5..e1f49f7 100644
--- a/webrtc/modules/audio_coding/neteq/tools/rtpcat.cc
+++ b/webrtc/modules/audio_coding/neteq/tools/rtpcat.cc
@@ -10,12 +10,12 @@
#include <stdio.h>
+#include <memory>
+
#include "webrtc/base/checks.h"
-#include "webrtc/base/scoped_ptr.h"
#include "webrtc/test/rtp_file_reader.h"
#include "webrtc/test/rtp_file_writer.h"
-using rtc::scoped_ptr;
using webrtc::test::RtpFileReader;
using webrtc::test::RtpFileWriter;
@@ -26,13 +26,13 @@
exit(1);
}
- scoped_ptr<RtpFileWriter> output(
+ std::unique_ptr<RtpFileWriter> output(
RtpFileWriter::Create(RtpFileWriter::kRtpDump, argv[argc - 1]));
RTC_CHECK(output.get() != NULL) << "Cannot open output file.";
printf("Output RTP file: %s\n", argv[argc - 1]);
for (int i = 1; i < argc - 1; i++) {
- scoped_ptr<RtpFileReader> input(
+ std::unique_ptr<RtpFileReader> input(
RtpFileReader::Create(RtpFileReader::kRtpDump, argv[i]));
RTC_CHECK(input.get() != NULL) << "Cannot open input file " << argv[i];
printf("Input RTP file: %s\n", argv[i]);