| commit | 2bfa7672456357808005d712724b092088c37470 | [log] [tgz] |
|---|---|---|
| author | Alessio Bazzica <alessiob@webrtc.org> | Fri Dec 09 14:16:30 2022 +0100 |
| committer | WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Dec 09 15:02:20 2022 +0000 |
| tree | 840c189bf330800325116ece46d29a11c0864f7a | |
| parent | dfba28e30eaa791147c98e34ef0476e99eb93f5e [diff] [blame] |
Fix APM AGC2 initialization: pass the correct number of channels Pass the correct number of channels needed by the AGC2 input volume controller. This change doesn't affect the adaptive digital controller which reads the number of channel from the passed audio buffer instance for each processed frame. Note that the `AdaptiveDigitalGainController::Initialize()` impl was removed in [1], but that CL didn't remove the declaration (done in this CL). [1] https://webrtc-review.googlesource.com/c/src/+/287222/5/modules/audio_processing/agc2/adaptive_digital_gain_controller.cc#105 Bug: webrtc:7494 Change-Id: I07369ab4025a251b25c716cf618e4222fdb60fc8 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/287320 Reviewed-by: Hanna Silen <silen@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/main@{#38863}
diff --git a/modules/audio_processing/audio_processing_impl_unittest.cc b/modules/audio_processing/audio_processing_impl_unittest.cc index 10c11a2..65bda71 100644 --- a/modules/audio_processing/audio_processing_impl_unittest.cc +++ b/modules/audio_processing/audio_processing_impl_unittest.cc
@@ -1007,6 +1007,8 @@ EXPECT_FALSE(apm->GetConfig().transient_suppression.enabled); } +// TODO(bugs.webrtc.org/7494): Test AGCs with different multi-channel configs. + // Tests that the minimum startup volume is applied at the startup. TEST_P(InputVolumeStartupParameterizedTest, VerifyStartupMinVolumeAppliedAtStartup) {