commit 2ab97f6f8e27b47c0d9beeb8b6ca5387bda9f55c
author Mirko Bonadei <mbonadei@webrtc.org> Thu Jul 18 13:44:12 2019 +0200
committer Commit Bot <commit-bot@chromium.org> Fri Jul 19 06:54:04 2019 +0000
tree 99f28cebc1c975b9c863980b51fe30d2cf878071
parent 63741c7fa1aa55a38af11ac8cc04498722f9407d

Migrate WebRTC test infra to ABSL_FLAG.

This is the last CL required to migrate WebRTC to ABSL_FLAG, rtc::Flag
will be removed soon after this one lands.

Bug: webrtc:10616
Change-Id: I2807cec39e28a2737d2c49e2dc23f2a6f98d08f0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145727
Reviewed-by: Tommi <tommi@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28606}

call/rampup_tests.cc

diff --git a/call/rampup_tests.cc b/call/rampup_tests.cc
index 914160e..0fc3627 100644
--- a/call/rampup_tests.cc
+++ b/call/rampup_tests.cc
@@ -12,6 +12,7 @@
 
 #include <memory>
 
+#include "absl/flags/flag.h"
 #include "absl/memory/memory.h"
 #include "api/rtc_event_log/rtc_event_log_factory.h"
 #include "api/rtc_event_log_output_file.h"
@@ -19,7 +20,6 @@
 #include "api/task_queue/task_queue_factory.h"
 #include "call/fake_network_pipe.h"
 #include "rtc_base/checks.h"
-#include "rtc_base/flags.h"
 #include "rtc_base/logging.h"
 #include "rtc_base/platform_thread.h"
 #include "rtc_base/string_encode.h"
@@ -28,6 +28,11 @@
 #include "test/gtest.h"
 #include "test/testsupport/perf_test.h"
 
+ABSL_FLAG(std::string,
+          ramp_dump_name,
+          "",
+          "Filename for dumped received RTP stream.");
+
 namespace webrtc {
 namespace {
 
@@ -47,10 +52,6 @@
 }
 }  // namespace
 
-WEBRTC_DEFINE_string(ramp_dump_name,
-                     "",
-                     "Filename for dumped received RTP stream.");
-
 RampUpTester::RampUpTester(size_t num_video_streams,
                            size_t num_audio_streams,
                            size_t num_flexfec_streams,
@@ -583,7 +584,7 @@
   RampUpTest()
       : task_queue_factory_(CreateDefaultTaskQueueFactory()),
         rtc_event_log_factory_(task_queue_factory_.get()) {
-    std::string dump_name(FLAG_ramp_dump_name);
+    std::string dump_name(absl::GetFlag(FLAGS_ramp_dump_name));
     if (!dump_name.empty()) {
       send_event_log_ = rtc_event_log_factory_.CreateRtcEventLog(
           RtcEventLog::EncodingType::Legacy);