commit 28dbf972428131bff700015bba597720f3e09013
author Peter Hanspers <peterhanspers@webrtc.org> Thu Feb 01 13:33:18 2018 +0100
committer Commit Bot <commit-bot@chromium.org> Thu Feb 01 14:05:14 2018 +0000
tree 22a846ed2fa1ff361bfe0b597d2bd3b83102cca0
parent 56fa0501257da6facaf8540bf50e52f775b89a6c

Fixing warnings in public iOS SDK headers.
Building with the newly published cocoapod generated a few warnings,
which looked a bit bad.

Bug: webrtc:8831
Change-Id: I70c06930603b328e4d11c599a5b5dd77b45150c6
Reviewed-on: https://webrtc-review.googlesource.com/46163
Reviewed-by: Anders Carlsson <andersc@webrtc.org>
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Commit-Queue: Peter Hanspers <peterhanspers@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21846}

sdk/objc/Framework/Classes/PeerConnection/RTCCameraVideoCapturer.m

diff --git a/sdk/objc/Framework/Classes/PeerConnection/RTCCameraVideoCapturer.m b/sdk/objc/Framework/Classes/PeerConnection/RTCCameraVideoCapturer.m
index a7d1ec1..c4ee1f2 100644
--- a/sdk/objc/Framework/Classes/PeerConnection/RTCCameraVideoCapturer.m
+++ b/sdk/objc/Framework/Classes/PeerConnection/RTCCameraVideoCapturer.m
@@ -168,7 +168,7 @@
                     }];
 }
 
-- (void)stopCaptureWithCompletionHandler:(nullable void (^)())completionHandler {
+- (void)stopCaptureWithCompletionHandler:(nullable void (^)(void))completionHandler {
   _willBeRunning = NO;
   [RTCDispatcher
       dispatchAsyncOnType:RTCDispatcherTypeCaptureSession

sdk/objc/Framework/Classes/PeerConnection/RTCMetrics.mm

diff --git a/sdk/objc/Framework/Classes/PeerConnection/RTCMetrics.mm b/sdk/objc/Framework/Classes/PeerConnection/RTCMetrics.mm
index 279a2be..2e80216 100644
--- a/sdk/objc/Framework/Classes/PeerConnection/RTCMetrics.mm
+++ b/sdk/objc/Framework/Classes/PeerConnection/RTCMetrics.mm
@@ -12,11 +12,11 @@
 
 #import "RTCMetricsSampleInfo+Private.h"
 
-void RTCEnableMetrics() {
+void RTCEnableMetrics(void) {
   webrtc::metrics::Enable();
 }
 
-NSArray<RTCMetricsSampleInfo *> *RTCGetAndResetMetrics() {
+NSArray<RTCMetricsSampleInfo *> *RTCGetAndResetMetrics(void) {
   std::map<std::string, std::unique_ptr<webrtc::metrics::SampleInfo>>
       histograms;
   webrtc::metrics::GetAndReset(&histograms);

sdk/objc/Framework/Classes/PeerConnection/RTCSSLAdapter.mm

diff --git a/sdk/objc/Framework/Classes/PeerConnection/RTCSSLAdapter.mm b/sdk/objc/Framework/Classes/PeerConnection/RTCSSLAdapter.mm
index a64ff49..dfe54b5 100644
--- a/sdk/objc/Framework/Classes/PeerConnection/RTCSSLAdapter.mm
+++ b/sdk/objc/Framework/Classes/PeerConnection/RTCSSLAdapter.mm
@@ -13,13 +13,13 @@
 #include "rtc_base/checks.h"
 #include "rtc_base/ssladapter.h"
 
-BOOL RTCInitializeSSL() {
+BOOL RTCInitializeSSL(void) {
   BOOL initialized = rtc::InitializeSSL();
   RTC_DCHECK(initialized);
   return initialized;
 }
 
-BOOL RTCCleanupSSL() {
+BOOL RTCCleanupSSL(void) {
   BOOL cleanedUp = rtc::CleanupSSL();
   RTC_DCHECK(cleanedUp);
   return cleanedUp;

sdk/objc/Framework/Classes/PeerConnection/RTCTracing.mm

diff --git a/sdk/objc/Framework/Classes/PeerConnection/RTCTracing.mm b/sdk/objc/Framework/Classes/PeerConnection/RTCTracing.mm
index f29c161..7bcd649 100644
--- a/sdk/objc/Framework/Classes/PeerConnection/RTCTracing.mm
+++ b/sdk/objc/Framework/Classes/PeerConnection/RTCTracing.mm
@@ -12,7 +12,7 @@
 
 #include "rtc_base/event_tracer.h"
 
-void RTCSetupInternalTracer() {
+void RTCSetupInternalTracer(void) {
   rtc::tracing::SetupInternalTracer();
 }
 
@@ -20,10 +20,10 @@
   return rtc::tracing::StartInternalCapture(filePath.UTF8String);
 }
 
-void RTCStopInternalCapture() {
+void RTCStopInternalCapture(void) {
   rtc::tracing::StopInternalCapture();
 }
 
-void RTCShutdownInternalTracer() {
+void RTCShutdownInternalTracer(void) {
   rtc::tracing::ShutdownInternalTracer();
 }