commit 27e8a095bf2d542c60a1402b87aaeccebbb28ec4
author Henrik Boström <hbos@webrtc.org> Mon Jan 24 17:12:35 2022 +0100
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Jan 24 17:56:50 2022 +0000
tree 55584264abad8d3e5532a1de97b87a8b76a23e08
parent 6f542d5e92e7b15abdbb6cdcfff7b5d145141153

Add ability to specify delayed task precision in RepeatingTaskHandle.

See go/postdelayedtask-precision-in-webrtc for context of which use
cases are considered "high" or "low". Most use cases are "low" which
is the default, but this CL allows opting in to "high".

Will be used by FrameBuffer2.

Bug: webrtc:13604
Change-Id: Iebf6eea44779873e78746da749a39e1101b92819
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/248861
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35776}

rtc_base/task_utils/repeating_task.h

diff --git a/rtc_base/task_utils/repeating_task.h b/rtc_base/task_utils/repeating_task.h
index 4c9983c..20f28d5 100644
--- a/rtc_base/task_utils/repeating_task.h
+++ b/rtc_base/task_utils/repeating_task.h
@@ -34,6 +34,7 @@
 class RepeatingTaskBase : public QueuedTask {
  public:
   RepeatingTaskBase(TaskQueueBase* task_queue,
+                    TaskQueueBase::DelayPrecision precision,
                     TimeDelta first_delay,
                     Clock* clock,
                     rtc::scoped_refptr<PendingTaskSafetyFlag> alive_flag);
@@ -45,6 +46,7 @@
   bool Run() final;
 
   TaskQueueBase* const task_queue_;
+  const TaskQueueBase::DelayPrecision precision_;
   Clock* const clock_;
   // This is always finite.
   Timestamp next_run_time_ RTC_GUARDED_BY(task_queue_);
@@ -60,11 +62,13 @@
 class RepeatingTaskImpl final : public RepeatingTaskBase {
  public:
   RepeatingTaskImpl(TaskQueueBase* task_queue,
+                    TaskQueueBase::DelayPrecision precision,
                     TimeDelta first_delay,
                     Closure&& closure,
                     Clock* clock,
                     rtc::scoped_refptr<PendingTaskSafetyFlag> alive_flag)
       : RepeatingTaskBase(task_queue,
+                          precision,
                           first_delay,
                           clock,
                           std::move(alive_flag)),
@@ -106,17 +110,20 @@
   // owned by the TaskQueue and will live until it has been stopped or the
   // TaskQueue deletes it. It's perfectly fine to destroy the handle while the
   // task is running, since the repeated task is owned by the TaskQueue.
+  // The tasks are scheduled onto the task queue using the specified precision.
   template <class Closure>
   static RepeatingTaskHandle Start(TaskQueueBase* task_queue,
                                    Closure&& closure,
+                                   TaskQueueBase::DelayPrecision precision =
+                                       TaskQueueBase::DelayPrecision::kLow,
                                    Clock* clock = Clock::GetRealTimeClock()) {
     auto alive_flag = PendingTaskSafetyFlag::CreateDetached();
     webrtc_repeating_task_impl::RepeatingTaskHandleDTraceProbeStart();
     task_queue->PostTask(
         std::make_unique<
             webrtc_repeating_task_impl::RepeatingTaskImpl<Closure>>(
-            task_queue, TimeDelta::Zero(), std::forward<Closure>(closure),
-            clock, alive_flag));
+            task_queue, precision, TimeDelta::Zero(),
+            std::forward<Closure>(closure), clock, alive_flag));
     return RepeatingTaskHandle(std::move(alive_flag));
   }
 
@@ -127,14 +134,17 @@
       TaskQueueBase* task_queue,
       TimeDelta first_delay,
       Closure&& closure,
+      TaskQueueBase::DelayPrecision precision =
+          TaskQueueBase::DelayPrecision::kLow,
       Clock* clock = Clock::GetRealTimeClock()) {
     auto alive_flag = PendingTaskSafetyFlag::CreateDetached();
     webrtc_repeating_task_impl::RepeatingTaskHandleDTraceProbeDelayedStart();
-    task_queue->PostDelayedTask(
+    task_queue->PostDelayedTaskWithPrecision(
+        precision,
         std::make_unique<
             webrtc_repeating_task_impl::RepeatingTaskImpl<Closure>>(
-            task_queue, first_delay, std::forward<Closure>(closure), clock,
-            alive_flag),
+            task_queue, precision, first_delay, std::forward<Closure>(closure),
+            clock, alive_flag),
         first_delay.ms());
     return RepeatingTaskHandle(std::move(alive_flag));
   }