commit 27af5db5e08034ac8432bfa263edec29afe471cc
author Yura Yaroshevich <yura.yaroshevich@gmail.com> Tue Apr 10 19:43:20 2018 +0300
committer Commit Bot <commit-bot@chromium.org> Wed Apr 11 14:21:46 2018 +0000
tree a5f601705f90582da4b300f39d952000fbcd9e4c
parent 6557d0c231ac28c5b80e9e09e118478a496dd59b

Log video toolbox error codes

Log OSStatus returned by VideoToolbox to simplify debugging.

Bug: webrtc:9134
Change-Id: Ib9e4f208a823d4be58324dd1f9dde833cba8afbe
Reviewed-on: https://webrtc-review.googlesource.com/69080
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Commit-Queue: Kári Helgason <kthelgason@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22823}

sdk/objc/Framework/Classes/VideoToolbox/RTCVideoDecoderH264.mm

diff --git a/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoDecoderH264.mm b/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoDecoderH264.mm
index 8460228..859bf03 100644
--- a/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoDecoderH264.mm
+++ b/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoDecoderH264.mm
@@ -242,6 +242,7 @@
       nullptr, _videoFormat, nullptr, attributes, &record, &_decompressionSession);
   CFRelease(attributes);
   if (status != noErr) {
+    RTC_LOG(LS_ERROR) << "Failed to create decompression session: " << status;
     [self destroyDecompressionSession];
     return WEBRTC_VIDEO_CODEC_ERROR;
   }

sdk/objc/Framework/Classes/VideoToolbox/RTCVideoEncoderH264.mm

diff --git a/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoEncoderH264.mm b/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoEncoderH264.mm
index 792dad5..39620d2 100644
--- a/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoEncoderH264.mm
+++ b/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoEncoderH264.mm
@@ -678,7 +678,7 @@
       CFRelease(dataRateLimits);
     }
     if (status != noErr) {
-      RTC_LOG(LS_ERROR) << "Failed to set data rate limit";
+      RTC_LOG(LS_ERROR) << "Failed to set data rate limit with code: " << status;
     }
 
     _encoderBitrateBps = bitrateBps;
@@ -695,7 +695,7 @@
               timestamp:(uint32_t)timestamp
                rotation:(RTCVideoRotation)rotation {
   if (status != noErr) {
-    RTC_LOG(LS_ERROR) << "H264 encode failed.";
+    RTC_LOG(LS_ERROR) << "H264 encode failed with code: " << status;
     return;
   }
   if (infoFlags & kVTEncodeInfo_FrameDropped) {