RTCError as return type for PeerConnectionInterface::SetConfiguration
Bug: None
Change-Id: I6dd7378ceac617e29945d72906cb8e2e0bd49538
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149166
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28910}
diff --git a/api/peer_connection_interface.h b/api/peer_connection_interface.h
index 7c35406..c6f68da 100644
--- a/api/peer_connection_interface.h
+++ b/api/peer_connection_interface.h
@@ -996,15 +996,15 @@
// - INVALID_PARAMETER if a TURN server is missing |username| or |password|.
// - INTERNAL_ERROR if an unexpected error occurred.
//
- // TODO(deadbeef): Make this pure virtual once all Chrome subclasses of
- // PeerConnectionInterface implement it.
+ // TODO(nisse): Deprecated, migrate to the method with an RTCError return
+ // value, then delete this one.
virtual bool SetConfiguration(
const PeerConnectionInterface::RTCConfiguration& config,
RTCError* error);
- // Version without error output param for backwards compatibility.
- // TODO(deadbeef): Remove once chromium is updated.
- virtual bool SetConfiguration(
+ // TODO(nisse): Make this pure virtual once all Chrome subclasses of
+ // PeerConnectionInterface implement it.
+ virtual RTCError SetConfiguration(
const PeerConnectionInterface::RTCConfiguration& config);
// Provides a remote candidate to the ICE Agent.
@@ -1100,7 +1100,7 @@
virtual bool StartRtcEventLog(std::unique_ptr<RtcEventLogOutput> output);
// Stops logging the RtcEventLog.
- // TODO(ivoc): Make this pure virtual when Chrome is updated.
+ // TODO(ivoc): Make this pure virtual when Chrome is updat ed.
virtual void StopRtcEventLog() {}
// Terminates all media, closes the transports, and in general releases any