commit 207a75d8f3fae1dc47aa20dda0636e88f6b8d2b3
author Emircan Uysaler <emircan@webrtc.org> Mon Mar 12 14:12:14 2018 -0700
committer Commit Bot <commit-bot@chromium.org> Mon Mar 12 21:43:21 2018 +0000
tree e8d959890bfb9c8dbb660af1b3969031a2d7898a
parent 9599fd44144f34022ea85d2b5201ea25255af6e4

Remove unused FrameGeneratorCapturer::Create signature

Bug: webrtc:7671
Change-Id: I4102d963d5d6867d35172b97c5b3ffff1f00231a
Reviewed-on: https://webrtc-review.googlesource.com/61342
Commit-Queue: Emircan Uysaler <emircan@webrtc.org>
Reviewed-by: Niklas Enbom <niklas.enbom@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22393}

test/frame_generator.h

diff --git a/test/frame_generator.h b/test/frame_generator.h
index d12072a..5728cfa 100644
--- a/test/frame_generator.h
+++ b/test/frame_generator.h
@@ -59,8 +59,11 @@
   }
 
   enum class OutputType { I420, I420A };
+
   // Creates a frame generator that produces frames with small squares that
   // move randomly towards the lower right corner.
+  // |type| has the default value OutputType::I420. |num_squares| has the
+  // default value 10.
   static std::unique_ptr<FrameGenerator> CreateSquareGenerator(
       int width,
       int height,

test/frame_generator_capturer.cc

diff --git a/test/frame_generator_capturer.cc b/test/frame_generator_capturer.cc
index cf0fd28..a9e80d7 100644
--- a/test/frame_generator_capturer.cc
+++ b/test/frame_generator_capturer.cc
@@ -101,14 +101,6 @@
   return capturer.release();
 }
 
-FrameGeneratorCapturer* FrameGeneratorCapturer::Create(int width,
-                                                       int height,
-                                                       int num_squares,
-                                                       int target_fps,
-                                                       Clock* clock) {
-  return Create(width, height, rtc::nullopt, num_squares, target_fps, clock);
-}
-
 FrameGeneratorCapturer* FrameGeneratorCapturer::CreateFromYuvFile(
     const std::string& file_name,
     size_t width,

test/frame_generator_capturer.h

diff --git a/test/frame_generator_capturer.h b/test/frame_generator_capturer.h
index 7d478a8..6213c09 100644
--- a/test/frame_generator_capturer.h
+++ b/test/frame_generator_capturer.h
@@ -41,6 +41,8 @@
     virtual ~SinkWantsObserver() {}
   };
 
+  // |type| has the default value OutputType::I420. |num_squares| has the
+  // default value 10.
   static FrameGeneratorCapturer* Create(
       int width,
       int height,
@@ -49,14 +51,6 @@
       int target_fps,
       Clock* clock);
 
-  // TODO(emircan): Update all clients and delete this function in favor of the
-  // above Create() signature.
-  static FrameGeneratorCapturer* Create(int width,
-                                        int height,
-                                        int num_squares,
-                                        int target_fps,
-                                        Clock* clock);
-
   static FrameGeneratorCapturer* CreateFromYuvFile(const std::string& file_name,
                                                    size_t width,
                                                    size_t height,