Close data channels when ID assignment fails.
This prevents crashes due to unassigned IDs.
Bug: chromium:945256
Change-Id: I63f3a17cc7dff07dab58a6bc59fe3606b23e8e18
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/129902
Reviewed-by: Seth Hampson <shampson@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27349}diff --git a/pc/data_channel.h b/pc/data_channel.h
index fa5c0f5..eef1279 100644
--- a/pc/data_channel.h
+++ b/pc/data_channel.h
@@ -147,6 +147,13 @@
virtual uint64_t bytes_received() const { return bytes_received_; }
virtual bool Send(const DataBuffer& buffer);
+ // Close immediately, ignoring any queued data or closing procedure.
+ // This is called for RTP data channels when SDP indicates a channel should
+ // be removed, or SCTP data channels when the underlying SctpTransport is
+ // being destroyed.
+ // It is also called by the PeerConnection if SCTP ID assignment fails.
+ void CloseAbruptly();
+
// Called when the channel's ready to use. That can happen when the
// underlying DataMediaChannel becomes ready, or when this channel is a new
// stream on an existing DataMediaChannel, and we've finished negotiation.
@@ -242,11 +249,6 @@
};
bool Init(const InternalDataChannelInit& config);
- // Close immediately, ignoring any queued data or closing procedure.
- // This is called for RTP data channels when SDP indicates a channel should
- // be removed, or SCTP data channels when the underlying SctpTransport is
- // being destroyed.
- void CloseAbruptly();
void UpdateState();
void SetState(DataState state);
void DisconnectFromProvider();