commit 1f206b841eb98d63a0a9e47b1f76ea59933d25b5
author Harald Alvestrand <hta@webrtc.org> Wed Feb 01 11:12:46 2023 +0000
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Feb 01 12:19:03 2023 +0000
tree d4274838b0dee628719712fb0afef3590a28e194
parent 16a8792e0a5b81a2c5837e3745bbc3369376b431

Use ArrayView in the IncomingRtcpPacket function.

The lowest level and some of the highest levels of this function are
already using ArrayView. Make this consistent throughout.
Use deprecation for the old API rather than deleting it, since upstream
may be using it.

Bug: webrtc:14870
Change-Id: If5e1a6e9802ecf7e8e3ec27befb5167ca9985517
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/291706
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Evan Shrubsole <eshr@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39241}

modules/rtp_rtcp/source/rtp_rtcp_impl2.h

diff --git a/modules/rtp_rtcp/source/rtp_rtcp_impl2.h b/modules/rtp_rtcp/source/rtp_rtcp_impl2.h
index e7a3ac0..b6071d9 100644
--- a/modules/rtp_rtcp/source/rtp_rtcp_impl2.h
+++ b/modules/rtp_rtcp/source/rtp_rtcp_impl2.h
@@ -66,8 +66,14 @@
   // Receiver part.
 
   // Called when we receive an RTCP packet.
-  void IncomingRtcpPacket(const uint8_t* incoming_packet,
-                          size_t incoming_packet_length) override;
+  [[deprecated("Use ArrayView version")]] void IncomingRtcpPacket(
+      const uint8_t* incoming_packet,
+      size_t incoming_packet_length) override {
+    IncomingRtcpPacket(
+        rtc::MakeArrayView(incoming_packet, incoming_packet_length));
+  }
+  void IncomingRtcpPacket(
+      rtc::ArrayView<const uint8_t> incoming_packet) override;
 
   void SetRemoteSSRC(uint32_t ssrc) override;