Rename a few MediaConfig::Video flags for consistency.
enable_cpu_overuse_detection --> enable_cpu_adaptation
disable_prerenderer_smoothing --> enable_prerenderer_smoothing
where the latter also gets opposite meaning.
Bug: none
Change-Id: Ic10de0871a87e86a899aefa72ecb7e46fcdeaa65
Reviewed-on: https://webrtc-review.googlesource.com/40280
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21726}diff --git a/api/peerconnectioninterface.h b/api/peerconnectioninterface.h
index 0f8804a..3cbf263 100644
--- a/api/peerconnectioninterface.h
+++ b/api/peerconnectioninterface.h
@@ -305,13 +305,11 @@
bool dscp() const { return media_config.enable_dscp; }
void set_dscp(bool enable) { media_config.enable_dscp = enable; }
- // TODO(nisse): The corresponding flag in MediaConfig and
- // elsewhere should be renamed enable_cpu_adaptation.
bool cpu_adaptation() const {
- return media_config.video.enable_cpu_overuse_detection;
+ return media_config.video.enable_cpu_adaptation;
}
void set_cpu_adaptation(bool enable) {
- media_config.video.enable_cpu_overuse_detection = enable;
+ media_config.video.enable_cpu_adaptation = enable;
}
bool suspend_below_min_bitrate() const {
@@ -321,14 +319,11 @@
media_config.video.suspend_below_min_bitrate = enable;
}
- // TODO(nisse): The negation in the corresponding MediaConfig
- // attribute is inconsistent, and it should be renamed at some
- // point.
bool prerenderer_smoothing() const {
- return !media_config.video.disable_prerenderer_smoothing;
+ return media_config.video.enable_prerenderer_smoothing;
}
void set_prerenderer_smoothing(bool enable) {
- media_config.video.disable_prerenderer_smoothing = !enable;
+ media_config.video.enable_prerenderer_smoothing = enable;
}
bool experiment_cpu_load_estimator() const {