Migrate to auto-generated LUCI configs
$ lucicfg generate config.star
Docs for lucicfg: https://chromium.googlesource.com/infra/luci/luci-go/+/master/lucicfg/doc/
Just for reference, lucicfg semantic-diff for cr-buildbucket.cfg:
https://pastebin.com/9f0cNUd9
https://chromium.googlesource.com/infra/luci/luci-go/+/master/lucicfg/cli/cmds/diff/diff.go
NOTE: This does not migrate luci-notify.cfg because that's not supported yet in lucicfg.
Change-Id: I02532ba8fa9d951c4775079b6b5799590926922f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126623
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Artem Titarenko <artit@google.com>
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 91dbde8..b0548fd 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -1,11 +1,15 @@
-# Copyright (c) 2018 The WebRTC project authors. All rights reserved.
+# Copyright (c) 2019 The WebRTC project authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
def CheckChangeOnUpload(input_api, output_api):
- return input_api.canned_checks.CheckChangedLUCIConfigs(input_api, output_api)
+ return input_api.RunTests(
+ input_api.canned_checks.CheckLucicfgGenOutput(input_api, output_api,
+ 'config.star')
+ ) + input_api.canned_checks.CheckChangedLUCIConfigs(input_api, output_api)
+ return res
def CheckChangeOnCommit(input_api, output_api):
- return input_api.canned_checks.CheckChangedLUCIConfigs(input_api, output_api)
+ return CheckChangeOnUpload(input_api, output_api)