commit 183e09d23c90a05d6d9afcdad4fb2d5be341ffbb
author Harald Alvestrand <hta@webrtc.org> Thu Jun 28 12:04:41 2018 +0200
committer Commit Bot <commit-bot@chromium.org> Thu Jun 28 10:33:23 2018 +0000
tree 1678f9a6038fe694ef0f8838f52f6b4e394cf960
parent 77cc8182aef6ec97ecd4c115fae5de4f511efa57

Correct data histogram entry for incoming DC

Both incoming and outgoing datachannels should cause
the DATA_ADDED flag to be set.

This CL also moves all tests into their own file, and
improves scaffolding.

Bug: chromium:718508
Change-Id: I5c4c257ccb6f26799f7593bce8b27ebf59015b1e
Reviewed-on: https://webrtc-review.googlesource.com/85348
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23766}

pc/peerconnection.cc

diff --git a/pc/peerconnection.cc b/pc/peerconnection.cc
index d953833..15966ba 100644
--- a/pc/peerconnection.cc
+++ b/pc/peerconnection.cc
@@ -1040,10 +1040,10 @@
         RtpTransceiverProxyWithInternal<RtpTransceiver>::Create(
             signaling_thread(), new RtpTransceiver(cricket::MEDIA_TYPE_VIDEO)));
   }
-  signaling_thread()->PostDelayed(
-      RTC_FROM_HERE,
-      return_histogram_very_quickly_ ? 0 : REPORT_USAGE_PATTERN_DELAY_MS, this,
-      MSG_REPORT_USAGE_PATTERN, nullptr);
+  int delay_ms =
+      return_histogram_very_quickly_ ? 0 : REPORT_USAGE_PATTERN_DELAY_MS;
+  signaling_thread()->PostDelayed(RTC_FROM_HERE, delay_ms, this,
+                                  MSG_REPORT_USAGE_PATTERN, nullptr);
   return true;
 }
 
@@ -4547,6 +4547,7 @@
   rtc::scoped_refptr<DataChannelInterface> proxy_channel =
       DataChannelProxy::Create(signaling_thread(), channel);
   observer_->OnDataChannel(std::move(proxy_channel));
+  NoteUsageEvent(UsageEvent::DATA_ADDED);
 }
 
 rtc::scoped_refptr<RtpTransceiverProxyWithInternal<RtpTransceiver>>