Refactor of GetSimulcastConfig & EncoderStreamFactory.
The main pieces of this refactor are splitting up the creation of
simulcast layers for screenshare or the normal case, more consistent
naming, renaming streams to layers and trying to be more explicit with
some of the logic. Also added TODOs for future work to put more
application control into creating simulcast streams.
Bug: webrtc:8785
Change-Id: Ibf49fa0cc6d890ff96f8ee11c89d93a2c94119d6
Reviewed-on: https://webrtc-review.googlesource.com/47580
Commit-Queue: Seth Hampson <shampson@webrtc.org>
Reviewed-by: Peter Thatcher <pthatcher@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21989}diff --git a/media/engine/webrtcvideoengine.h b/media/engine/webrtcvideoengine.h
index 03fa3e8..f126493 100644
--- a/media/engine/webrtcvideoengine.h
+++ b/media/engine/webrtcvideoengine.h
@@ -516,8 +516,8 @@
EncoderStreamFactory(std::string codec_name,
int max_qp,
int max_framerate,
- bool is_screencast,
- bool conference_mode);
+ bool is_screenshare,
+ bool screenshare_config_explicitly_enabled);
private:
std::vector<webrtc::VideoStream> CreateEncoderStreams(
@@ -528,8 +528,10 @@
const std::string codec_name_;
const int max_qp_;
const int max_framerate_;
- const bool is_screencast_;
- const bool conference_mode_;
+ const bool is_screenshare_;
+ // Allows a screenshare specific configuration, which enables temporal
+ // layering and allows simulcast.
+ const bool screenshare_config_explicitly_enabled_;
};
} // namespace cricket