OnLossNotification() receives references
A typo in a previous CL made OnLossNotification() accept its
single argument as a const-value, rather than a const-reference.
Bug: webrtc:10501
Change-Id: I5e6f9c79f15205b75ec90a53d3fccf3dd9927e33
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133343
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Elad Alon <eladalon@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27659}diff --git a/api/video_codecs/vp8_frame_buffer_controller.h b/api/video_codecs/vp8_frame_buffer_controller.h
index c506fa4..f3d2b1a 100644
--- a/api/video_codecs/vp8_frame_buffer_controller.h
+++ b/api/video_codecs/vp8_frame_buffer_controller.h
@@ -140,7 +140,7 @@
// Called when a loss notification is received.
virtual void OnLossNotification(
- const VideoEncoder::LossNotification loss_notification) = 0;
+ const VideoEncoder::LossNotification& loss_notification) = 0;
};
// Interface for a factory of Vp8FrameBufferController instances.
diff --git a/api/video_codecs/vp8_temporal_layers.cc b/api/video_codecs/vp8_temporal_layers.cc
index 004b10f..7a9cf37 100644
--- a/api/video_codecs/vp8_temporal_layers.cc
+++ b/api/video_codecs/vp8_temporal_layers.cc
@@ -89,7 +89,7 @@
}
void Vp8TemporalLayers::OnLossNotification(
- const VideoEncoder::LossNotification loss_notification) {
+ const VideoEncoder::LossNotification& loss_notification) {
for (auto& controller : controllers_) {
controller->OnLossNotification(loss_notification);
}
diff --git a/api/video_codecs/vp8_temporal_layers.h b/api/video_codecs/vp8_temporal_layers.h
index dcf04c6..f02d288 100644
--- a/api/video_codecs/vp8_temporal_layers.h
+++ b/api/video_codecs/vp8_temporal_layers.h
@@ -62,7 +62,7 @@
void OnRttUpdate(int64_t rtt_ms) override;
void OnLossNotification(
- const VideoEncoder::LossNotification loss_notification) override;
+ const VideoEncoder::LossNotification& loss_notification) override;
private:
std::vector<std::unique_ptr<Vp8FrameBufferController>> controllers_;
diff --git a/modules/video_coding/codecs/vp8/default_temporal_layers.cc b/modules/video_coding/codecs/vp8/default_temporal_layers.cc
index 22b3718..31298fe 100644
--- a/modules/video_coding/codecs/vp8/default_temporal_layers.cc
+++ b/modules/video_coding/codecs/vp8/default_temporal_layers.cc
@@ -552,7 +552,7 @@
void DefaultTemporalLayers::OnRttUpdate(int64_t rtt_ms) {}
void DefaultTemporalLayers::OnLossNotification(
- const VideoEncoder::LossNotification loss_notification) {}
+ const VideoEncoder::LossNotification& loss_notification) {}
TemplateStructure DefaultTemporalLayers::GetTemplateStructure(
int num_layers) const {
diff --git a/modules/video_coding/codecs/vp8/default_temporal_layers.h b/modules/video_coding/codecs/vp8/default_temporal_layers.h
index 67839f6..7a47650 100644
--- a/modules/video_coding/codecs/vp8/default_temporal_layers.h
+++ b/modules/video_coding/codecs/vp8/default_temporal_layers.h
@@ -64,7 +64,7 @@
void OnRttUpdate(int64_t rtt_ms) override;
void OnLossNotification(
- const VideoEncoder::LossNotification loss_notification) override;
+ const VideoEncoder::LossNotification& loss_notification) override;
private:
struct DependencyInfo {
diff --git a/modules/video_coding/codecs/vp8/screenshare_layers.cc b/modules/video_coding/codecs/vp8/screenshare_layers.cc
index 65a445e..85fb6d7 100644
--- a/modules/video_coding/codecs/vp8/screenshare_layers.cc
+++ b/modules/video_coding/codecs/vp8/screenshare_layers.cc
@@ -394,7 +394,7 @@
void ScreenshareLayers::OnRttUpdate(int64_t rtt_ms) {}
void ScreenshareLayers::OnLossNotification(
- const VideoEncoder::LossNotification loss_notification) {}
+ const VideoEncoder::LossNotification& loss_notification) {}
TemplateStructure ScreenshareLayers::GetTemplateStructure(
int num_layers) const {
diff --git a/modules/video_coding/codecs/vp8/screenshare_layers.h b/modules/video_coding/codecs/vp8/screenshare_layers.h
index 69a1737..c7bc5f4 100644
--- a/modules/video_coding/codecs/vp8/screenshare_layers.h
+++ b/modules/video_coding/codecs/vp8/screenshare_layers.h
@@ -68,7 +68,7 @@
void OnRttUpdate(int64_t rtt_ms) override;
void OnLossNotification(
- const VideoEncoder::LossNotification loss_notification) override;
+ const VideoEncoder::LossNotification& loss_notification) override;
private:
enum class TemporalLayerState : int { kDrop, kTl0, kTl1, kTl1Sync };