commit 117c48291cbf2f584da975b5275b352acdf8d052
author Kári Tristan Helgason <kthelgason@webrtc.org> Wed Oct 18 14:22:22 2017 +0200
committer Commit Bot <commit-bot@chromium.org> Thu Oct 19 07:28:12 2017 +0000
tree a95cb1a5b2fc3b7e3dc0e36408e1d20114dba9eb
parent a849fd8ef54774a5e13d77241ced2390e902b43f

Replace use of codec name strings with constants.

Bug: webrtc:8401
Change-Id: I2aee61e026330ec233eb8b3bfe2d529187562249
Reviewed-on: https://webrtc-review.googlesource.com/10814
Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
Commit-Queue: Kári Helgason <kthelgason@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20340}

sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodec.mm

diff --git a/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodec.mm b/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodec.mm
index 46e6a51..2a49189 100644
--- a/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodec.mm
+++ b/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodec.mm
@@ -14,6 +14,12 @@
 #import "RTCVideoCodec+Private.h"
 #import "WebRTC/RTCVideoCodecFactory.h"
 
+NSString *const kVideoCodecVp8Name = @"VP8";
+NSString *const kVideoCodecVp9Name = @"VP9";
+NSString *const kVideoCodecH264Name = @"H264";
+NSString *const kLevel31ConstrainedHigh = @"640c1f";
+NSString *const kLevel31ConstrainedBaseline = @"42e01f";
+
 @implementation RTCVideoCodecInfo
 
 @synthesize name = _name;

sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodecH264.mm

diff --git a/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodecH264.mm b/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodecH264.mm
index b5322b6..d7f9c19 100644
--- a/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodecH264.mm
+++ b/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodecH264.mm
@@ -20,9 +20,6 @@
 #include "system_wrappers/include/field_trial.h"
 
 const char kHighProfileExperiment[] = "WebRTC-H264HighProfile";
-static NSString *kH264CodecName = @"H264";
-static NSString *kLevel31ConstrainedHigh = @"640c1f";
-static NSString *kLevel31ConstrainedBaseline = @"42e01f";
 
 bool IsHighProfileEnabled() {
   return webrtc::field_trial::IsEnabled(kHighProfileExperiment);
@@ -36,7 +33,7 @@
 - (webrtc::CodecSpecificInfo)nativeCodecSpecificInfo {
   webrtc::CodecSpecificInfo codecSpecificInfo;
   codecSpecificInfo.codecType = webrtc::kVideoCodecH264;
-  codecSpecificInfo.codec_name = [kH264CodecName cStringUsingEncoding:NSUTF8StringEncoding];
+  codecSpecificInfo.codec_name = [kVideoCodecH264Name cStringUsingEncoding:NSUTF8StringEncoding];
   codecSpecificInfo.codecSpecific.H264.packetization_mode =
       (webrtc::H264PacketizationMode)_packetizationMode;
 
@@ -50,7 +47,7 @@
 
 - (NSArray<RTCVideoCodecInfo *> *)supportedCodecs {
   NSMutableArray<RTCVideoCodecInfo *> *codecs = [NSMutableArray array];
-  NSString *codecName = kH264CodecName;
+  NSString *codecName = kVideoCodecH264Name;
 
   if (IsHighProfileEnabled()) {
     NSDictionary<NSString *, NSString *> *constrainedHighParams = @{
@@ -89,7 +86,7 @@
 }
 
 - (NSArray<RTCVideoCodecInfo *> *)supportedCodecs {
-  NSString *codecName = kH264CodecName;
+  NSString *codecName = kVideoCodecH264Name;
   return @[ [[RTCVideoCodecInfo alloc] initWithName:codecName parameters:nil] ];
 }