commit 117c48291cbf2f584da975b5275b352acdf8d052
author Kári Tristan Helgason <kthelgason@webrtc.org> Wed Oct 18 14:22:22 2017 +0200
committer Commit Bot <commit-bot@chromium.org> Thu Oct 19 07:28:12 2017 +0000
tree a95cb1a5b2fc3b7e3dc0e36408e1d20114dba9eb
parent a849fd8ef54774a5e13d77241ced2390e902b43f

Replace use of codec name strings with constants.

Bug: webrtc:8401
Change-Id: I2aee61e026330ec233eb8b3bfe2d529187562249
Reviewed-on: https://webrtc-review.googlesource.com/10814
Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
Commit-Queue: Kári Helgason <kthelgason@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20340}

examples/objc/AppRTCMobile/ARDVideoEncoderFactory.m

diff --git a/examples/objc/AppRTCMobile/ARDVideoEncoderFactory.m b/examples/objc/AppRTCMobile/ARDVideoEncoderFactory.m
index e4aafcc..b1163c4 100644
--- a/examples/objc/AppRTCMobile/ARDVideoEncoderFactory.m
+++ b/examples/objc/AppRTCMobile/ARDVideoEncoderFactory.m
@@ -11,23 +11,21 @@
 #import "ARDVideoEncoderFactory.h"
 
 #import "ARDSettingsModel.h"
+#import "WebRTC/RTCVideoCodec.h"
 #import "WebRTC/RTCVideoCodecH264.h"
 #import "WebRTC/RTCVideoEncoderVP8.h"
 #import "WebRTC/RTCVideoEncoderVP9.h"
 
-static NSString *kLevel31ConstrainedHigh = @"640c1f";
-static NSString *kLevel31ConstrainedBaseline = @"42e01f";
-
 @implementation ARDVideoEncoderFactory
 
 @synthesize preferredCodec;
 
 - (id<RTCVideoEncoder>)createEncoder:(RTCVideoCodecInfo *)info {
-  if ([info.name isEqualToString:@"H264"]) {
+  if ([info.name isEqualToString:kVideoCodecH264Name]) {
     return [[RTCVideoEncoderH264 alloc] initWithCodecInfo:info];
-  } else if ([info.name isEqualToString:@"VP8"]) {
+  } else if ([info.name isEqualToString:kVideoCodecVp8Name]) {
     return [RTCVideoEncoderVP8 vp8Encoder];
-  } else if ([info.name isEqualToString:@"VP9"]) {
+  } else if ([info.name isEqualToString:kVideoCodecVp9Name]) {
     return [RTCVideoEncoderVP9 vp9Encoder];
   }
 
@@ -43,7 +41,7 @@
     @"packetization-mode" : @"1",
   };
   RTCVideoCodecInfo *constrainedHighInfo =
-      [[RTCVideoCodecInfo alloc] initWithName:@"H264" parameters:constrainedHighParams];
+      [[RTCVideoCodecInfo alloc] initWithName:kVideoCodecH264Name parameters:constrainedHighParams];
   [codecs addObject:constrainedHighInfo];
 
   NSDictionary<NSString *, NSString *> *constrainedBaselineParams = @{
@@ -52,13 +50,16 @@
     @"packetization-mode" : @"1",
   };
   RTCVideoCodecInfo *constrainedBaselineInfo =
-      [[RTCVideoCodecInfo alloc] initWithName:@"H264" parameters:constrainedBaselineParams];
+      [[RTCVideoCodecInfo alloc] initWithName:kVideoCodecH264Name
+                                   parameters:constrainedBaselineParams];
   [codecs addObject:constrainedBaselineInfo];
 
-  RTCVideoCodecInfo *vp8Info = [[RTCVideoCodecInfo alloc] initWithName:@"VP8" parameters:nil];
+  RTCVideoCodecInfo *vp8Info =
+      [[RTCVideoCodecInfo alloc] initWithName:kVideoCodecVp8Name parameters:nil];
   [codecs addObject:vp8Info];
 
-  RTCVideoCodecInfo *vp9Info = [[RTCVideoCodecInfo alloc] initWithName:@"VP9" parameters:nil];
+  RTCVideoCodecInfo *vp9Info =
+      [[RTCVideoCodecInfo alloc] initWithName:kVideoCodecVp9Name parameters:nil];
   [codecs addObject:vp9Info];
 
   NSMutableArray<RTCVideoCodecInfo *> *orderedCodecs = [NSMutableArray array];