commit 0e6758d7efc64a93d27f45b278d867d7f13f2131
author hbos <hbos@webrtc.org> Wed Aug 31 07:57:36 2016 -0700
committer Commit bot <commit-bot@chromium.org> Wed Aug 31 14:57:44 2016 +0000
tree 11eaf185bf6df8e2ada3e9821e53008c5430c149
parent a69d973267d4a10cbb51b9c47023ba4a3c854167

RTCStatsCollector: timestamps updated.

Using a timestamp based on a timer that is monotonically increasing for
the cache, so that cache's freshness can be checked regardless of if
system clock is modified.

Using a system clock for the stats' timestamp, which needs to be
relative to UNIX epoch (Jan 1, 1970, UTC).

This CL removes the dependency on faketiming.h.

BUG=chromium:627816
NOTRY=True

Review-Url: https://codereview.webrtc.org/2299643002
Cr-Commit-Position: refs/heads/master@{#13997}

webrtc/stats/rtcstatscollector.h

diff --git a/webrtc/stats/rtcstatscollector.h b/webrtc/stats/rtcstatscollector.h
index 1e4d6c3..735421d 100644
--- a/webrtc/stats/rtcstatscollector.h
+++ b/webrtc/stats/rtcstatscollector.h
@@ -16,7 +16,7 @@
 #include "webrtc/api/rtcstats_objects.h"
 #include "webrtc/api/rtcstatsreport.h"
 #include "webrtc/base/scoped_ref_ptr.h"
-#include "webrtc/base/timing.h"
+#include "webrtc/base/timeutils.h"
 
 namespace webrtc {
 
@@ -28,9 +28,7 @@
  public:
   explicit RTCStatsCollector(
       PeerConnection* pc,
-      double cache_lifetime = 0.05,
-      std::unique_ptr<rtc::Timing> timing = std::unique_ptr<rtc::Timing>(
-          new rtc::Timing()));
+      int64_t cache_lifetime_us = 50 * rtc::kNumMicrosecsPerMillisec);
 
   // Gets a recent stats report. If there is a report cached that is still fresh
   // it is returned, otherwise new stats are gathered and returned. A report is
@@ -44,13 +42,16 @@
  private:
   bool IsOnSignalingThread() const;
 
-  std::unique_ptr<RTCPeerConnectionStats> ProducePeerConnectionStats() const;
+  std::unique_ptr<RTCPeerConnectionStats> ProducePeerConnectionStats(
+      int64_t timestamp_us) const;
 
   PeerConnection* const pc_;
-  mutable std::unique_ptr<rtc::Timing> timing_;
-  // Time relative to the UNIX epoch (Jan 1, 1970, UTC), in seconds.
-  double cache_timestamp_;
-  double cache_lifetime_;  // In seconds.
+  // A timestamp, in microseconds, that is based on a timer that is
+  // monotonically increasing. That is, even if the system clock is modified the
+  // difference between the timer and this timestamp is how fresh the cached
+  // report is.
+  int64_t cache_timestamp_us_;
+  int64_t cache_lifetime_us_;
   rtc::scoped_refptr<const RTCStatsReport> cached_report_;
 };